You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry - hang on for a few more moments, we found an issue with one of the fixes 😅 We made a fix already, so the version to test will be 1.2.0-8. It should start being deployed shortly.
Activity
mountiny commentedon Sep 13, 2022
Checking #10937 off as that has already been QA'ed in the previous version
Julesssss commentedon Sep 13, 2022
@Expensify/applauseleads the automated message failed to post, but all platform builds should now be available for testing.
OSBotify commentedon Sep 13, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.0-0 🚀
mvtglobally commentedon Sep 13, 2022
@francoisl @Julesssss Regression is almost completed
PR #10820 is failing due to #10966
PR #10935 is failing due to #10963 & #10970
jasperhuangg commentedon Sep 13, 2022
Just noticed that custom units are currently broken on staging but not on prod.. investigating
Screen.Recording.2022-09-13.at.2.01.02.PM.mov
cc @Julesssss @mvtglobally @francoisl
jasperhuangg commentedon Sep 13, 2022
Are there any other deploy checklists that haven't hit prod yet?
jasperhuangg commentedon Sep 13, 2022
Looks like reverting #10873 locally fixes things. I say we revert it on staging too.
cc @arosiclair
mvtglobally commentedon Sep 13, 2022
There were couple issues logged around this area. Not sure if this related #10877
jasperhuangg commentedon Sep 13, 2022
Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.
cc @mvtglobally
francoisl commentedon Sep 13, 2022
That one was already crashing in production, so no need to block the deploy on it.
Look into those
@jasperhuangg thanks for looking. I'm trying to reproduce locally and see if there's a simple fix we could CP. Otherwise, let's revert that PR.
mvtglobally commentedon Sep 13, 2022
@francoisl @jasperhuangg do you need a new issue created for this blocker?
23 remaining items
francoisl commentedon Sep 15, 2022
Let's not check #10784 just yet - we're still discussing reverting it. It should then also resolve #11006.
We tested on web only, can you test on the other platforms please?
luacmartins commentedon Sep 15, 2022
Tested #10974 and it's a pass. Checking it off.
francoisl commentedon Sep 15, 2022
We reproduced #11011 in production so we're going to remove the deployblocker label and keep it as a daily to be investigated.
OSBotify commentedon Sep 15, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.0-6🚀francoisl commentedon Sep 15, 2022
There's going to be a 1.2.0-7 very shortly, please hang on a second.
OSBotify commentedon Sep 15, 2022
OSBotify commentedon Sep 15, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.0-7🚀OSBotify commentedon Sep 15, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-7 has been deployed to staging 🎉
francoisl commentedon Sep 15, 2022
Sorry - hang on for a few more moments, we found an issue with one of the fixes 😅 We made a fix already, so the version to test will be 1.2.0-8. It should start being deployed shortly.
OSBotify commentedon Sep 15, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.0-8🚀francoisl commentedon Sep 16, 2022
#11022 and #11029 are 👍 on Web, Desktop and Android, just waiting on iOS.
OSBotify commentedon Sep 16, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-8 has been deployed to staging 🎉
francoisl commentedon Sep 16, 2022
@chiragsalian was able to test #11022 and #11029 on iOS so we're all set!
francoisl commentedon Sep 16, 2022