Skip to content

Deploy Checklist: New Expensify 2022-09-13 #10958

Closed

Description

@OSBotify

Release Version: 1.2.0-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. mountiny commented on Sep 13, 2022

    @mountiny
    Contributor

    Checking #10937 off as that has already been QA'ed in the previous version

  2. Julesssss commented on Sep 13, 2022

    @Julesssss
    Contributor

    @Expensify/applauseleads the automated message failed to post, but all platform builds should now be available for testing.

  3. OSBotify commented on Sep 13, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.0-0 🚀

  4. mvtglobally commented on Sep 13, 2022

    @mvtglobally

    @francoisl @Julesssss Regression is almost completed

    PR #10820 is failing due to #10966
    PR #10935 is failing due to #10963 & #10970

  5. jasperhuangg commented on Sep 13, 2022

    @jasperhuangg
    Contributor

    Just noticed that custom units are currently broken on staging but not on prod.. investigating

    Screen.Recording.2022-09-13.at.2.01.02.PM.mov

    cc @Julesssss @mvtglobally @francoisl

  6. jasperhuangg commented on Sep 13, 2022

    @jasperhuangg
    Contributor

    Are there any other deploy checklists that haven't hit prod yet?

  7. jasperhuangg commented on Sep 13, 2022

    @jasperhuangg
    Contributor

    Looks like reverting #10873 locally fixes things. I say we revert it on staging too.

    cc @arosiclair

  8. mvtglobally commented on Sep 13, 2022

    @mvtglobally

    There were couple issues logged around this area. Not sure if this related #10877

    Screen Shot 2022-09-13 at 5 10 24 PM

  9. jasperhuangg commented on Sep 13, 2022

    @jasperhuangg
    Contributor

    There were couple issues logged around this area. Not sure if this related #10877

    Screen Shot 2022-09-13 at 5 10 24 PM

    Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

    cc @mvtglobally

  10. francoisl commented on Sep 13, 2022

    @francoisl
    Contributor

    PR #10820 is failing due to #10966

    That one was already crashing in production, so no need to block the deploy on it.

    PR #10935 is failing due to #10963 & #10970

    Look into those

    Ah that's unrelated, that was fixed in a previous PR. I can confirm that the new issues are caused by #10873.

    @jasperhuangg thanks for looking. I'm trying to reproduce locally and see if there's a simple fix we could CP. Otherwise, let's revert that PR.

  11. mvtglobally commented on Sep 13, 2022

    @mvtglobally

    @francoisl @jasperhuangg do you need a new issue created for this blocker?

  12. 23 remaining items

  13. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    Let's not check #10784 just yet - we're still discussing reverting it. It should then also resolve #11006.


    PR #10974 are you checking internally already?

    We tested on web only, can you test on the other platforms please?

  14. luacmartins commented on Sep 15, 2022

    @luacmartins
    Contributor

    Tested #10974 and it's a pass. Checking it off.

  15. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    We reproduced #11011 in production so we're going to remove the deployblocker label and keep it as a daily to be investigated.

  16. OSBotify commented on Sep 15, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-6 🚀

  17. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    There's going to be a 1.2.0-7 very shortly, please hang on a second.

  18. OSBotify commented on Sep 15, 2022

    @OSBotify
    Author
  19. OSBotify commented on Sep 15, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-7 🚀

  20. OSBotify commented on Sep 15, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-7 has been deployed to staging 🎉

  21. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    Sorry - hang on for a few more moments, we found an issue with one of the fixes 😅 We made a fix already, so the version to test will be 1.2.0-8. It should start being deployed shortly.

  22. OSBotify commented on Sep 15, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.0-8 🚀

  23. francoisl commented on Sep 16, 2022

    @francoisl
    Contributor

    #11022 and #11029 are 👍 on Web, Desktop and Android, just waiting on iOS.

  24. OSBotify commented on Sep 16, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.0-8 has been deployed to staging 🎉

  25. francoisl commented on Sep 16, 2022

    @francoisl
    Contributor

    @chiragsalian was able to test #11022 and #11029 on iOS so we're all set!

  26. francoisl commented on Sep 16, 2022

    @francoisl
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions