You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat #11085
IMO, Showing vague names or using terms like temp or image_picker in the name is not good for brand value. I have seen many users making fuss out of such things on the internet which could be bad for branch.
Solution:
Choose a proper name for the image or don't the show the name when image is taken directly from the camera.
Action Performed:
Open any chat.
Click add attachment option from the ➕ icon.
Choose 📷 Take Photo.
Click a photo.
On the Preview page header check the name of the image.
Expected Result:
Show a user friendly name for the attachment images for take pictures option
New expected result: The attachment name shouldn't be visible when there is a preview
Actual Result:
generic image name displayed
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.2.1-0 Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
I agree that we don't need to show a temp filename when sending an attachment that is an image from your phone. I would think we can just remove the filename when attaching from the phone.
changed the title [-][$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/-][+][HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/+]on Feb 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-02-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Alrighty, payments are due. I've sent the following offers:
@Puneet-here $3,000 for the fix and merge within 3 days @thesahindia $3,000 for the review and merge within 3 days @parasharrajat $250 for the bug report.
Please accept or let me know if that isn't accurate!
Activity
melvin-bot commentedon Sep 19, 2022
Triggered auto assignment to @sakluger (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.sakluger commentedon Sep 20, 2022
I agree that we don't need to show a temp filename when sending an attachment that is an image from your phone. I would think we can just remove the filename when attaching from the phone.
melvin-bot commentedon Sep 20, 2022
Triggered auto assignment to @Julesssss (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.170 remaining items
[-][$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/-][+][HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/+]MelvinBot commentedon Feb 11, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Feb 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-02-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
trjExpensify commentedon Feb 20, 2023
Alrighty, payments are due. I've sent the following offers:
@Puneet-here $3,000 for the fix and merge within 3 days
@thesahindia $3,000 for the review and merge within 3 days
@parasharrajat $250 for the bug report.
Please accept or let me know if that isn't accurate!
trjExpensify commentedon Feb 20, 2023
@thesahindia - settled up!
Puneet-here commentedon Feb 21, 2023
Accepted!
trjExpensify commentedon Feb 21, 2023
@Puneet-here @parasharrajat - settled up! 🎉