Skip to content

[HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat #11085

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

IMO, Showing vague names or using terms like temp or image_picker in the name is not good for brand value. I have seen many users making fuss out of such things on the internet which could be bad for branch.

Solution:

Choose a proper name for the image or don't the show the name when image is taken directly from the camera.

Action Performed:

  1. Open any chat.
  2. Click add attachment option from the ➕ icon.
  3. Choose 📷 Take Photo.
  4. Click a photo.
  5. On the Preview page header check the name of the image.

Expected Result:

Show a user friendly name for the attachment images for take pictures option

The expected result was updated after this conversation

New expected result: The attachment name shouldn't be visible when there is a preview

image

Actual Result:

generic image name displayed

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.1-0
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-09-19T003444 130

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661616286179839

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f82e1a898c313a5
  • Upwork Job ID: 1615996670996901888
  • Last Price Increase: 2023-01-26

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    NewFeatureSomething to build that is a new item.
    on Sep 19, 2022
  2. melvin-bot commented on Sep 19, 2022

    @melvin-bot

    Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 19, 2022
  4. sakluger commented on Sep 20, 2022

    @sakluger
    Contributor

    I agree that we don't need to show a temp filename when sending an attachment that is an image from your phone. I would think we can just remove the filename when attaching from the phone.

  5. removed their assignment
    on Sep 20, 2022
  6. melvin-bot commented on Sep 20, 2022

    @melvin-bot

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. added and removed on Sep 20, 2022
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 20, 2022
  9. 170 remaining items

  10. changed the title [-][$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/-] [+][HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat[/+] on Feb 11, 2023
  11. MelvinBot commented on Feb 11, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. MelvinBot commented on Feb 11, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-02-18. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. trjExpensify commented on Feb 20, 2023

    @trjExpensify
    Contributor

    Alrighty, payments are due. I've sent the following offers:

    @Puneet-here $3,000 for the fix and merge within 3 days
    @thesahindia $3,000 for the review and merge within 3 days
    @parasharrajat $250 for the bug report.

    Please accept or let me know if that isn't accurate!

  14. trjExpensify commented on Feb 20, 2023

    @trjExpensify
    Contributor

    @thesahindia - settled up!

  15. Puneet-here commented on Feb 21, 2023

    @Puneet-here
    Contributor

    Accepted!

  16. trjExpensify commented on Feb 21, 2023

    @trjExpensify
    Contributor

    @Puneet-here @parasharrajat - settled up! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions