Repository navigation
remove file name from attachment modal - #14962
Merged
aldo-expensify merged 1 commit intoFeb 10, 2023
Merged
Conversation
Puneet-here
marked this pull request as ready for review
February 8, 2023 22:49
melvin-bot
Bot
requested review from
aldo-expensify and
thesahindia
and removed request for
a team
February 8, 2023 22:49
Contributor
|
@aldo-expensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Member
Reviewer Checklist
Screenshots/Videos |
thesahindia
approved these changes
Feb 9, 2023
thesahindia
left a comment
Member
There was a problem hiding this comment.
Looks good and works well!
cc: @aldo-expensify
aldo-expensify
approved these changes
Feb 10, 2023
Contributor
|
LGTM and tested well, thank you both! |
9 tasks done
Contributor
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.2.69-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.2.69-2 🚀
|
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Details
We have decided to remove the file name from attachment modal because at native the names aren't user friendly and the name changing approach is inconsistent, so the most consistent option was to remove the attachment name.
Fixed Issues
$ #11085
PROPOSAL: #11085 (comment)
Tests
+> add attachmentOffline tests
N/a
QA Steps
+> add attachmentPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android