Repository navigation
Deploy Checklist: New Expensify 2022-10-05 #11623
Description
Release Version: 1.2.12-4
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Refactor ValidationStep Form #10946
- [Refactor] Use new API Command: VerifyIdentityForBankAccount #10967
- Prevent picker onInputChange firing on re-render #11120
- Add space after emoji #11161
- DRY up the report filtering logic for the LHN and optionslist #11226
- fix "Unresponsive camera opens on iOS if the camera permission is denied" #11231
- [Snyk] Security upgrade electron from 17.4.11 to 18.3.14 #11279
- [NO QA] Remove deprecated command
GetRequestCountryCode#11369 - fix/11157 Unable to save first name, last name and time zone when user is offline #11371
- Replace md5 by simple java-like string hash (Performance) #11400
- Disable edit and delete context menu action in archived room #11412
- Move
shouldShowComposeInputto it's own key #11434 - Kill
currentlyViewedReportID#11450 - Change cursor to default at new message line indicator #11474
- Fix
participantslist when creating new workspace room #11475 - [No QA]Do not run CLA when a PR is closed #11480
- Prettify the wallet action flow's
ActivateStepcomponent #11489 - [Performance] Remove withOnyx() subscription in BaseReportActionContextMenu #11530
- [Snyk] Security upgrade electron from 18.3.14 to 18.3.15 #11531
- Fix Crash .getMakeDefaultPaymentOnyxData #11533
- Clean up onyx Policy & PolicyMemberList duplicate subscription #11537
- Fix Cannot get rid of error message when X button is pressed #11538
- Add early return to ActiveClientManager #11539
- [No QA] rename checklist names to Author and Reviewer #11544
- Remove duplicated error message #11545
- Only debounce saving draft when user is typing #11552
- [No QA] Remove unused CreatePolicyRoom api command #11553
- [CP Staging] save routingNumber and accountNumber in connectBankAccountManually #11556
- Wrapped Request help section with scroll view #11557
- [NO QA] Update MenuItem for future Account settings pages #11583
- Reset lastAccessedWorkspacePolicyID when delete the workspace #11601
- Fix the broken logic for if a report has an outstanding IOU #11612
- Fix masked account number and default values #11616
- Check for unread reports at the end of the filter logic #11631
- Only show reports without comments if they are non-archived policy rooms #11634
- [No QA] Revert "[Refactor] Use new API Command: VerifyIdentityForBankAccount" #11702
- Make sure that archived reports are shown properly in the LHN and the search options #11725
Deploy Blockers:
- mWeb - VBA - Error message appears after submitting all required info in Onfido flow #7270
- [$500] The account number is masked and you can't move forward with VBA flow - Reported by @Puneet-here #11318
- BUG : In focus mode pinned / drafted items not shown in LHN #11624
- Web - LHN - Conversation that doesn't have a message doesn't disappear from LHN #11633
- mWeb - Login -Offline indicator is missing in "Resent link" page #11637
- Workspace - Blueline around the fields does not disappear moving to another field #11646
- BUG:Pay with debit card - Doesn't auto-complete the zip and state correctly #11654
- Workspace - No #admins and #announce rooms after creating workspace #11685
- Search - Room and Workspace does not displayed for invited user #11686
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Oct 6, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.12-0 🚀
luacmartins commentedon Oct 6, 2022
Checking off #11318 since it was solved yesterday, but we reopened the issue to pay the reporting bonus to the contributor.
OSBotify commentedon Oct 6, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.12-1🚀OSBotify commentedon Oct 6, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.12-1 has been deployed to staging 🎉
OSBotify commentedon Oct 6, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.12-2🚀OSBotify commentedon Oct 6, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.12-2 has been deployed to staging 🎉
mvtglobally commentedon Oct 7, 2022
Regression is completed
We are checking new CPs and confirm in the morning
PR #10967 is Blocked on mWeb due to #7270
PR #11226 is failing due to #11667. not a blocker. Checking off
PR #11371 is failing due to #11632. Its not repro in PROD as its new feature. pls double check if we can check it off.
PR #11533 is failing due to #11660.
PR #11557 is failing due to #11629. repro in PROD. checking off
mountiny commentedon Oct 7, 2022
Checking #11654 (comment) off as it was aslo repro in production so no deploy blocker.
mvtglobally commentedon Oct 7, 2022
Checking off #11634
CP #11631 is failing #11669
mvtglobally commentedon Oct 7, 2022
Outstanding items summary
#11538 (comment) - internal QA
CP #11631 is failing #11669
PR #10967 is Blocked on mWeb due to #7270
PR #11371 is failing due to #11632. Can we check it off?
PR #11533 is failing due to #11660.
AndrewGable commentedon Oct 7, 2022
Since #11632 is not reproducible, then yes lets check off #11371
johnmlee101 commentedon Oct 7, 2022
#11669 doesn't look to be a blocker and is expected functionality
7 remaining items
mvtglobally commentedon Oct 10, 2022
@AndrewGable checking
mvtglobally commentedon Oct 10, 2022
@AndrewGable Can you confirm the build we should be checking for #11533 ? It seems to be still giving an error on 1.2.12-2
AndrewGable commentedon Oct 10, 2022
This error I believe seems different, it was fixed on the backend so
1.2.12-2is fine. Do you have any other bank accounts you can test with?mvtglobally commentedon Oct 10, 2022
@AndrewGable We only have Fidelity working right now. I will check with the team if they were able to add any other type. But if not, this may need to be validated internally
OSBotify commentedon Oct 10, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.12-3🚀JmillsExpensify commentedon Oct 10, 2022
Agree that's a different error. I think the product in the screenshot above is working as designed.
AndrewGable commentedon Oct 10, 2022
Checked off #11533 with @JmillsExpensify confirmation. Checked off #10967 since it was reverted and CP-ed.
mvtglobally commentedon Oct 10, 2022
@AndrewGable thanks for confirmation. We are down to 2 Blockers
#11685
#11686
OSBotify commentedon Oct 10, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.12-3 has been deployed to staging 🎉
AndrewGable commentedon Oct 10, 2022
Thank you @mvtglobally - We are working on a fix
mvtglobally commentedon Oct 11, 2022
@AndrewGable hopefully we can get a new deploy today. pls tag us if anything needs retests
OSBotify commentedon Oct 11, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.12-4🚀AndrewGable commentedon Oct 11, 2022
OSBotify commentedon Oct 11, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.12-4 has been deployed to staging 🎉