Repository navigation
URL does not get highlighted properly in Expensify.cash #1234
Description
If you haven’t already, check out our contributing guidelines for onboarding!
Platform
All platforms:
- Web
- macOS Desktop
- Android
- iOS
- Mobile web
Version
1.0.1-341
Action Performed (reproducible steps):
- Paste the following into an Expensify.cash chat:
Check out [this link](https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22Ufjjim%22)+AND+timestamp:[2021-01-08T03:48:10.389Z+TO+2021-01-08T05:48:10.389Z]&index=logs_expensify-008878)!
- Send the message.
Expected Result
The link is created properly and looks like this:
Actual Result
The URL is not properly highlighted and the link is not created properly.
Solution notes
The code that processes markdown is actually not in Expensify/Expensify.cash, but Expensify/expensify-common.
Add a unit test for this URL in ExpensiMark-test.js and then fix ExpensiMark to handle the URL properly.
A solution will not be considered complete unless it:
- Creates an automated unit test to cover this URL and potentially others like it,
- Provides videos of the working URL on all 5 platforms of Expensify.cash (Web, macOS Desktop, iOS, Android, mobile web). These must be video screen recordings and not static screenshots, so that we know that the correct URL was used to create the link, and that the link was created properly.
Metadata
Metadata
Assignees
Labels
No labels
Activity
roryabraham commentedon Jan 13, 2021
Posted to Upwork: https://www.upwork.com/jobs/~01c9f994a1995338e5
roryabraham commentedon Jan 13, 2021
Additionally, would like to see that the solution also works for this URL:
http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabledparasharrajat commentedon Jan 14, 2021
is there any restriction of using regexp only?
roryabraham commentedon Jan 14, 2021
What else would you use? These are the regexes we have currently
Dal-Papa commentedon Jan 18, 2021
I was about to create a similar issue for the
:~:text=syntax from Google Chrome (like here)parasharrajat commentedon Jan 19, 2021
@roryabraham Sorry for the late reply. I checked it. After making some adjustments to the URL Regex we can cover your case and other cases and also @Dal-Papa case.
But there is one regression.
The above URL is being converted to link successfully but Strike conversion is swapping
~with<del>.Can we adjust the
strikeregex to discard match when we found:~:text?Dal-Papa commentedon Jan 19, 2021
@parasharrajat : Should we rather fix it so that if the
<del>doesn't have an ending~, then it doesn't strike ?parasharrajat commentedon Jan 19, 2021
@Dal-Papa so
is converted to
which then will be replaced with
<del>in place of~I see a possible solution that we can adopt is to check if
~is between<aand>thus do not parse it as strike token.lucas-neuhaus-dev commentedon Jan 25, 2021
@roryabraham
Is this issue still open for grabs?
I did some tests and I believe I can create a PR with everything that is required on the deliverable (including the additions on the comments section).
kadiealexander commentedon Jan 28, 2021
Hey @lucas-neuhaus-dev! Please review the rules here for submitting a Pull Request. Looking forward to hearing your proposal!
lucas-neuhaus-dev commentedon Jan 28, 2021
Hi @kadiealexander, sorry I forgot to comment here, I created the PR this afternoon.
Here it is: Expensify/expensify-common#327.
I will mention you in the description there as well.
Edit: Now I realized (even having done it 4 times before) that I jumped the proposal step and went direct for the PR.
My bad. But I think it is better to keep the discussion on the PR page now, and I can fix any possible review.