Skip to content

Fixed URL highlight - #327

Merged
joelbettner merged 1 commit into
Expensify:masterfrom
lucas-neuhaus-dev:url-highlight-fix
Feb 2, 2021
Merged

joelbettner merged 1 commit into
Expensify:masterfrom
lucas-neuhaus-dev:url-highlight-fix

Conversation

@lucas-neuhaus-dev

@lucas-neuhaus-dev lucas-neuhaus-dev commented Jan 28, 2021 •

Copy link
Copy Markdown
Contributor

@roryabraham @kadiealexander will you please review this?

Fixed the URL highlighting issue when URL's included :, ~, / (on param), [ and ].
Added ability to use : and / on a link text (between [ and ]).

Made sure all three URL's mentioned on the issue page worked, without causing regressions. Added tests for all this cases, and plus a couple more I could think of (and was having trouble with).

Fixed Issues

Fixes #1234

Tests & QA

  1. What unit/integration tests cover your change? What autoQA tests cover your change?

Added quite a number of test URL's on ExpensiMark-test.js.

  1. What tests did you perform that validates your changed worked?

On the gifs presented next, the following string was pasted on all the platforms:

Testing [first](https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22Ufjjim%22)+AND+timestamp:[2021-01-08T03:48:10.389Z+TO+2021-01-08T05:48:10.389Z]&index=logs_expensify-008878), [second](http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabled), and [third](http://github.com/Expensify/Expensify.cash/issues/123#:~:text=Please%20work/Expensify.cash)!

Web

desktop

Desktop

desktop

Android

android

iOS

ios

@lucas-neuhaus-dev
lucas-neuhaus-dev requested a review from a team as a code owner January 28, 2021 20:02
@github-actions

github-actions Bot commented Jan 28, 2021 •

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify
botify requested review from joelbettner and removed request for a team January 28, 2021 20:02
@lucas-neuhaus-dev

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@lucas-neuhaus-dev

Copy link
Copy Markdown
Contributor Author

recheck

Comment thread __tests__/ExpensiMark-test.js Resolved
@joelbettner
joelbettner merged commit 0f58cc5 into Expensify:master Feb 2, 2021
@joelbettner

Copy link
Copy Markdown
Contributor

👍 LGTM!

@github-actions github-actions Bot locked and limited conversation to collaborators Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL does not get highlighted properly in Expensify.cash

2 participants