Repository navigation
Fixed URL highlight - #327
Merged
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
lucas-neuhaus-dev
force-pushed
the
url-highlight-fix
branch
from
February 2, 2021 02:03
edf3464 to
777d834
Compare
joelbettner
approved these changes
Feb 2, 2021
Contributor
|
👍 LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roryabraham @kadiealexander will you please review this?
Fixed the URL highlighting issue when URL's included
:,~,/(on param),[and].Added ability to use
:and/on a link text (between[and]).Made sure all three URL's mentioned on the issue page worked, without causing regressions. Added tests for all this cases, and plus a couple more I could think of (and was having trouble with).
Fixed Issues
Fixes #1234
Tests & QA
Added quite a number of test URL's on
ExpensiMark-test.js.On the gifs presented next, the following string was pasted on all the platforms:
Web
Desktop
Android
iOS