Skip to content

Android build 1.2.24-1 crashes on launch #12522

Closed

Description

@Julesssss

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Android build 1.2.24-1 crashes on launch, reported here.

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 7, 2022
  2. self-assigned this
    on Nov 7, 2022
  3. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. OSBotify commented on Nov 7, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

  6. isabelastisser commented on Nov 7, 2022

    @isabelastisser
    Contributor

    This is the first time I was assigned an hourly engineering issue so I talked to Jules in the chat and since this is a pretty critical internal issue, there's no action needed from me.

  7. removed their assignment
    on Nov 7, 2022
  8. Julesssss commented on Nov 7, 2022

    @Julesssss
    ContributorAuthor

    Trying this fix. If it doesn't work we should just go ahead and merge the React Native 0.70.5 hotfix changes into our fork and deploy. But first, let's try this quicker solution.

  9. Julesssss commented on Nov 7, 2022

    @Julesssss
    ContributorAuthor

    Here's more context about the original issue.

  10. Julesssss commented on Nov 7, 2022

    @Julesssss
    ContributorAuthor

    PR is ready, I'm just compiling the release build for testing. I ran into an OOM error on the first attempt 😓

  11. Julesssss commented on Nov 7, 2022

    @Julesssss
    ContributorAuthor
  12. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  13. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  14. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  15. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  16. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  17. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  18. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    Closing this out! 1.2.24-4 is not crashing on launch! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions