You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is the first time I was assigned an hourly engineering issue so I talked to Jules in the chat and since this is a pretty critical internal issue, there's no action needed from me.
Trying this fix. If it doesn't work we should just go ahead and merge the React Native 0.70.5 hotfix changes into our fork and deploy. But first, let's try this quicker solution.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
Activity
melvin-bot commentedon Nov 7, 2022
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.OSBotify commentedon Nov 7, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 7, 2022
Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.
isabelastisser commentedon Nov 7, 2022
This is the first time I was assigned an hourly engineering issue so I talked to Jules in the chat and since this is a pretty critical internal issue, there's no action needed from me.
Julesssss commentedon Nov 7, 2022
Trying this fix. If it doesn't work we should just go ahead and merge the React Native
0.70.5hotfix changes into our fork and deploy. But first, let's try this quicker solution.Julesssss commentedon Nov 7, 2022
Here's more context about the original issue.
Julesssss commentedon Nov 7, 2022
PR is ready, I'm just compiling the release build for testing. I ran into an OOM error on the first attempt 😓
Julesssss commentedon Nov 7, 2022
PR in review
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 7, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
yuwenmemon commentedon Nov 8, 2022
Closing this out!
1.2.24-4is not crashing on launch! 🎉