Skip to content

Deploy Checklist: New Expensify 2022-11-04 #12476

Closed

Description

@OSBotify

Release Version: 1.2.24-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. roryabraham commented on Nov 4, 2022

    @roryabraham
    Contributor

    Love these shorter checklists, let's keep up with daily deploys 🚀

  2. OSBotify commented on Nov 4, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.24-0 🚀

  3. mvtglobally commented on Nov 4, 2022

    @mvtglobally

    @roryabraham did Android build go through?

  4. Julesssss commented on Nov 4, 2022

    @Julesssss
    Contributor

    @roryabraham did Android build go through?

    Nope, but we're currently investigating.

  5. mvtglobally commented on Nov 7, 2022

    @mvtglobally

    Let us know once the build issue is resolved. Android is the only outstanding item to close out this regression

  6. Julesssss commented on Nov 7, 2022

    @Julesssss
    Contributor

    Hi @mvtglobally, we're working on this and you should see an automated message here once it's deployed 🤞

  7. OSBotify commented on Nov 7, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.24-1 🚀

  8. mvtglobally commented on Nov 7, 2022

    @mvtglobally

    @Julesssss This new build did not push Android update. We still see 1.2.23-9

  9. mvtglobally commented on Nov 7, 2022

    @mvtglobally

    @Julesssss We just got the build, but its not working. App is crashing. Need a bug or you guys already aware?

    Screen_Recording_20221107-111743_Google.Play.Store.mp4
  10. Julesssss commented on Nov 7, 2022

    @Julesssss
    Contributor

    No, that wasn't reproducible during testing. Looking into this now 😕

  11. Julesssss commented on Nov 7, 2022

    @Julesssss
    Contributor

    Created an issue here, will keep you updated: #12522

  12. OSBotify commented on Nov 7, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.24-1 has been deployed to staging 🎉

  13. 9 remaining items

  14. yuwenmemon commented on Nov 7, 2022

    @yuwenmemon
    Contributor

    @mvtglobally We should be good to go now! Sorry for the delay

  15. mvtglobally commented on Nov 7, 2022

    @mvtglobally

    we are running regression. Should have results in a bit

  16. mvtglobally commented on Nov 8, 2022

    @mvtglobally

    @yuwenmemon @Julesssss Regression is completed

    PR #12034 is blocked on IOS and Android with #12480
    PR #12279 is blocked by #11796 on IOS and Android and blocked by #12308 on mWeb and Desktop
    PR #12296 is failing #12492. We were not able to repro on PROD, but it seems to be there as well. pls double check
    Checking 2 last CPs

  17. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    @mvtglobally can we test #12487 and check it off if it passes?

  18. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    Checking off #12296 because I was able to reproduce on prod and everything else from that PR works fine.

  19. mvtglobally commented on Nov 8, 2022

    @mvtglobally

    Asking team to re-test

  20. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    Checking off #12034 because it pertains to a non-mobile flow anyway - and #12480 is actively being worked on and also present on prod.

  21. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    @mvtglobally any update on how that testing went?

  22. mvtglobally commented on Nov 8, 2022

    @mvtglobally

    @yuwenmemon We are not able to repro on Web. Checking on other platforms

  23. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    Nice, I'm cautiously optimistic then 😄

  24. mvtglobally commented on Nov 8, 2022

    @mvtglobally

    @yuwenmemon issue is no longer repro across platforms

  25. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    Sweet! Can we close and check off that last issue?

  26. yuwenmemon commented on Nov 8, 2022

    @yuwenmemon
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions