You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for retest] Remove html from Close Account errors #12747
In the past, we didn't show errors that occurred when a user tries to close their account. Instead, we displayed a generic error modal. As of this issue: #11341, we're planning to get ride of that modal and show the error that occurred. Some of these error messages have <p> before / after the error message (example), which doesn't look good in NewDot
Solution
Let's make sure that Close Account error messages that are shown in NewDot look good!
Maybe this should be WAQ? Since these errors will now show directly in NewDot? cc @JmillsExpensify (also do you prefer being tagged like this or just having the issue directly added to WAQ project?)
I'm fined being tagged! It's good to keep track of these kinds of discussions. Also tagging @trjExpensify as we have alternating holiday time between now and the end of the year, and will be subbing in and out for each other.
In general, I think this is a good candidate for WAQ, because the refactors precede WAQ from a roadmap perspective, and that makes this an existing issue that should be fixed.
That said, I do wonder if it's better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.
That said, I do wonder if it's better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.
Fair, but I'm also potentially thinking that refactoring errors elsewhere is only "necessary" once those errors start showing up in the App. Similar to how we only did API refactors for commands that we use in the App. Know what I mean? Or is this way different since this issue is a much much smaller scope (just making sure HTML tags get stripped from error messages heading to NewDot) :D
Thinking a bit while typing, I actually think we could probably have a pretty simple generic solution that would do ^ (any errors sent to NewDot would have HTML tags stripped from the beginning & end)
I agree with that. One thing to add to this is that in the past we haven't been able to add server errors in-line on forms. @ctkochan22 has been working on an issue where we're making that happen, but if we're updating error messages let's make sure they are placed contextually in-line.
Ok great discussion. So we've got two thoughts here, I'm not clear what our path forward is.
Thinking a bit while typing, I actually think we could probably have a pretty simple generic solution that would do ^ (any errors sent to NewDot would have HTML tags stripped from the beginning & end)
I love this and think it's a pretty nice change given a lot of errors have HTML formatting, at least coming from OldDot.
One thing to add to this is that in the past we haven't been able to add server errors in-line on forms. @ctkochan22 has been working on an issue where we're making that happen, but if we're updating error messages let's make sure they are placed contextually in-line.
So are we saying that we should redo this entirely and bring the error in-line instead?
One thing to add to this is that in the past we haven't been able to add server errors in-line on forms.
Good to know, hadn't thought about that before.
So are we saying that we should redo this entirely and bring the error in-line instead?
Also a good question, the original purpose of this issue was to keep the form errors where they are, just remove the HTML tags from them (as luck would have it, Applause just created this issue (#13153) which has a video of Close Account errors with HTML tags).
@trjExpensify are you suggesting we move where the error shows or were you just pointing that out for context?
Oh nice, thanks for the heads up! I've added this GH issue to the list in the PR (which doesn't seem to be tied to an issue at the moment) and will re-test things once it goes out. Will add a HOLD for now 👍
Activity
Beamanator commentedon Nov 24, 2022
Maybe this should be WAQ? Since these errors will now show directly in NewDot? cc @JmillsExpensify (also do you prefer being tagged like this or just having the issue directly added to WAQ project?)
JmillsExpensify commentedon Nov 26, 2022
I'm fined being tagged! It's good to keep track of these kinds of discussions. Also tagging @trjExpensify as we have alternating holiday time between now and the end of the year, and will be subbing in and out for each other.
JmillsExpensify commentedon Nov 26, 2022
In general, I think this is a good candidate for WAQ, because the refactors precede WAQ from a roadmap perspective, and that makes this an existing issue that should be fixed.
JmillsExpensify commentedon Nov 26, 2022
That said, I do wonder if it's better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.
Beamanator commentedon Nov 28, 2022
Fair, but I'm also potentially thinking that refactoring errors elsewhere is only "necessary" once those errors start showing up in the App. Similar to how we only did API refactors for commands that we use in the App. Know what I mean? Or is this way different since this issue is a much much smaller scope (just making sure HTML tags get stripped from error messages heading to NewDot) :D
Thinking a bit while typing, I actually think we could probably have a pretty simple generic solution that would do ^ (any errors sent to NewDot would have HTML tags stripped from the beginning & end)
trjExpensify commentedon Nov 29, 2022
I agree with that. One thing to add to this is that in the past we haven't been able to add server errors in-line on forms. @ctkochan22 has been working on an issue where we're making that happen, but if we're updating error messages let's make sure they are placed contextually in-line.
JmillsExpensify commentedon Nov 29, 2022
Ok great discussion. So we've got two thoughts here, I'm not clear what our path forward is.
I love this and think it's a pretty nice change given a lot of errors have HTML formatting, at least coming from OldDot.
So are we saying that we should redo this entirely and bring the error in-line instead?
Beamanator commentedon Nov 30, 2022
Good to know, hadn't thought about that before.
Also a good question, the original purpose of this issue was to keep the form errors where they are, just remove the HTML tags from them (as luck would have it, Applause just created this issue (#13153) which has a video of Close Account errors with HTML tags).
@trjExpensify are you suggesting we move where the error shows or were you just pointing that out for context?
8 remaining items
Beamanator commentedon Dec 20, 2022
Unassigning myself to be able to put more focus on my other tasks - dropped a note in #engineering-chat to try to get more 👀
neil-marcellini commentedon Dec 29, 2022
Hey @robertjchen I wasn't aware of this issue until I saw it in your Slack WAQ status. I'm currently reviewing this PR which is solving this issue.
JmillsExpensify commentedon Dec 29, 2022
So should we put this issue on HOLD until your PR hits and then re-test? Or close this issue outright?
robertjchen commentedon Dec 30, 2022
Oh nice, thanks for the heads up! I've added this GH issue to the list in the PR (which doesn't seem to be tied to an issue at the moment) and will re-test things once it goes out. Will add a HOLD for now 👍
[-]Remove html from Close Account errors[/-][+][HOLD] Remove html from Close Account errors[/+][-][HOLD] Remove html from Close Account errors[/-][+][HOLD for retest] Remove html from Close Account errors[/+]robertjchen commentedon Jan 10, 2023
PR went out, going to re-test and close after confirmation.
robertjchen commentedon Jan 13, 2023
Looks great, closing!