Skip to content

[HOLD for retest] Remove html from Close Account errors #12747

Closed

Description

@Beamanator

Problem:

In the past, we didn't show errors that occurred when a user tries to close their account. Instead, we displayed a generic error modal. As of this issue: #11341, we're planning to get ride of that modal and show the error that occurred. Some of these error messages have <p> before / after the error message (example), which doesn't look good in NewDot

Solution

Let's make sure that Close Account error messages that are shown in NewDot look good!

Activity

  1. self-assigned this
    on Nov 15, 2022
  2. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 15, 2022
  3. Beamanator commented on Nov 24, 2022

    @Beamanator
    ContributorAuthor

    Maybe this should be WAQ? Since these errors will now show directly in NewDot? cc @JmillsExpensify (also do you prefer being tagged like this or just having the issue directly added to WAQ project?)

  4. JmillsExpensify commented on Nov 26, 2022

    @JmillsExpensify
    Contributor

    I'm fined being tagged! It's good to keep track of these kinds of discussions. Also tagging @trjExpensify as we have alternating holiday time between now and the end of the year, and will be subbing in and out for each other.

  5. JmillsExpensify commented on Nov 26, 2022

    @JmillsExpensify
    Contributor

    In general, I think this is a good candidate for WAQ, because the refactors precede WAQ from a roadmap perspective, and that makes this an existing issue that should be fixed.

  6. JmillsExpensify commented on Nov 26, 2022

    @JmillsExpensify
    Contributor

    That said, I do wonder if it's better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.

  7. Beamanator commented on Nov 28, 2022

    @Beamanator
    ContributorAuthor

    That said, I do wonder if it's better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.

    Fair, but I'm also potentially thinking that refactoring errors elsewhere is only "necessary" once those errors start showing up in the App. Similar to how we only did API refactors for commands that we use in the App. Know what I mean? Or is this way different since this issue is a much much smaller scope (just making sure HTML tags get stripped from error messages heading to NewDot) :D

    Thinking a bit while typing, I actually think we could probably have a pretty simple generic solution that would do ^ (any errors sent to NewDot would have HTML tags stripped from the beginning & end)

  8. trjExpensify commented on Nov 29, 2022

    @trjExpensify
    Contributor

    I agree with that. One thing to add to this is that in the past we haven't been able to add server errors in-line on forms. @ctkochan22 has been working on an issue where we're making that happen, but if we're updating error messages let's make sure they are placed contextually in-line.

  9. JmillsExpensify commented on Nov 29, 2022

    @JmillsExpensify
    Contributor

    Ok great discussion. So we've got two thoughts here, I'm not clear what our path forward is.

    Thinking a bit while typing, I actually think we could probably have a pretty simple generic solution that would do ^ (any errors sent to NewDot would have HTML tags stripped from the beginning & end)

    I love this and think it's a pretty nice change given a lot of errors have HTML formatting, at least coming from OldDot.

    One thing to add to this is that in the past we haven't been able to add server errors in-line on forms. @ctkochan22 has been working on an issue where we're making that happen, but if we're updating error messages let's make sure they are placed contextually in-line.

    So are we saying that we should redo this entirely and bring the error in-line instead?

  10. Beamanator commented on Nov 30, 2022

    @Beamanator
    ContributorAuthor

    One thing to add to this is that in the past we haven't been able to add server errors in-line on forms.

    Good to know, hadn't thought about that before.

    So are we saying that we should redo this entirely and bring the error in-line instead?

    Also a good question, the original purpose of this issue was to keep the form errors where they are, just remove the HTML tags from them (as luck would have it, Applause just created this issue (#13153) which has a video of Close Account errors with HTML tags).

    @trjExpensify are you suggesting we move where the error shows or were you just pointing that out for context?

  11. 8 remaining items

  12. removed their assignment
    on Dec 20, 2022
  13. Beamanator commented on Dec 20, 2022

    @Beamanator
    ContributorAuthor

    Unassigning myself to be able to put more focus on my other tasks - dropped a note in #engineering-chat to try to get more 👀

  14. self-assigned this
    on Dec 20, 2022
  15. neil-marcellini commented on Dec 29, 2022

    @neil-marcellini
    Contributor

    Hey @robertjchen I wasn't aware of this issue until I saw it in your Slack WAQ status. I'm currently reviewing this PR which is solving this issue.

  16. JmillsExpensify commented on Dec 29, 2022

    @JmillsExpensify
    Contributor

    So should we put this issue on HOLD until your PR hits and then re-test? Or close this issue outright?

  17. robertjchen commented on Dec 30, 2022

    @robertjchen
    Contributor

    Oh nice, thanks for the heads up! I've added this GH issue to the list in the PR (which doesn't seem to be tied to an issue at the moment) and will re-test things once it goes out. Will add a HOLD for now 👍

  18. changed the title [-]Remove html from Close Account errors[/-] [+][HOLD] Remove html from Close Account errors[/+] on Dec 30, 2022
  19. changed the title [-][HOLD] Remove html from Close Account errors[/-] [+][HOLD for retest] Remove html from Close Account errors[/+] on Dec 30, 2022
  20. robertjchen commented on Jan 10, 2023

    @robertjchen
    Contributor

    PR went out, going to re-test and close after confirmation.

  21. robertjchen commented on Jan 13, 2023

    @robertjchen
    Contributor

    Looks great, closing!

    Screenshot 2023-01-13 at 5 01 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions