Repository navigation
Deploy Checklist: New Expensify 2022-11-22 #12934
Description
Release Version: 1.2.30-0
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Support displaying backend errors in Form #11465
- Fix removal of deleted workspaces from the client #12129
- refactor navigation modal card styles #12366
- perf: reduce rerenders of sidebar #12369
- Refactor close account page to use Form #12534
- Standardize on using created instead of timestamp #12540
- Improve the readability and maintainability of the code which groups and sorts the reports in the sidebar #12558
- [No QA] Opt out of crashlytics with environment variable #12611
- Update expensify-common dependency #12720
- [No QA] Remove unnecessary clientID from ReportActionsList keyExtractor #12727
- added isChronosReport prop to prevent edit and delete action for Chro… #12732
- [No QA] Add console logs to investigate where the Reviewer Checklist check is failing #12771
- Fix for: Triple clicking a DM that contains text and URL, the URL isn’t highlighted #12802
- [No QA]Add iOS encrypted ad hoc provisioning profile #12803
- Invert list manually on android #12820
- Fix: Add payment method blink after interacting with buttons #12824
- [CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829
- [No QA]Add Browserstack API call to staging deploys #12830
- [No QA]Fix tests by adding
@react-native-firebase/crashlyticsjest mock #12831 - [No QA] Add checklist item regarding changing function arguments #12846
- [No QA]Attempt to fix iOS uploads to browserstack with different path #12855
- Fix: VBA -URL is shown on bottom left corner when Fix the error is hovered #12858
- keeps highlighted the preferred skinton emoji #12860
- only dismiss the modal when user transitions from old dot #12862
- Remove scrolling to bottom when opening the keyboard #12868
- Don't display Make default payment method for business bank accounts #12869
- [No QA] Update announceFailedWorkflowInSlack to link to a specific workflow run #12873
- update ios/Podfile.lock for PR:12765 #12876
- Skelton-View-Lines-Overflow-Fix-Native #12877
- Remove deprecated function SetupWithdrawalAccount #12879
- [NoQA] dummy change to be reverted so workflows run without approval #12882
- [NoQA] Add the year to the test as it is longer in past than last week #12884
- Display correct names for rooms #12886
- Revert "removed resetting the report fields to allow user to operate multiple actions on same popover" #12897
- [No QA] Add old danger red back to old theme for continuity #12898
- Update CP Staging warning #12912
- fix propTypes warning on SidebarLinks #12924
Deploy Blockers:
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Nov 22, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.30-0 🚀
mvtglobally commentedon Nov 22, 2022
@AndrewGable Did IOS build go through? we still dont see it updated
AndrewGable commentedon Nov 22, 2022
Can you double check now?
mvtglobally commentedon Nov 22, 2022
@AndrewGable got it now. Thanks!
mvtglobally commentedon Nov 23, 2022
Regression is almost completed
mid-Summary
PR #11465 is failing #12942 & #12966. repro in PROD
PR #12129 is failing #12955. repro in PROD
PR #12802 (comment)
PR #12858 is failing on Native aps #12942. repro in PROD
PR #12877 is failing #12946. repro in PROD
PR #12924 is failing #12920
PR #12868 (comment) clarification
luacmartins commentedon Nov 23, 2022
Checking off #12877 since it passed and #12946 is the expected behavior.
mvtglobally commentedon Nov 23, 2022
Regression is completed.
Outstanding/additional items
PR #12540 is failing #12967. repro in prod, checking off
PR checking off #12802 (comment)
PR #12924 is failing #12920. ok to check off?
luacmartins commentedon Nov 23, 2022
reportActionsseems to be fixed. The issue forrolewill be addressed separately.luacmartins commentedon Nov 23, 2022
I see a new crash on iOS. I did some digging and it seems like it's a memory management/corruption issue either with the App or the OS itself. Given that it only happened a single time on iOS 16 running on an older phone (iPhone XR) with little free RAM available, I'm gonna call this an OS issue and move forward with the deploy.
luacmartins commentedon Nov 23, 2022