Skip to content

[HOLD #11768] [$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency #13449

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Actions Performed:

  1. Go to any chat
  2. Go To Split Bill
  3. Change Currency

Expected Result:

Keyboard dismissed

Actual Result:

Keyboard Appears For A brief Second.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.2.37-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Record_2022-12-08-05-56-42.mp4
az_recorder_20221208_181448.mp4

Expensify/Expensify Issue URL:
Issue reported by: @syedsaroshfarrukhdot
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670461227037229

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170d39fa04a453e03
  • Upwork Job ID: 1601056856164556800

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 8, 2022
  2. melvin-bot commented on Dec 8, 2022

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. syedsaroshfarrukhdot commented on Dec 8, 2022

    @syedsaroshfarrukhdot
    Contributor

    Proposal:-

    In IOUCurrencySelection.js we need to pass Keyboard.dismiss(); in confirmCurrencySelection function.

    diff --git a/src/pages/iou/IOUCurrencySelection.js b/src/pages/iou/IOUCurrencySelection.js
    index b7affe898..6525a205f 100644
    --- a/src/pages/iou/IOUCurrencySelection.js
    +++ b/src/pages/iou/IOUCurrencySelection.js
    @@ -1,4 +1,5 @@
     import React, {Component} from 'react';
    +import { Keyboard } from 'react-native';
     import PropTypes from 'prop-types';
     import {withOnyx} from 'react-native-onyx';
     import _ from 'underscore';
    @@ -105,6 +106,7 @@ class IOUCurrencySelection extends Component {
          */
         confirmCurrencySelection(option) {
             IOU.setIOUSelectedCurrency(option.currencyCode);
    +        Keyboard.dismiss();
             Navigation.goBack();
         }
     

    After Fix:-

    Screen.Recording.2022-12-08.at.6.19.56.AM.mov
  4. JmillsExpensify commented on Dec 9, 2022

    @JmillsExpensify
    Contributor

    Ok, I can reproduce this.

    Screen.Recording.2022-12-08.at.21.29.28.mov
  5. JmillsExpensify commented on Dec 9, 2022

    @JmillsExpensify
    Contributor

    Here's my take: This is a pretty cosmetic bug in my opinion, as it doesn't really affect the user experience and the keyboard does dismiss automatically. So I think the value of fixing this big is pretty low.

    That said, if we can find a simple solution for this then it'll be worth it. Let's open this up for proposals and see where we get.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 9, 2022
  7. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

  8. changed the title [-]Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/-] [+][$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/+] on Dec 9, 2022
  9. melvin-bot commented on Dec 9, 2022

    @melvin-bot
  10. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 9, 2022
  12. 32 remaining items

  13. syedsaroshfarrukhdot commented on Mar 21, 2023

    @syedsaroshfarrukhdot
    Contributor

    @techievivek Just a thought if we end up fixing the issue in #15085 will i be eligible for reporting bonus ? As i reported this issue initially issue #15085 is a dupe of this issue ?

  14. MelvinBot commented on Mar 21, 2023

    @MelvinBot
    Contributor

    📣 @syedsaroshfarrukhdot! 📣

    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

    Screen Shot 2022-11-16 at 4 42 54 PM

    Format:

    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  15. syedsaroshfarrukhdot commented on Mar 21, 2023

    @syedsaroshfarrukhdot
    Contributor

    Contributor details
    Your Expensify account email: syedsaroshfarrukh@gmail.com
    Upwork Profile Link: upwork.com/freelancers/~01438157cc0d3d99e2

  16. MelvinBot commented on Mar 21, 2023

    @MelvinBot
    Contributor

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  17. mallenexpensify commented on Mar 21, 2023

    @mallenexpensify
    Contributor

    @syedsaroshfarrukhdot it appears this bug, which you reported, precedes the two you linked so you would be eligible for the bonus.

  18. syedsaroshfarrukhdot commented on Mar 21, 2023

    @syedsaroshfarrukhdot
    Contributor

    @syedsaroshfarrukhdot it appears this bug, which you reported, precedes the two you linked so you would be eligible for the bonus.

    Thank you. Will apply on the job when time comes. 😃

  19. syedsaroshfarrukhdot commented on Mar 25, 2023

    @syedsaroshfarrukhdot
    Contributor

    @mallenexpensify as it seems issue was resolved in #15085 and it have been closed. Shouldn't we close this issue as well ?

  20. JmillsExpensify commented on Mar 27, 2023

    @JmillsExpensify
    Contributor

    I'm not longer able to reproduce this issue, so I'm going to comment in the linked issue and clear up the reporting bonus.

  21. syedsaroshfarrukhdot commented on Mar 31, 2023

    @syedsaroshfarrukhdot
    Contributor

    @JmillsExpensify I think we can close this issue now as according to this comment everyone agrees this issue is no longer reproducible and fixed.

  22. syedsaroshfarrukhdot commented on Apr 4, 2023

    @syedsaroshfarrukhdot
    Contributor

    @JmillsExpensify bumping it for closing and reporting bonus payment.

  23. mallenexpensify commented on Apr 5, 2023

    @mallenexpensify
    Contributor

    @syedsaroshfarrukhdot can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01d87b154a08dd83c6

  24. syedsaroshfarrukhdot commented on Apr 5, 2023

    @syedsaroshfarrukhdot
    Contributor

    @mallenexpensify Accepted on Upwork

  25. mallenexpensify commented on Apr 6, 2023

    @mallenexpensify
    Contributor

    Paid, sorry it took a minute @syedsaroshfarrukhdot , thanks for the bumps. Think this can be closed now, reopen if neded.

  26. JmillsExpensify commented on Apr 18, 2023

    @JmillsExpensify
    Contributor

    Thanks for closing the loop at on this one @mallenexpensify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions