You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD #11768] [$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency #13449
Version Number: 1.2.37-2 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Here's my take: This is a pretty cosmetic bug in my opinion, as it doesn't really affect the user experience and the keyboard does dismiss automatically. So I think the value of fixing this big is pretty low.
That said, if we can find a simple solution for this then it'll be worth it. Let's open this up for proposals and see where we get.
changed the title [-]Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/-][+][$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/+]on Dec 9, 2022
@techievivek Just a thought if we end up fixing the issue in #15085 will i be eligible for reporting bonus ? As i reported this issue initially issue #15085 is a dupe of this issue ?
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
melvin-bot commentedon Dec 8, 2022
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.syedsaroshfarrukhdot commentedon Dec 8, 2022
Proposal:-
In IOUCurrencySelection.js we need to pass Keyboard.dismiss(); in confirmCurrencySelection function.
After Fix:-
Screen.Recording.2022-12-08.at.6.19.56.AM.mov
JmillsExpensify commentedon Dec 9, 2022
Ok, I can reproduce this.
Screen.Recording.2022-12-08.at.21.29.28.mov
JmillsExpensify commentedon Dec 9, 2022
Here's my take: This is a pretty cosmetic bug in my opinion, as it doesn't really affect the user experience and the keyboard does dismiss automatically. So I think the value of fixing this big is pretty low.
That said, if we can find a simple solution for this then it'll be worth it. Let's open this up for proposals and see where we get.
melvin-bot commentedon Dec 9, 2022
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.
[-]Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/-][+][$1000] Android - Split Bill - Keyboard is not dismissed for a brief moment after changing currency[/+]melvin-bot commentedon Dec 9, 2022
Job added to Upwork: https://www.upwork.com/jobs/~0170d39fa04a453e03
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)32 remaining items
syedsaroshfarrukhdot commentedon Mar 21, 2023
@techievivek Just a thought if we end up fixing the issue in #15085 will i be eligible for reporting bonus ? As i reported this issue initially issue #15085 is a dupe of this issue ?
MelvinBot commentedon Mar 21, 2023
📣 @syedsaroshfarrukhdot! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
syedsaroshfarrukhdot commentedon Mar 21, 2023
Contributor details
Your Expensify account email: syedsaroshfarrukh@gmail.com
Upwork Profile Link: upwork.com/freelancers/~01438157cc0d3d99e2
MelvinBot commentedon Mar 21, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
mallenexpensify commentedon Mar 21, 2023
@syedsaroshfarrukhdot it appears this bug, which you reported, precedes the two you linked so you would be eligible for the bonus.
syedsaroshfarrukhdot commentedon Mar 21, 2023
Thank you. Will apply on the job when time comes. 😃
syedsaroshfarrukhdot commentedon Mar 25, 2023
@mallenexpensify as it seems issue was resolved in #15085 and it have been closed. Shouldn't we close this issue as well ?
JmillsExpensify commentedon Mar 27, 2023
I'm not longer able to reproduce this issue, so I'm going to comment in the linked issue and clear up the reporting bonus.
syedsaroshfarrukhdot commentedon Mar 31, 2023
@JmillsExpensify I think we can close this issue now as according to this comment everyone agrees this issue is no longer reproducible and fixed.
syedsaroshfarrukhdot commentedon Apr 4, 2023
@JmillsExpensify bumping it for closing and reporting bonus payment.
mallenexpensify commentedon Apr 5, 2023
@syedsaroshfarrukhdot can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d87b154a08dd83c6
syedsaroshfarrukhdot commentedon Apr 5, 2023
@mallenexpensify Accepted on Upwork
mallenexpensify commentedon Apr 6, 2023
Paid, sorry it took a minute @syedsaroshfarrukhdot , thanks for the bumps. Think this can be closed now, reopen if neded.
JmillsExpensify commentedon Apr 18, 2023
Thanks for closing the loop at on this one @mallenexpensify!