You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-09] Keyboard is visible for a brief moment on request/send money page after getting back from currency search page #15085
On currency search page, when keyboard is displayed for search, click on 'X' to close and get back to previous page
Expected Result:
Keyboard should close first and then app should get back to previous request/send money screen
Actual Result:
App navigates to request/send money screen first and then closes the keyboard (works properly on mWeb android chrome)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Version Number: 1.2.70-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
We can solve issue in 2 ways - globally and locally.
For global one - we can add subscription to event beforeremove inside ScreenWrapper class and add in compose withKeyboardState HOC - which will guaranty that keyboard will be closed on any screen which was wrapped in ScreenWrapper
For local one - doing the same steps - but only under IOUCurrencySelection class
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
We are trying to avoid making changes related to react-navigation now as we are reworking this. I think we could try this solution locally @narefyev91 and confirm it works well there on all the native platforms.
Can you please create a PR and fill in the template with testing done on all the platforms? Thank you very much!
I believe i reported a similar issue a few months ago and we ended up resolving a dupe issue while original issue was on hold #13449. So i think i am also eligible for reporting bonus here.
Jumping in here. Doesn't the fix for this issue also fix #13449? In fact, I've tested that issue and I'm no longer able to reproduce it, so I'm pretty certain the answer is yes.
Assuming we all agree on that last comment, then I agree that @syedsaroshfarrukhdot should be eligible for a reporting bonus and we should close the related issue. I'm happy to do it there, though let's first ensure that we agree on the next steps in this issue before I move forward.
Activity
MelvinBot commentedon Feb 13, 2023
Triggered auto assignment to @mateocole (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Feb 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)narefyev91 commentedon Feb 14, 2023
Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.
narefyev91 commentedon Feb 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App doesn't automatically hide keyboard on android - while moving between screens.
What is the root cause of that problem?
The main issue - when user goes back - no events fires to app to dismiss keyboard (if keyboard has been already opened)
What changes do you think we should make in order to solve the problem?
The main change should be:
Example:
What alternative solutions did you explore?
We can solve issue in 2 ways - globally and locally.
For global one - we can add subscription to event
beforeremoveinsideScreenWrapperclass and add in composewithKeyboardStateHOC - which will guaranty that keyboard will be closed on any screen which was wrapped inScreenWrapperFor local one - doing the same steps - but only under
IOUCurrencySelectionclassMelvinBot commentedon Feb 15, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
mountiny commentedon Feb 15, 2023
We are trying to avoid making changes related to react-navigation now as we are reworking this. I think we could try this solution locally @narefyev91 and confirm it works well there on all the native platforms.
Can you please create a PR and fill in the template with testing done on all the platforms? Thank you very much!
14 remaining items
mateocole commentedon Mar 10, 2023
Okay, here is an upwork post for everyone to apply to for payment:
https://www.upwork.com/jobs/~01115b5c443336b31a
mountiny commentedon Mar 10, 2023
This is only going to be:
@narefyev91 is handled differently
dhanashree-sawant commentedon Mar 10, 2023
Hi @mountiny, thanks I have applied to the upwork job.
mateocole commentedon Mar 10, 2023
Okay contracts sent!
mateocole commentedon Mar 10, 2023
Alright payments sent
syedsaroshfarrukhdot commentedon Mar 21, 2023
I believe i reported a similar issue a few months ago and we ended up resolving a dupe issue while original issue was on hold #13449. So i think i am also eligible for reporting bonus here.
mountiny commentedon Mar 21, 2023
Ltts keep it in that issue, even on hold I the reporting bonus should be paid I believe once we will put it off hold
JmillsExpensify commentedon Mar 27, 2023
Jumping in here. Doesn't the fix for this issue also fix #13449? In fact, I've tested that issue and I'm no longer able to reproduce it, so I'm pretty certain the answer is yes.
JmillsExpensify commentedon Mar 27, 2023
Assuming we all agree on that last comment, then I agree that @syedsaroshfarrukhdot should be eligible for a reporting bonus and we should close the related issue. I'm happy to do it there, though let's first ensure that we agree on the next steps in this issue before I move forward.
mountiny commentedon Mar 27, 2023
Checking, seems like this is the case. I think we can close and pay @syedsaroshfarrukhdot