Skip to content

[PAY] Image infinite loading when offline #13826

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Turn on the Airplane mode, open the app
  2. Open any report that has image, click on image.
  3. Notice that the image is infinite loading.

Expected Result:

Image should show error or placeholder error.

Actual Result:

The image is infinite loading.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • iOS / native

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1671850663.MP4
CYVJ9736.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671962332211369

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 26, 2022
  2. locked and limited conversation to collaborators on Dec 26, 2022
  3. mallenexpensify commented on Dec 27, 2022

    @mallenexpensify
    Contributor

    Unable to reproduce on iOS v1.2.42-2.

    • Opened app
    • Uploaded photo with internet - worked fine
    • Went to airplane mode
    • Uploaded photo - showed "Uploading attachment" in main chat
    • Once connected back to internet, photo loaded once I went back into the chat.

    Tried to test on Android via Browserstack but was getting an endless spinner when trying to sign in.

    Anything I might be missing? @kavimuru can you please test again? Thanks

  4. MonilBhavsar commented on Dec 28, 2022

    @MonilBhavsar
    Contributor

    I'm able to reproduce.

    @mallenexpensify the internet needs to be turned off and then tap on image attachment

  5. MonilBhavsar commented on Dec 28, 2022

    @MonilBhavsar
    Contributor

    On web also, there is no loader. But yeah we should stop showing infinite loader as the request already failed and display some message/icon

  6. mallenexpensify commented on Dec 28, 2022

    @mallenexpensify
    Contributor

    Thanks @MonilBhavsar . I was able to reproduce today (maybe I wasn't on the latest version ¯_(ツ)_/¯ )
    I'm unsure if this can be external so adding in an engineer....

  7. changed the title [-]Image infinite loading when offline[/-] [+][HOLD App 10894 Caching] Image infinite loading when offline[/+] on Jan 3, 2023
  8. neil-marcellini commented on Jan 3, 2023

    @neil-marcellini
    Contributor

    We decided to hold this until the Onyx image caching is working as described in the tracking issue here #10894.

  9. 88 remaining items

  10. mallenexpensify commented on May 24, 2024

    @mallenexpensify
    Contributor

    PR hit production two days ago 🎉

    Unable to reproduce now, on Staging iOS. @neil-marcellini , should we not close this for some reason?

    2024-05-24_14-27-06.mp4
  11. hungvu193 commented on May 25, 2024

    @hungvu193
    Contributor

    I think I'm eligible for reporting bonus for this one 😂. One of the first issue I reported here

  12. mallenexpensify commented on May 28, 2024

    @mallenexpensify
    Contributor

    Wow... looks like you might be. Help me track @hungvu193 to make sure I have this right

    Sound right?

  13. hungvu193 commented on May 28, 2024

    @hungvu193
    Contributor

    @mallenexpensify Yes. That's correct

  14. changed the title [-][HOLD #35502 Caching] Image infinite loading when offline[/-] [+][PAY] Image infinite loading when offline[/+] on May 29, 2024
  15. mallenexpensify commented on May 29, 2024

    @mallenexpensify
    Contributor

    Ok... Since the report was from 2022, I'm going to assume it was $250.

    @hungvu193 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01c9e76cecfe58dcad

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 29, 2024
  17. hungvu193 commented on May 29, 2024

    @hungvu193
    Contributor

    Sure. I've accepted. Thank you 😊

  18. mallenexpensify commented on May 29, 2024

    @mallenexpensify
    Contributor

    Bug Reporter: @hungvu193 paid $250 via Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringNeeds ReproductionReproducible steps neededWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions