Skip to content

[Tracking][Image][Polish] Image-related feature request and improvements #10894

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

We have seen a number of issues come up related to images. Uploading them, editing them, making them available offline, copying them to clipboard, etc...

Onyx does have support for images, but AFAIK nobody has utilized that functionality to build any app features that follow our offline-first paradigm for images.

Overall, I think there's a lot of confusion around this topic (speaking for myself here, so feel free to comment if you disagree), and that leads to potentially disparate approaches or complex code surrounding images.

Solution

As these come up, we see the need for a common, unified approach to handling images, presumably using Onyx. This issue is meant to serve as a tracking issue for all image-related feature requests and bug fixes. We should look for commonality between these features, try to come up with a generalized, future-proof solution that's easy to work with, and implement it via the WN/Design Doc process.

Linked issues

Setting up Caching Issue(s)

Bugs based off caching [Holding on ^]

"Flashing" / Image rerendering [Holding on ^]

New Features

Bugs (in progress - not on hold)

Resolved issues

Follow-up discussions:

Activity

  1. parasharrajat commented on Sep 8, 2022

    @parasharrajat
    Member

    Thanks for putting this up, much needed discussion.

  2. melvin-bot commented on Sep 12, 2022

    @melvin-bot
  3. parasharrajat commented on Sep 13, 2022

    @parasharrajat
    Member

    Should we create a Project for this one? For me, it's a big feature/migration.

  4. roryabraham commented on Sep 21, 2022

    @roryabraham
    ContributorAuthor

    A project would be fine – historically we've usually just used issues but a project board could be useful. More importantly, we need someone to take this on as a project manager.

    One interesting idea could be to engage @thomas-coldwell from Margelo in this project, since @mrousavy told me that Thomas typically works on Video/Audio/Image/Graphics stuff. Thoughts @mrousavy? Right now this is a pretty open-ended issue.

  5. mrousavy commented on Sep 23, 2022

    @mrousavy
    Member

    @roryabraham yes, this would probably pretty interesting! 😄

    I'll talk to Thomas about availability then get back to you here or on Slack :)

  6. changed the title [-][Tracking] Image-related feature request and improvements[/-] [+][Tracking] [Bug] Image-related feature request and improvements[/+] on Sep 27, 2022
  7. melvin-bot commented on Sep 29, 2022

    @melvin-bot
  8. melvin-bot commented on Sep 29, 2022

    @melvin-bot
  9. roryabraham commented on Sep 30, 2022

    @roryabraham
    ContributorAuthor

    Added #9703 to this list.

  10. 276 remaining items

  11. trjExpensify commented on Mar 11, 2024

    @trjExpensify
    Contributor

    #36560 in the works!

  12. trjExpensify commented on Mar 20, 2024

    @trjExpensify
    Contributor

    We merged it very recently. Looking good so far, no revert. So hopefully we can turn to #9402 soon.

  13. changed the title [-][HOLD #12603] [Tracking][Image][Polish] Image-related feature request and improvements[/-] [+][Tracking][Image][Polish] Image-related feature request and improvements[/+] on Mar 28, 2024
  14. mallenexpensify commented on Mar 28, 2024

    @mallenexpensify
    Contributor

    Updated title to remove the hold cuz the issue it was held on hit production
    #12603
    (I have another issue that's held on this one)

  15. trjExpensify commented on Apr 2, 2024

    @trjExpensify
    Contributor

    What issue is it, @mallenexpensify?

  16. mallenexpensify commented on Apr 3, 2024

    @mallenexpensify
    Contributor
  17. trjExpensify commented on Apr 12, 2024

    @trjExpensify
    Contributor

    Interesting! I don't think that needs to hold on this issue, it looks like it's being addressed here: #35502

    I'm going to go ahead and close this out now. We aren't adding anything new to it or require it for CAP or anything. The two remaining items we have are here and here, so follow along there if anyone is still interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions