Repository navigation
[HOLD #10894][Image][Performance][$2000] Feature Request - Attachments should be cached after first load. It currently load from internet every time - Reported by: @parasharrajat #6527
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Send a attachment to a conversation
Expected Result:
Attachments should be saved on disk for a faster load of the app.
Actual Result:
Attachments should be saved to disk after first load. It currently load from internet every time.
Workaround:
N/A
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.16-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638120119026500
Activity
MelvinBot commentedon Nov 30, 2021
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Nov 30, 2021
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.tylerkaraszewski commentedon Nov 30, 2021
I think this would be a great feature for people on slow or metered connections. I think it's fairly complex though, as it requires some sort of cache eviction mechanism. We may already have enough of everything we need to do this with Onyx, so it might not be that much work, but it needs to be considered.
I'm happy to stick the external label on it and see what proposals we get.
MelvinBot commentedon Nov 30, 2021
Triggered auto assignment to @michaelhaxhiu (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.112 remaining items
melvin-bot commentedon Oct 4, 2022
[-][HOLD on #10894][Performance] [$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/-][+][HOLD #10894] [Performance] [$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/+]mallenexpensify commentedon Oct 22, 2022
Snaggin' from you lil Kev cuz I got the tracking issue assigned to me
[Tracking] [Polish] Image-related feature request and improvements #10894
[-][HOLD #10894] [Performance] [$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/-][+][HOLD #10894][Image][Performance] [$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/+][-][HOLD #10894][Image][Performance] [$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/-][+][HOLD #10894][Image][Performance][$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/+][-][HOLD #10894][Image][Performance][$2000] Feature Request - Attachments should be saved to disk after first load. It currently load from internet every time - Reported by: @parasharrajat[/-][+][HOLD #10894][Image][Performance][$2000] Feature Request - Attachments should be cached after first load. It currently load from internet every time - Reported by: @parasharrajat[/+]trjExpensify commentedon Nov 14, 2022
👋 @Beamanator just checking that we need this issue in addition to this one, that has a PR in review already to address?
Beamanator commentedon Nov 14, 2022
Good point @trjExpensify - this looks a bit like a duplicate / the fix for that issue (& this one) should also fix this one.
trjExpensify commentedon Nov 14, 2022
Okay, cool. So there's no point us having this hang out. I'm going to close it, and then @parasharrajat I've sent you the reporting offer on the Upwork job linked to this one.