Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.2.67-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Open on admin room #11565
- [N7 Account Settings] Create personal details pages #14290
- Update permission alerts for consistency #14546
- Fix deep link for chat reports #14669
- Add not found page to report RHN workspace detail pages #14744
- Count non-ASCII comment characters by their encoded length #14752
- [Snyk] Security upgrade electron from 21.4.0 to 21.4.1 #14760
- [No QA] Add proposal template for contributors #14817
- fix/14784: Settings - Changed name is not saved under Display name page #14866
- Updated RNW version to 0.18.12 #14870
- [NO QA] explanation for changes in #14728 #14895
- Use Numpad keyboard type for the magic code #14901
- change maxInputLength default value to undefined from -1 #14921
- [CP Staging] Get route.params.openOnAdminRoom if exists #14955
Internal QA:
Deploy Blockers:
- [HOLD for payment 2023-02-13] [HOLD for payment 2023-02-10] [$1000] Profile : Infinite loading spinner appears choosing images with file names has space or special character #14757
- App crash on entering test amount on Test transaction page #14847
- Billing Address field in AddDebitCardPage doesn't accept text #14918
- [HOLD for payment 2023-02-17] [HOLD for payment 2023-02-15] Log In- Secondary login Logged out of NewDot is show message error #14948
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Feb 7, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.67-5🚀OSBotify commentedon Feb 7, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.67-5 has been deployed to staging 🎉
OSBotify commentedon Feb 8, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.67-6 🚀
roryabraham commentedon Feb 8, 2023
Checked off #12983
mvtglobally commentedon Feb 8, 2023
@mountiny Regression is completed
We are checking few CPs
#14669 is blocked on IOS #13882 (comment) and failing on mWeb with #14937 (repro in prod)
#11565 is failing #14929
#14290 is failing on Native aps #14949. this is not repro in PROD, but we didnt add a blocker label as the feature introduced by PR. Pls double check this one
mountiny commentedon Feb 8, 2023
Thank you @mvtglobally
I think:
Is alright, if you add valid date it works correctly and its just one platform, the original PR has been a big change so we are fine to proceed I think
this also seems fine to me
We might want to revert that PR
OSBotify commentedon Feb 8, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.67-7🚀mountiny commentedon Feb 8, 2023
Checking #11565 off because of https://expensify.slack.com/archives/C01GTK53T8Q/p1675888975277209?thread_ts=1675879238.058249&cid=C01GTK53T8Q
mountiny commentedon Feb 8, 2023
Graphs and crashes seem fine, waiting for last CP verification
mvtglobally commentedon Feb 8, 2023
#14955 looks good
OSBotify commentedon Feb 8, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.67-7 has been deployed to staging 🎉
mountiny commentedon Feb 8, 2023
Thank you, deploying!
mountiny commentedon Feb 8, 2023