[HOLD for payment 2023-06-30] [$250] Migrate PronounsPage.js to function component

Class Component Migration

Filenames

src/pages/settings/Profile/PronounsPage.js
- type: React.Component
- has state values: true
- has refs: false
- has context: false
- lifecycle methods: componentDidUpdate

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010517ed943d1f3420
Upwork Job ID: 1665691072385675264
Last Price Increase: 2023-06-05

@mountiny

@mountiny taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

Take it to #expensify-open-source to get clarification on.
Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

Thanks, making this weekly as I am currrently working on Roadmap issue.

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

havent priritized this with manual requests and app deploy

@laurenreidexpensify

Hi @laurenreidexpensify & @mountiny, I asked this question in #20095 & had a chat with @Christinadobrzyn (the bug-zero member in that issue) & was told to ask that question here.

So I am just asking that if there are two issues & someone fixes them both within one PR shouldn't they get paid for the one that has the higher compensation if not for both?

@priyeshshah11

@priyeshshah11 how much did you get paid in both issues?
Maybe $250 here and another $250 in #20095?

There was a recent compensation discussion about one PR fixing multiple issues.
And we landed:

if same root cause, no more compensation
if different root cause, sum up issue prices

Example GH: #15757 + #15229, contributor got paid 8k total

@aimane-chnaif

@aimane-chnaif I only got paid $250 for this one & nothing for the other one. I think root cause does not really apply in this case as one was a bug & the other one was just a dev task.

@priyeshshah11

Oh sorry, maybe I shouldn't have reopened this GH just trying to bring attention to @priyeshshah11 comments ^. I can help with questions about #20095 - @priyeshshah11 was not compensated in that GH because I only paid the reporter on the GH.

I suggested @priyeshshah11 bring the compensation into this GH since this is where the fix happened.

I'll close the issue - sorry I don't think it needs to be open to discuss payment

@priyeshshah11

@priyeshshah11 sorry for this, it would be helpful to write it down here.

what PR you have written
which issues did it solve
how much you got paid?

That will help us quickly take a loook if we should add more compensation, thanks!

@priyeshshah11

@priyeshshah11 sorry for this, it would be helpful to write it down here.

what PR you have written

which issues did it solve

how much you got paid?

That will help us quickly take a loook if we should add more compensation, thanks!

@mountiny yeah sure

I created this PR Migrated PronounsPage to functional component #20178
It solved [HOLD for payment 2023-06-30] [$250] Migrate PronounsPage.js to function component #16296 & fixed [HOLD for #16296][$1000] pronouns search breaks when we reload on pronouns search page #20095
I only got paid $250 for [HOLD for payment 2023-06-30] [$250] Migrate PronounsPage.js to function component #16296

Thanks reopened the other issue

Curious if it's applicable to C+ as well 🙂

Yes, feel free to comment there

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-30] [$250] Migrate PronounsPage.js to function component #16296

Class Component Migration

Filenames

Task

83 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-30] [$250] Migrate PronounsPage.js to function component #16296

Description

Class Component Migration

Filenames

Task

Activity

marcaaron commented on Apr 5, 2023

mountiny commented on Apr 5, 2023

MelvinBot commented on Apr 13, 2023

marcaaron commented on Apr 13, 2023

mountiny commented on Apr 17, 2023

83 remaining items

priyeshshah11 commented on Jul 7, 2023

aimane-chnaif commented on Jul 7, 2023

priyeshshah11 commented on Jul 7, 2023

Christinadobrzyn commented on Jul 7, 2023

Christinadobrzyn commented on Jul 7, 2023

mountiny commented on Jul 7, 2023

priyeshshah11 commented on Jul 8, 2023

mountiny commented on Jul 8, 2023

aimane-chnaif commented on Jul 8, 2023

mountiny commented on Jul 8, 2023

melvin-bot commented on Aug 28, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions