Repository navigation
[HOLD for @0xmiroslav payment] Make Profile > Personal Details > Address true push-to-page fields. #17548
Description
@Beamanator @cristipaval I was in a thread with @shawnborton and he noticed that both our State and Country fields are not true push-to-page inputs. Mind helping us understand why that's the case? Ideally if we're going to allow selection of a list, we'd follow a true push-to-page pattern where the row/input has a right caret, upon which tapping that takes you to the full list on a separate page. Right? Adding a New Feature label on this one given that it's not technically a bug.
In addition to the above, let's make sure we have 20px below each input grouping (could be just an input, or input + hint text), as @shawnborton asked here.
Activity
MelvinBot commentedon Apr 17, 2023
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.
JmillsExpensify commentedon Apr 17, 2023
Went ahead and assigned myself so no one is assigned and we align on next steps.
cristipaval commentedon Apr 18, 2023
I think we refactored the parent Profile page but we missed this page.
It looks like there was an issue created for this but there was confusion here and the issue was closed. cc @Beamanator
JmillsExpensify commentedon Apr 18, 2023
Ok no worries. We can just use this issue to close the loop. Sound good?
cristipaval commentedon Apr 18, 2023
Sounds good to me. I can take this one and offload it to Callstack, as it is just front-end work.
Prince-Mendiratta commentedon Apr 18, 2023
Hi @JmillsExpensify @cristipaval! I'd like to work on this, would it be possible to make this issue external or will you be going ahead with Callstack?
gedu commentedon Apr 20, 2023
Hey hey, Edu here, I am from Callstack - expert contributor group, I can take a look at this one
cristipaval commentedon Apr 20, 2023
Hey @gedu! Thanks for taking this over! Push-to-page design means that the user should be redirected to a new page to select the option, instead of the system picker. Take a look at how pronouns and Timezone selectors work in the Profile page.
gedu commentedon Apr 20, 2023
@cristipaval I'm not seeing that
Statehas a dropdown where is that or how can I reproduce it? (I'm up to date with main)cristipaval commentedon Apr 20, 2023
You first have to select the country, which I think isn't intuitive and also is not user-friendly to go down to the latest field, select an option, and then go back up to the State field to select an option. @JmillsExpensify @shawnborton What do you think? Shouldn't we reorder the fields to have Country before State, since the State options depend on the Country selection?
68 remaining items
melvin-bot commentedon Aug 29, 2023
@JmillsExpensify, @gedu, @mountiny, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...
JmillsExpensify commentedon Aug 30, 2023
Offer extended to @s77rt. @0xmiroslav I think there's still some uncertainty how you're being paid out. Please let me know how you'd like to proceed.
JmillsExpensify commentedon Aug 30, 2023
@s77rt paid for this job. Going to add a hold for @0xmiroslav.
[-][HOLD for payment 2023-08-03] Make Profile > Personal Details > Address true push-to-page fields. [/-][+][HOLD for @0xmiroslav payment] Make Profile > Personal Details > Address true push-to-page fields. [/+]mountiny commentedon Sep 4, 2023
making it monthly for the payment to miroslav
JmillsExpensify commentedon Sep 25, 2023
@0xmiroslav Can we issue payment on this one yet?
0xmiroslav commentedon Sep 26, 2023
Not yet
JmillsExpensify commentedon Oct 10, 2023
I'm going to close this because I have an unsustainable amount of GH issue assigned. Please keep track on this one your side and let us know when you are ready to receive payment. Thanks!