Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to settings -> Profile
- Personal details -> Home address
Expected Result:
Margins below each field should be consistent
Actual Result:
Margins below each fields are not consistent.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-04-16.at.6.27.55.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681652095740999
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017ab6742c47754266
- Upwork Job ID: 1650976064170250240
- Last Price Increase: 2023-04-25

Activity
MelvinBot commentedon Apr 18, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MitchExpensify commentedon Apr 19, 2023
@kavimuru what pixel size spacing do we expect for these margins?
MelvinBot commentedon Apr 25, 2023
@MitchExpensify Eep! 4 days overdue now. Issues have feelings too...
MitchExpensify commentedon Apr 25, 2023
This does look inconsistent and I am able to reproduce.
[-]nconsistent margins in Home address form[/-][+]Inconsistent margins in Home address form[/+][-]Inconsistent margins in Home address form[/-][+][$1000] Inconsistent margins in Home address form[/+]MelvinBot commentedon Apr 25, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017ab6742c47754266
MelvinBot commentedon Apr 25, 2023
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.
5 remaining items
hoangzinh commentedon Apr 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent margins in Home address form
What is the root cause of that problem?
All of wrapper field in this form has been added same margin-bottom number in those lines. So it's good. But according to recording in GH issue, there are 2 places showing inconsistent margin:
The zip code field => Root cause is this field having hint text, it adds an extra margin bottom (code ref)

Country field => The inconsistent margin visualize is not come from this field itself, but come from SubmitButton, where it set margin-top to 20px

What changes do you think we should make in order to solve the problem?
To fix:
hintStyleinto TextInput component, so we can adding custom styles for hint message)ahmedGaber93 commentedon Apr 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent margins in Home address form for input zip code
What is the root cause of that problem?
every input in the form has margin-bottom: 16px; but zip code have extra margin by FormHelpMessage which add margin-bottom: 4px;

What changes do you think we should make in order to solve the problem?
remove margin-bottom from FormHelpMessage component it self, or add prop style HelpMessageStyle for TextInput and pass it down to FormHelpMessage.
we can also decrease FormHelpMessage marign-top to be 4px rather than 8px to show constant, but i think no need to remove it
What alternative solutions did you explore? (Optional)
dukenv0307 commentedon Apr 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent margins in forms: Company Step, Personal information, Home Address Form,...
What is the root cause of that problem?
App/src/components/FormHelpMessage.js
Line 39 in 76c9338
App/src/components/Form.js
Line 365 in 76c9338
App/src/components/FormAlertWithSubmitButton.js
Line 60 in 76c9338
This is base component of form so that many forms in product have same issue.
What changes do you think we should make in order to solve the problem?
To be consistent, we should remove margin bottom of help message in here
App/src/components/FormHelpMessage.js
Line 39 in 76c9338
And change margin top and bottom of the container of submit buttom in here to 16px
App/src/components/Form.js
Line 365 in 76c9338
App/src/components/FormAlertWithSubmitButton.js
Line 60 in 76c9338
In
RequestorStep.jsI saw that micro text has margin has margin bottom 20px while each field in form has margin bottom 16px. Is this an inconsistent? If yes, we also need to fix it.App/src/pages/ReimbursementAccount/RequestorStep.js
Line 132 in f3fae40
What alternative solutions did you explore? (Optional)
NA
thesahindia commentedon Apr 26, 2023
It feels like a minor issue. I think we ask @shawnborton for their thoughts.
@shawnborton, do you think we should work on this?
shawnborton commentedon Apr 26, 2023
Technically this is a design bug but I feel like we should just fix this internally quickly. cc @Beamanator @cristipaval I think we just want 20px below each input grouping (could be just an input, or input + hint text).
cristipaval commentedon Apr 27, 2023
yes, this can be quickly fixed in the PR on which @gedu is working atm to align the Home Address screen to the push-to-page design. Could we assign @gedu to this one as well?
Beamanator commentedon Apr 27, 2023
@cristipaval that makes sense, but you can probably also just include this requirement in their PR and close this out now 🤷 Either way sounds reasonable to me 👍
cristipaval commentedon Apr 27, 2023
Great idea!
cristipaval commentedon Apr 27, 2023
I'll actually reopen it and let the asignees close it when they consider, as I think there is a reporting bonus to pay.
MitchExpensify commentedon Apr 27, 2023
offer sent to @DinalJivani for reporting bonus payment, will close this out when paid!
DinalJivani commentedon Apr 28, 2023
@MitchExpensify
Offer accepted.
MitchExpensify commentedon Apr 28, 2023
Paid! Thanks