Skip to content

[HOLD Browser resizing #13971] slider is hidden by save button when user try to edit photo on resize mode #17752

Closed as not planned

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Resize the window to the mobile view or width <= 800px
  2. go to setting> profile
  3. click on profile pic and click on upload photo option
  4. choose any image

Expected Result:

slider should not be hidden by save button

Actual Result:

slider is hidden by save button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
3Untitled

Screen.Recording.2023-04-20.at.12.38.49.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681974672064059

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 20, 2023
  2. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. MelvinBot commented on Apr 24, 2023

    @MelvinBot
    Contributor

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. johncschuster commented on Apr 24, 2023

    @johncschuster
    Contributor

    I've asked for clarity on the size of the window that we should be resizing to reproduce the behavior.

    https://expensify.slack.com/archives/C049HHMV9SM/p1681974672064059

  6. PrashantMangukiya commented on Apr 26, 2023

    @PrashantMangukiya
    Contributor

    This is regression from this PR #17347

    Within that PR they updated line 100 within src/components/AvatarCropModal/AvatarCropModal.js as shown below:

    - const relativeHeight = Math.max(height - styles.imageCropRotateButton.height, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);
    + const relativeHeight = Math.max(height, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);

    I tested it and it will solve this issue if we keep the original line.

    CC: @Santhosh-Sellavel @MonilBhavsar @PankajAS

  7. Santhosh-Sellavel commented on Apr 26, 2023

    @Santhosh-Sellavel
    Collaborator
    Screen.Recording.2023-04-26.at.10.32.14.PM.mov

    Here is the updated video after the change. Even the slider itself and the component itself become unuseful when we keep on resizing. I don't think this case is something worth considering, if we feel need this to be addressed this needs to be done a better way, at some point we should keep the avatar size fixed and allow scrolling. Here is how Slack handles similar cases.

    Screen.Recording.2023-04-26.at.10.47.58.PM.mov

    This could be taken as an improvement in the same issue and handled separately. Thoughts @MonilBhavsar?

  8. johncschuster commented on Apr 27, 2023

    @johncschuster
    Contributor

    Not overdue. We're working on it Melv

  9. 70 remaining items

  10. removed their assignment
    on Dec 18, 2023
  11. greg-schroeder commented on Dec 18, 2023

    @greg-schroeder
    Contributor

    Still on hold, but John is back, so unassigning!

  12. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. MonilBhavsar commented on Dec 21, 2023

    @MonilBhavsar
    Contributor

    Parent issue is Monthly, so this can also be monthly

  14. JmillsExpensify commented on Jan 22, 2024

    @JmillsExpensify
    Contributor

    We don't plan on prioritizing browser resizing anytime soon. We're more focused on migrating our existing customers from our old platform to our new platform, which will minimally take the remainder of this year. We can open up this issue in the future if/when this becomes a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.MonthlyKSv2Needs ReproductionReproducible steps needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions