Repository navigation
Fix alignment issue in zoom knob when uploading avatar - #17347
Conversation
|
not sure what went wrong here @mountiny |
Santhosh-Sellavel
left a comment
There was a problem hiding this comment.
Adding myself as reviewer
|
@PankajAS you have to link the issue with a full link |
|
@PankajAS Thanks, this is for future reference, you have to have it right when the PR is ready for review, then it will assign the correct reviewers |
MonilBhavsar
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Please fill the details, tests and offline tests section. You can mention same as online if it is not related to offline.
Also, I think there is no need to mention issue number in PR title and it can be more meaningful and relatable, For example: "Fix alignment issue in zoom knob when uploading avatar"
Updated @MonilBhavsar , please check |
|
Thanks!
|
Updated @MonilBhavsar |
|
@MonilBhavsar we can merge pull request today |
|
As this is a UI Improvement, @Expensify/design does this look good? |
Reviewer Checklist
Screenshots/Videos |
|
@Santhosh-Sellavel i have updated changes, check now |
|
Looks good to me! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.2-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.2-5 🚀
|
|
|
||
| // Even if the browser height is reduced too much, the relative height should not be negative | ||
| const relativeHeight = Math.max(height - styles.imageCropRotateButton.height, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE); | ||
| const relativeHeight = Math.max(height, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE); |
There was a problem hiding this comment.
This change caused a bug where the wrong overlap of the profile editor was present. More details - #62015







Details
In order to vertically center the Knob, I removed the top style property and set justifyContent: 'center'. As for horizontally centering the rotation button, I removed its height property to prevent overflow.
Fixed Issues
$ #16091
PROPOSAL: #16091 comment
Tests
Offline tests
same as online
QA Steps
Check that knob is aligned in center with the slider, and slider, knob and rotate button are aligned inline
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Untitled.2.mp4
Mobile Web - Chrome
AndroidChrome.mp4
Mobile Web - Safari
Untitled.6.mp4
Desktop
Untitled.4.mp4
iOS
Untitled.5.mp4
Android
AndroidNative.mp4