Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.2-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- feat: create formatPhoneNumber util function #16804
- Fix: Incorrect bill splits for some currencies #16936
- Attachment Carousel Virtual Caching #16973
- Update login flow error handling #17168
- fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310
- feat: added descriptive text for tooltips #17321
- Handle navigation for Tasks Page #17322
- Fix alignment issue in zoom knob when uploading avatar #17347
- [YearPicker] only digits allowed in yearSearchPage #17356
- Fix: App crashes on message deletion in empty chat in Offline mode #17450
- skip to replace link text which is a link #17451
- [EmojiPicker] Left align No Results Found on EmojiPicker for Web, Desktop #17476
- Fix: No notification on web if window is not active #17493
- Use local SVG for concierge icon #17501
- fix: unable to paste copied value into amount field when at least one number is present #17547
- [PronounsPage] sort pronouns list alphabetically #17558
- [MoneyRequestModal] Fix inconsistent padding on back button #17560
- update react native picker to fix 16353 #17565
- Fix CI performance regression test android apps not building anymore #17569
- Refactor ValidateCodeModal to function component #17570
- Set Max Width of Sign In Hero to 680px #17571
- Fix/17212: Also update html message and get last message in LHN when edit offline #17586
- Revert "Allow keyboard shortcuts to work on native devices" #17592
- Update translations for better UX in WorkspaceMembersPage #17593
- Revert "Merge pull request #17310 from akinwale/task-16946" #17618
- Update CONTRIBUTING.md to allow posting proposals before help wanted label #17629
- Updating translation of DC #17648
- [NO QA] Show archived rooms without participants in the LHN #17694
- Revert "Use local SVG for concierge icon" #17697
Deploy Blockers:
- [HOLD for payment 2023-04-27] LHN edited message UI shows the whole multiline message for a few seconds #17574
- [HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] FAB - There is no "New workspace" button in FAB menu #17684
- [HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console #17693
- mWeb - OldDot Transition - New Workspace is not created after tapping "Set up my company for free" #17713
- [HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] IOS - Preferences - The ">" signs are not aligned with the switches. #17731
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
mountiny commentedon Apr 19, 2023
Not sure why this deploy blocker showed up on the list, removed #17574
OSBotify commentedon Apr 19, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.2-2 🚀
mountiny commentedon Apr 19, 2023
This was reverted #17310 so checking it off
OSBotify commentedon Apr 20, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.2-3🚀OSBotify commentedon Apr 20, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-3 has been deployed to staging 🎉
mvtglobally commentedon Apr 20, 2023
We are almost done. Working on PRs
Current summary
PR #16804 is failing #17721. Repro in prod
PR #17310 is failing #16946. It's an older issue.
PR #17493 is failing #17242
PR #17565 is failing #17693
mvtglobally commentedon Apr 20, 2023
Checking off #17693
mvtglobally commentedon Apr 20, 2023
Regression is complete
PR #16973 has issue #17723 repro in prod, checking off
PR #17697 has issue on Desktop #17724. NOT repro in Prod
We are running last PR #17570
OSBotify commentedon Apr 20, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.2-4🚀OSBotify commentedon Apr 20, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-4 has been deployed to staging 🎉
OSBotify commentedon Apr 20, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.2-5🚀OSBotify commentedon Apr 20, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-5 has been deployed to staging 🎉
mvtglobally commentedon Apr 20, 2023
@mountiny can you also double check PR #17570 it's seem pass on Web/mWeb, but not working on other platforms. #17742. Not sure if this is by design
mountiny commentedon Apr 20, 2023
checking #17713 off, we think that is not a blocker but intentional behaviour
mountiny commentedon Apr 20, 2023
checking #17565 off, problem has been addressed.
checking #17493 off, already known issue
And checking off the rest based on the comments above, no blockers.
mountiny commentedon Apr 20, 2023
Graphs looking good, no new unseen crashes, deploying
mountiny commentedon Apr 20, 2023