Skip to content

Deploy Checklist: New Expensify 2023-04-19 #17671

Closed

Description

@OSBotify

Release Version: 1.3.2-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. mountiny commented on Apr 19, 2023

    @mountiny
    Contributor

    Not sure why this deploy blocker showed up on the list, removed #17574

  2. OSBotify commented on Apr 19, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.2-2 🚀

  3. mountiny commented on Apr 19, 2023

    @mountiny
    Contributor

    This was reverted #17310 so checking it off

  4. self-assigned this
    on Apr 19, 2023
  5. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.2-3 🚀

  6. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-3 has been deployed to staging 🎉

  7. mvtglobally commented on Apr 20, 2023

    @mvtglobally

    We are almost done. Working on PRs

    Current summary

    PR #16804 is failing #17721. Repro in prod
    PR #17310 is failing #16946. It's an older issue.
    PR #17493 is failing #17242
    PR #17565 is failing #17693

  8. mvtglobally commented on Apr 20, 2023

    @mvtglobally

    Checking off #17693

  9. mvtglobally commented on Apr 20, 2023

    @mvtglobally

    Regression is complete

    PR #16973 has issue #17723 repro in prod, checking off
    PR #17697 has issue on Desktop #17724. NOT repro in Prod
    We are running last PR #17570

  10. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.2-4 🚀

  11. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-4 has been deployed to staging 🎉

  12. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.2-5 🚀

  13. OSBotify commented on Apr 20, 2023

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.2-5 has been deployed to staging 🎉

  14. mvtglobally commented on Apr 20, 2023

    @mvtglobally

    @mountiny can you also double check PR #17570 it's seem pass on Web/mWeb, but not working on other platforms. #17742. Not sure if this is by design

  15. mountiny commented on Apr 20, 2023

    @mountiny
    Contributor

    checking #17713 off, we think that is not a blocker but intentional behaviour

  16. mountiny commented on Apr 20, 2023

    @mountiny
    Contributor

    checking #17565 off, problem has been addressed.

    checking #17493 off, already known issue

    And checking off the rest based on the comments above, no blockers.

  17. mountiny commented on Apr 20, 2023

    @mountiny
    Contributor

    Graphs looking good, no new unseen crashes, deploying

  18. mountiny commented on Apr 20, 2023

    @mountiny
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions