Repository navigation
Deploy Checklist: New Expensify 2023-05-02 #18322
Description
Release Version: 1.3.9-20
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Implement Invite message page #15672
- feat: magic code input (passwordless login) #16076
- Update optimistic data to match IOU action notification templates, send back additional data needed by Settle Up templates #17090
- Fix: Can delete attachments in archived workspace #17329
- Fix: Redundant URL param
openOnAdminRoomon log out #17447 - fix: inline display for comment links #17496
- Fix: moved popover menu max width from menu item into context menu item component #17640
- Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message #17704
- Fix: RBR not show on error workspace in Workspace List page #17902
- [Onfido] Fix use of locale in Onfido #17943
- Fix: Some inputs are not focused automatically #17953
- Add new vertical line separator instead of borderRight #18022
- [No QA] Add green dot in LHN when chat is unread with mention #18038
- Fix: Current currency is not highlighted and not marked #18059
- fix: web does not show not show notifications for not active window #18065
- Fix: Description menu item is not disabled on confirm #18066
- [No QA] Implement the SubScript avatar for workspace money requests #18085
- Add margin above Remove button in Contact Method Detail screen #18087
- [PhoneNumber-Verification 2] Display only valid numbers in user search. #18103
- Fix: Dev error when not grant camera permission on native #18126
- Fix GBR and RBR show up at the same time in the LHN #18137
- Fix applying styling when it want to apply opacity on OpacityView #18153
- fix: re-add placeholder text inside base option selector #18155
- [NoQA] Add falsey checks and
_.compact()to places where we access SMS logins from personal details #18159 - Fix form terminology #18160
- [NoQA] Remove unnecessary participants filtering #18173
- [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18193
- Avoid parsing html in editing composer when reloading page #18195
- Prevent emoji suggestions flicker on file picker opening on desktop web #18227
- Fix: Copying the messages and marking a message in between as unread generates 'new' in the text #18228
- Fix email keyboard type #18236
- [Icon Size] GBR, RBR & related icon size 20x20 #18242
- Fix iOS Webp Download #18256
- Feat: Hide member if no errors and deletion is pending #18257
- Update react-native-onyx to 1.0.41: Removes AsyncStorage from Onyx #18261
- Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266
- [No QA] Fix the padding on the subscript avatar #18275
- fix add reaction icon position changed when user add emoji #18276
- Rename referral-program.md to Referral-Program.md #18336
- Revert "Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message" #18360
- [CP Staging] Update the check for default avatars to account for new naming #18361
- [CP Staging] Re-add old-style default avatar prefix #18369
- Revert "Fix: Copying the messages and marking a message in between as unread generates 'new' in the text" #18380
- Followup fixes on invite message page implementation #18395
Deploy Blockers:
- Implement Invite message page #15672
- [HOLD for payment 2023-05-16] [$1000] Avatar is not loaded when creating a new account #18304
- [$1000] Remove photo option is shown with Avatar #18314
- Created workspace is not immediately reflected in LHN #18323
- Workspace - Manage members - After clicking the "Invite" button, 403 error appears in console #18335
- Split Bill - List of user is not displayed in Split bill request #18341
- Workspace - Created Workspace looks greyed out when user go offline #18345
- Workspace - An error after completing the connection of the bank account #18355
- Admin is not shown on Manage members page while offline #18356
- New marker line overlaps on the context menu items when marking a message as "unread" #18358
- Request Money -The word "Request" in the conversation appears with a small letter #18359
- [HOLD for payment 2023-05-16] Select all copies nothing #18376
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon May 3, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.9-13 🚀
OSBotify commentedon May 3, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.9-14 🚀
OSBotify commentedon May 3, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.9-15🚀marcaaron commentedon May 3, 2023
Checking off #18314 because it's on prod
marcaaron commentedon May 3, 2023
Checking off #18323 as it's related to the web deploy
marcaaron commentedon May 3, 2023
Checking off #18304 as it's on prod
OSBotify commentedon May 3, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.9-15 has been deployed to staging 🎉
marcaaron commentedon May 3, 2023
Checking off #18341 as @luacmartins removed the blocker.
marcaaron commentedon May 3, 2023
Checking off #18335 as the issue is related to staging web API changes.
marcaaron commentedon May 3, 2023
Checked off #18345 (comment) - it's related to the Pusher issues and web deploy.
marcaaron commentedon May 3, 2023
Same deal for #18356
OSBotify commentedon May 3, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.9-16🚀5 remaining items
OSBotify commentedon May 3, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.9-17 has been deployed to staging 🎉
mvtglobally commentedon May 3, 2023
@marcaaron Still working on the checklist, but here is current issue list
PR #15672 facing issue #18335
PR #16076 is failing #18330, not repro in PROD but its a new feature
PR #17090 is failing #18362. repro in prod still checking all env
PR #17447 is failing #18351, repro in PROD
PR #17943 is failing #15638 #18344. repro in PROD, checking off
#18103 is failing #18372, repro in PRoD
PR #18228 is failing #18343
PR #18242 is failing #18384. Not repro in PROD. new feature, so no blocker label. pls double check
OSBotify commentedon May 3, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.9-19🚀OSBotify commentedon May 3, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.9-18 has been deployed to staging 🎉
OSBotify commentedon May 4, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.9-19 has been deployed to staging 🎉
marcaaron commentedon May 4, 2023
Most of those don't really seem like blockers to me so I am checking a bunch off.
mountiny commentedon May 4, 2023
Checking #17640 off since this failing QA does not seem like a blocker #18349
Checking #18065 off since ti seems like its not failing QA
checking this one #18137 since it also did not fail QA
mvtglobally commentedon May 4, 2023
@mountiny Regression is completed
#18065 had issue #17242 on mWeb, but its repro in PROD. only Android validation is pending on this on QA side.
#18380 seem to be failing
18380.Web.mp4
OSBotify commentedon May 4, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.9-20🚀mountiny commentedon May 4, 2023
@mvtglobally #18380 is a pass the instruction are about input field and not just any text. I checked in composer and it works! Thanks!
And I dont think #18065 is a deploy blocker
mountiny commentedon May 4, 2023
Nothing new in the graphs or crashes.
Just waiting for the last CP before kicking the deploy off
OSBotify commentedon May 4, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.9-20 has been deployed to staging 🎉
mountiny commentedon May 4, 2023
Checking #18395 off as it seems to work in staging although the optimistic workspace chats part did not seem to work for me. But i dont think its a blocker as users can use this just fine
mountiny commentedon May 4, 2023