Repository navigation
Deploy Checklist: New Expensify 2023-05-11 #18764
Description
Release Version: 1.3.13-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Add ability to set a contact method your default contact method #16750
- Adding device information to sign in #17149
- fix/14490: No data displayed in options list if component using report data is rendered too early #17349
- Prevent crash after interacting with reaction tooltip #18037
- Refactored the NewPasswordForm component to functional #18081
- Wrap label component to fix overflow #18125
- Enable RequestMoney in Workspace chats #18215
- Migrate WorkspaceSettingsPage.js to function component #18299
- Simplify failure data for request/send money and make it more consistent with SplitBill #18328
- fix: border cut in emoji picker #18353
- refactor: migrate MagicCodeInput to function component #18398
- [Reimburse Expenses] update track distance rate placeholder on currency change #18401
- Add prettier into the build process #18416
- Block navigation shortcuts when plaid modal is loading/shown #18462
- fix inconsistent behavior on toggle button delay #18466
- Add mention suggestions #18469
- Fix: Red dot persists after removing phone number contact method #18473
- fix: save terms of service checkbox in draft #18479
- Fix ThumbnailImage minWidth to display spinner #18485
- Implement the RequestPreview component and update the IOUPreview #18486
- Disable iOS code block bounces #18487
- Fix strike-through when offline and deleting Paypal for native Android/iOS #18524
- [NoQA] Update ReportScreen to display MoneyRequest Reports #18538
- Issue with reacting to messages with multiple emoji skin tones #18573
- show loader in Connect Account page #18574
- Fix: User list is not dynamically updated on invite members page #18580
- 17886 — Create custom renderer for Here mentions #18582
- Fixing regression from Invite message refractor #18601
- [NoQA] Fix type errow when we passed object of personal details instead of a string #18620
- fix: prevent dropping files in the drop zone if the attachment modal is active #18624
- added padding on offlineFeedback #18629
- Fix: Workspaces icons and DotIndicator has inconsistent space with right icon #18639
- Update expensify-common version for mentions #18655
- [IOU Split Bill] Use participants optimistically #18656
- Update task detailed view #18676
- [No QA] Update .prettierignore to ignore dist folders #18689
- Update expensify-commmon to avoid parsing nested link #18697
- Changes to IOUAction and IOUPreview #18698
- Revert "Fix: Red dot persists after removing phone number contact method" #18705
- [NO QA] Comment change just to bump checklist version #18709
- Add
participantsback to buildOptimisticIOUReportAction #18711 - [No QA] fix proptype warning, make prettier happy #18725
- [NO QA] Reset the min supported iOS version to 13 #18778
- fix skeleton loading forever on options list when offline #18788
- fix: android app crash fix due to wrong position of LayoutAnimation #18842
- fix: call onModalHide when the confirm modal is closed #18897
Deploy Blockers:
- [HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline #18781
- [HOLD for payment 2023-05-23] [$1000] [HOLD for payment 2023-05-22] Unable to drag and drop an attachment after trying to upload a non-supported attachment. #18888
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon May 11, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.13-0 🚀
OSBotify commentedon May 11, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.13-1🚀OSBotify commentedon May 11, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-1 has been deployed to staging 🎉
OSBotify commentedon May 12, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.13-2🚀OSBotify commentedon May 12, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-2 has been deployed to staging 🎉
Beamanator commentedon May 12, 2023
Ok #18486 finallyyy got successfully CP'd to staging, it's in the process of being deployed to all platforms now - https://github.com/Expensify/App/actions/runs/4959306332
Beamanator commentedon May 12, 2023
One more possible CP here: #18788
mvtglobally commentedon May 12, 2023
@Beamanator We are just wrapping few last PRs in the checklist TR is completed
#18469 is failing #18793
#18485 is failing #18794
mvtglobally commentedon May 12, 2023
Can you also check #18081 (comment) We are not sure if thats expected now
Beamanator commentedon May 12, 2023
Ok it looks like #18793 (caused by #18469) is being fixed by #18842
Beamanator commentedon May 12, 2023
For this one, everyone should be on passwordless now so we can check it off, I'm not sure why we still have that passwordless form still anyway 😅
Beamanator commentedon May 12, 2023
For #18794, it shouldn't be related to #18485 so i'm marking that one off 👍
7 remaining items
OSBotify commentedon May 14, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-4 has been deployed to staging 🎉
OSBotify commentedon May 14, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.13-5🚀OSBotify commentedon May 14, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-5 has been deployed to staging 🎉
mountiny commentedon May 14, 2023
Checking off the deploy blockers and PRs, confirmed it was fixed in staging
mountiny commentedon May 14, 2023
Checking off #18469 since #18793 has been cped to staging to fix the discovered issue
mountiny commentedon May 14, 2023
Checking off #18486 as follow up issue is not a deploy blocker and handled by contributors
mountiny commentedon May 14, 2023
Checking this of #18328 since the linked issues are not blockers
mountiny commentedon May 14, 2023
This is ready to deploy on Monday morning, assigning myself to handle this unless someone will do that before me :D
Beamanator commentedon May 15, 2023
Added some thoughts about firebase crashlitics here - https://expensify.slack.com/archives/C07J32337/p1684132624221449?thread_ts=1684026901.091199&cid=C07J32337
I think we can move forward with deploy
Beamanator commentedon May 15, 2023
@mountiny & I agreed we can ship 👍
Beamanator commentedon May 15, 2023