Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.23-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Add Context menu with Pin option to LHN #16079
- fix: 2FA bug fixes #19260
- Hide mention suggestions while opening file picker #19541
- 17020 — Migrate calendar picker to PressableWithFeedback/WithoutFeedback #19557
- Fix - ReportDetail Styling Inconsistency #19731
- remove download attachment on deleted attachment #19769
- fix editing just emoji cuts top part android #19798
- Fix no selection identifier on magic code input field once the field displays an error status #19801
- [NO QA] Update contributing guidelines for bug reporting #19807
- Fix the spinner showing when uploading twice the same image on android #19816
- Remove threads beta #19829
- Fix for: IOU threads don't have pin options #19851
- fix: Lower case searchvalue before cheking #19880
- Fix spacing issue with headers when text is multiline #19889
- Fix: update padding of “no result found” error in message input #19930
- Fix clicking next to Resend magic code on Contact methods clicks on the link #19936
- fix: inconsistent label for split bill participant selector #19939
- Fix crash while changing contact method #19941
- [NoQA] refactor: revert danger #19948
- fix window flash when click email link #19949
- [No QA]Update login notes for passwordless login for iOS App Review #19969
- [No QA]Speed up deploys by turning on large runners #20015
- Revert "[No QA]Speed up deploys by turning on large runners" #20029
- [No-QA]Use large runners for deploys #20056
- Try to use
labels:to get large runner to start #20096 - [No QA]Revert Ubuntu large runner testing #20104
- Add null check before react effect #20155
Deploy Blockers:
- [HOLD for payment 2023-06-13] [HOLD for payment 2023-06-12] Add null check for optionItem #20154
- [HOLD for payment 2023-07-12] [$1000] mWeb - Modified magic code link redirects to Welcome screen with first place of magic code green #20169
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Jun 2, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.23-4🚀OSBotify commentedon Jun 2, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-4 has been deployed to staging 🎉
Julesssss commentedon Jun 2, 2023
FYI to the lucky deployer next week, we faced some issues with the prod build release.
Please be aware that as of Friday the prod build is not running
1.3.23but is two versions behind at1.3.21-- this is important to know when looking for potential bllockers, as the PR could also have been added here.mvtglobally commentedon Jun 2, 2023
@Julesssss We will still label anything we think could be blocker to be on the safer side and let new Deployer review it. This checklist will most likely be done by through the weekend
mvtglobally commentedon Jun 2, 2023
Please tag us as the builds are completed. We are waiting for the build to start QA
OSBotify commentedon Jun 2, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.23-5🚀OSBotify commentedon Jun 2, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-5 has been deployed to staging 🎉
OSBotify commentedon Jun 2, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.23-6🚀OSBotify commentedon Jun 2, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-6 has been deployed to staging 🎉
Julesssss commentedon Jun 5, 2023
Hey @mvtglobally, I think @AndrewGable has resolved the build issues now (based on this discussion), but please let us know if any builds remain missing!
OSBotify commentedon Jun 5, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.23-7🚀OSBotify commentedon Jun 5, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-7 has been deployed to staging 🎉
mvtglobally commentedon Jun 5, 2023
@Julesssss we started with the build 1.3.23-6. Checking CPs now
mvtglobally commentedon Jun 5, 2023
PR #19260 failing #20136
PR #19829 is failing #20135
PR #19851 is failing #19438 older ki
Julesssss commentedon Jun 5, 2023
Thank you!
Morning @roryabraham. Thankfully the CI issues from last week seem to be resolved 😍
Also, the only blocker has already been fixed and CP'd. But I'll leave it to you to check it off. More context here in Slack.
roryabraham commentedon Jun 5, 2023