You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-12] [$1000] mWeb - Modified magic code link redirects to Welcome screen with first place of magic code green #20169
Navigate to the email inbox and open the validate email and copy the link
Modify link to staging and change a single character of URL
Navigate to the compiled link
Expected Result:
Magic code boxes should be in red. And I assume "Magic code is incorrect" should be more focused or even in the header of the page. Instead of "Didn't receive a code" there should be a "Request a new code" link.
Actual Result:
First place of magic code is green, however all the rest 5 are red. Header of the screen is still "Welcome back...", no sign "Magic code is incorrect". Instead of "Request a new code" link there is still "Didn't receive a code" link, however it is obvious from error message that link was received and used.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.26.3
Reproducible in staging?: yes
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Adding Deploy Blocker Label, because production did not have green at the start, and there was a different issue that it said "incorrect 2fa" for a modified login for new account.
To clarify, step 4, Modify link to staging and change a single character of URL. Are you saying to remove a number or character after the URL is https://staging.? For example, the URL is https://staging.new.expensify.com/v1/14 but change it to https://staging.new.expensify.com/v1/15. Is that correct?
I am demoting this from Deploy Blocker to regular bug b/c, while this bug exists on staging and not prod, it's replacing an existing production bug, and it's not any worse than what we had before. Also, I think this is an edge case that real users are unlikely to encounter.
Modify link to staging and change a single character of URL
I'm assuming this refers to changing a single character in the validateCode (last) portion of the URL?
@MariaHCD - I need some help here, can you please confirm that we cleared the regression period for #22258, and then I can continue with the payment process here? Thanks!
@alexpensify Thank you for the offer. Can I ask you a question? The contributing guide states that the contributor is not eligible only for the 50% bonus if the PR causes regression but it doesn't say anything about the payment reduction. It is just that I'm confused about the reduction part.
If the PR causes a regression at any point within the regression period (starting when the code is merged and ending 7 days after being deployed to production), contributors are not eligible for the 50% bonus.
@HezekielT - I've asked the team to review my calculations and will follow up tomorrow. I would like to be extra sure here before completing the process.
The PR that introduced the bug has been identified. Link to the PR: Umm not really a bug. It's a small UX enhancement.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. - No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
Activity
melvin-bot commentedon Jun 5, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Jun 5, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 5, 2023
Triggered auto assignment to @Beamanator (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Jun 5, 2023
Adding Deploy Blocker Label, because production did not have green at the start, and there was a different issue that it said "incorrect 2fa" for a modified login for new account.
video_57.mp4
alexpensify commentedon Jun 5, 2023
To clarify, step 4,
Modify link to staging and change a single character of URL. Are you saying to remove a number or character after the URL ishttps://staging.? For example, the URL ishttps://staging.new.expensify.com/v1/14but change it tohttps://staging.new.expensify.com/v1/15. Is that correct?roryabraham commentedon Jun 5, 2023
I am demoting this from Deploy Blocker to regular bug b/c, while this bug exists on staging and not prod, it's replacing an existing production bug, and it's not any worse than what we had before. Also, I think this is an edge case that real users are unlikely to encounter.
I'm assuming this refers to changing a single character in the validateCode (last) portion of the URL?
92 remaining items
alexpensify commentedon Jul 16, 2023
@MariaHCD - I need some help here, can you please confirm that we cleared the regression period for #22258, and then I can continue with the payment process here? Thanks!
MariaHCD commentedon Jul 17, 2023
@alexpensify Yes, I believe the regression period is over and payments can be processed here.
rushatgabhane commentedon Jul 17, 2023
made a manual request for $500 https://staging.new.expensify.com/r/5687801944251726
it'll be paid by Anu or Jason
alexpensify commentedon Jul 17, 2023
Upwork Payment Link will be: https://www.upwork.com/jobs/~017f81a4814fafb02a
alexpensify commentedon Jul 17, 2023
@HezekielT - I've prepared the payment process in Upwork. Due to the regression period, there will be no bonus here and there is a payment reduction.
HezekielT commentedon Jul 17, 2023
@alexpensify Thank you for the offer. Can I ask you a question? The contributing guide states that the contributor is not eligible only for the 50% bonus if the PR causes regression but it doesn't say anything about the payment reduction. It is just that I'm confused about the reduction part.
Also according to this slack conversation (https://expensify.slack.com/archives/C01GTK53T8Q/p1689256242282159) the payment reduction is only applicable for the C+ not for the contributor.
alexpensify commentedon Jul 18, 2023
@HezekielT - I've asked the team to review my calculations and will follow up tomorrow. I would like to be extra sure here before completing the process.
alexpensify commentedon Jul 18, 2023
@HezekielT - I updated the payment for this one. I appreciate your patience here.
alexpensify commentedon Jul 18, 2023
@rushatgabhane - when you get a chance, can you please complete the checklist? After, we can close this one out:
#20169 (comment)
Thanks!
HezekielT commentedon Jul 18, 2023
@alexpensify Thank you!
alexpensify commentedon Jul 20, 2023
@rushatgabhane - any update on completing the checklist, so we can close this one out? Thanks!
alexpensify commentedon Jul 21, 2023
@anmurali - we are on hold for C+ payment and will give the 🟢 as soon as the checklist has been completed.
rushatgabhane commentedon Jul 23, 2023
The PR that introduced the bug has been identified. Link to the PR: Umm not really a bug. It's a small UX enhancement.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. - No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
alexpensify commentedon Jul 23, 2023
Thank you @rushatgabhane! @anmurali all set for payment here. I'm going to close this GH since all actions have been completed.