Skip to content

[HOLD for payment 2023-07-12] [$1000] mWeb - Modified magic code link redirects to Welcome screen with first place of magic code green #20169

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open NewDot app
  2. On the log in screen, enter a new account email
  3. Navigate to the email inbox and open the validate email and copy the link
  4. Modify link to staging and change a single character of URL
  5. Navigate to the compiled link

Expected Result:

Magic code boxes should be in red. And I assume "Magic code is incorrect" should be more focused or even in the header of the page. Instead of "Didn't receive a code" there should be a "Request a new code" link.

Actual Result:

First place of magic code is green, however all the rest 5 are red. Header of the screen is still "Welcome back...", no sign "Magic code is incorrect". Instead of "Request a new code" link there is still "Didn't receive a code" link, however it is obvious from error message that link was received and used.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26.3

Reproducible in staging?: yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6079422_video_55__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01248e0e8338f0924d
  • Upwork Job ID: 1665829720115789824
  • Last Price Increase: 2023-06-25

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 5, 2023
  2. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Jun 5, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. kbecciv commented on Jun 5, 2023

    @kbecciv
    Author

    Adding Deploy Blocker Label, because production did not have green at the start, and there was a different issue that it said "incorrect 2fa" for a modified login for new account.

    video_57.mp4
  7. alexpensify commented on Jun 5, 2023

    @alexpensify
    Contributor

    To clarify, step 4, Modify link to staging and change a single character of URL. Are you saying to remove a number or character after the URL is https://staging.? For example, the URL is https://staging.new.expensify.com/v1/14 but change it to https://staging.new.expensify.com/v1/15. Is that correct?

  8. roryabraham commented on Jun 5, 2023

    @roryabraham
    Contributor

    I am demoting this from Deploy Blocker to regular bug b/c, while this bug exists on staging and not prod, it's replacing an existing production bug, and it's not any worse than what we had before. Also, I think this is an edge case that real users are unlikely to encounter.

    Modify link to staging and change a single character of URL

    I'm assuming this refers to changing a single character in the validateCode (last) portion of the URL?

  9. 92 remaining items

  10. alexpensify commented on Jul 16, 2023

    @alexpensify
    Contributor

    @MariaHCD - I need some help here, can you please confirm that we cleared the regression period for #22258, and then I can continue with the payment process here? Thanks!

  11. MariaHCD commented on Jul 17, 2023

    @MariaHCD
    Contributor

    @alexpensify Yes, I believe the regression period is over and payments can be processed here.

  12. rushatgabhane commented on Jul 17, 2023

    @rushatgabhane
    Member

    made a manual request for $500 https://staging.new.expensify.com/r/5687801944251726

    it'll be paid by Anu or Jason

  13. alexpensify commented on Jul 17, 2023

    @alexpensify
    Contributor
  14. alexpensify commented on Jul 17, 2023

    @alexpensify
    Contributor

    @HezekielT - I've prepared the payment process in Upwork. Due to the regression period, there will be no bonus here and there is a payment reduction.

  15. HezekielT commented on Jul 17, 2023

    @HezekielT
    Contributor

    @alexpensify Thank you for the offer. Can I ask you a question? The contributing guide states that the contributor is not eligible only for the 50% bonus if the PR causes regression but it doesn't say anything about the payment reduction. It is just that I'm confused about the reduction part.

    If the PR causes a regression at any point within the regression period (starting when the code is merged and ending 7 days after being deployed to production), contributors are not eligible for the 50% bonus.

    Also according to this slack conversation (https://expensify.slack.com/archives/C01GTK53T8Q/p1689256242282159) the payment reduction is only applicable for the C+ not for the contributor.

  16. alexpensify commented on Jul 18, 2023

    @alexpensify
    Contributor

    @HezekielT - I've asked the team to review my calculations and will follow up tomorrow. I would like to be extra sure here before completing the process.

  17. alexpensify commented on Jul 18, 2023

    @alexpensify
    Contributor

    @HezekielT - I updated the payment for this one. I appreciate your patience here.

  18. alexpensify commented on Jul 18, 2023

    @alexpensify
    Contributor

    @rushatgabhane - when you get a chance, can you please complete the checklist? After, we can close this one out:

    #20169 (comment)

    Thanks!

  19. HezekielT commented on Jul 18, 2023

    @HezekielT
    Contributor

    @alexpensify Thank you!

  20. alexpensify commented on Jul 20, 2023

    @alexpensify
    Contributor

    @rushatgabhane - any update on completing the checklist, so we can close this one out? Thanks!

  21. alexpensify commented on Jul 21, 2023

    @alexpensify
    Contributor

    @anmurali - we are on hold for C+ payment and will give the 🟢 as soon as the checklist has been completed.

  22. rushatgabhane commented on Jul 23, 2023

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: Umm not really a bug. It's a small UX enhancement.

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. - No

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

  23. alexpensify commented on Jul 23, 2023

    @alexpensify
    Contributor

    Thank you @rushatgabhane! @anmurali all set for payment here. I'm going to close this GH since all actions have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions