You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-14] Web - First cell of magic input field is not focused on clicking 'Didn't receive a magic code' link #22258
The first cell of the magic code input field should be focused
Actual Result:
The first cell of the magic code input field is not focused
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.36-4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Regardless, focusing the first cell isn't a good idea. Because if you type one single number it'll auto-submit because you have 6 digits in the input. What do you think?
Activity
OSBotify commentedon Jul 5, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 5, 2023
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.samh-nl commentedon Jul 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The first cell of the magic input is not focused upon resending the code.
What is the root cause of that problem?
The input focus is not restored in the
resendValidateCodefunction:App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js
Lines 180 to 188 in 4f9f428
What changes do you think we should make in order to solve the problem?
The focus should be restored by calling
inputValidateCodeRef.current.focus()inBaseValidateCodeFormupon resending the code.What alternative solutions did you explore? (Optional)
N/A
MariaHCD commentedon Jul 5, 2023
Looking to see if this is related to #21724
rushatgabhane commentedon Jul 5, 2023
Hi @MariaHCD, I don't think this is a bug.
It's the expected result. After a failed validation, we decided to blur the input in #20169 (comment).
rushatgabhane commentedon Jul 5, 2023
Regardless, focusing the first cell isn't a good idea. Because if you type one single number it'll auto-submit because you have 6 digits in the input. What do you think?
MariaHCD commentedon Jul 5, 2023
In this case, there was no failed validation. The user just requested for a new code.
Oh, interesting. Why does it auto-submit when only a single digit has been entered?
HezekielT commentedon Jul 5, 2023
@rushatgabhane I can address this issue by changing the if condition in my PR to
I limited the
hasErroronly toprops.session.autoAuthStatethat is why this issue is occuring should I change my pr? @MariaHCDrushatgabhane commentedon Jul 5, 2023
@MariaHCD sorry, I misunderstood this issue.
The steps to get this bug are -
Expected: input is cleared and focused
Actual: input is cleared and blurred
39 remaining items
MariaHCD commentedon Jul 10, 2023
Nice catch, @HezekielT! Updated.
zanyrenney commentedon Jul 14, 2023
Added the issue for the regression test.
zanyrenney commentedon Jul 17, 2023
#22258 (comment) as per this comment, creating an upwork job specifically for reporting bonus.
zanyrenney commentedon Jul 17, 2023
Invited you: https://www.upwork.com/jobs/~011861274c564ee819 @Natnael-Guchima
Natnael-Guchima commentedon Jul 17, 2023
I have applied to the job. Thanks @zanyrenney
zanyrenney commentedon Jul 18, 2023
Offer sent!
Natnael-Guchima commentedon Jul 18, 2023
Accepted the offer. Thank you.
zanyrenney commentedon Jul 18, 2023
That is all paid!