Deploy Checklist: New Expensify 2023-06-05

Release Version: 1.3.24-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@Skalakid

#20036 - Will be tested with the regression run, will check it off after the regression is complete (if it is a pass)

For #20068 unsure if we need to execute step 1 to be able to verify this PR - @Skalakid @Gonals can you confirm please

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-1 🚀

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-1 has been deployed to staging 🎉

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.24-0 🚀

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-2 🚀

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-2 has been deployed to staging 🎉

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-3 🚀

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-3 has been deployed to staging 🎉

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-4 🚀

Fix for #20154 was deployed with the last checklist, removing the label

Can we please retest the following deploy blockers in 1.3.24-4. I think they all may have been fixed by #20220. Please log out and back in after updating before retesting:

Oh, yeah desktop deploy failed for 1.3.24-4. It's been very flaky and I don't really have a solution other than retrying for now.

Full Summary of PR testing:

Feature Request: Assign task to yourself #19515 several issues were found, including 3 different deploy blockers:

[$500 BONUS PAYOUT] [$1000] Web - Chat - '# Reply' is not displayed after replying to root message without network #20265
[$1000] Web - Task - Task actions not updated in real time in task report #20266
Task - Task is not unchecked when marked as incomplete #20285
Assign task - Error message about title shows up when title is inputted #20281

fix workspace avatar it not updated #19750 - is being retested after the DB fix. Desktop test is missing bc 1.3.24-4 is not available yet
17027 - migrated CollapsibleSection to PressableWithFeedback #19753 is failing because of issue [$2000] IOU - Add bank account is looping when clicking pay with expensify #20280
Use Paid language in requests instead of settled and other manual requests polish #19817 is failing because of this issue [HOLD on prioritizing P2P] IOU - Button doesn't show the expected text "Pay" or "Pay Elsewhere" #20236
Fix replay component position while editing message #19902 is failing because of [$500 BONUS PAYOUT] [$1000] Web - Chat - '# Reply' is not displayed after replying to root message without network #20265
For 20019 - migrated TaskHeader to PressableWithFeedback #20068 we're unsure if we need to execute step 1 to be able to verify this PR (Asked here)
Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112 is failing because of issue [HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND #20275 (Left a message to validate if it should be a DB or not)
Revert PERSONAL_DETAILS_LIST Onyx changes #20220 - waiting for desktop build

Going to hide the previous comments as this list centralizes all the issues with unchecked PRs.

Working on getting desktop deploys fixed

@francoisl

#20112 is failing because of issue #20275 Left a message for @francoisl to confirm if it should be a DB or not

Commented in the issue, not a blocker so feel free to check 20112 if the rest is working fine. Thanks!

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-5 🚀

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-5 has been deployed to staging 🎉

Desktop deploy worked btw ... 5th time's the charm

@roryabraham

@roryabraham thsnks for confirmation. We will wrap up now.

Full Summary of unchecked PR testing:

Feature Request: Assign task to yourself #19515 several issues were found, including 3 different deploy blockers. We are retesting this Pr after revert

fix workspace avatar it not updated #19750 - is being retested after the DB fix. Desktop test is missing bc 1.3.24-5 just got available. It's pass checking off

This PR #19753 (comment) is failing QA because of issue #20280

Use Paid language in requests instead of settled and other manual requests polish #19817 is failing because of this issue [HOLD on prioritizing P2P] IOU - Button doesn't show the expected text "Pay" or "Pay Elsewhere" #20236

Fix replay component position while editing message #19902 is failing because of Web - Chat - '# Reply' is not displayed after replying to root message without network #20265

#20068 (comment)

Revert PERSONAL_DETAILS_LIST Onyx changes #20220 - just got desktop build, checking

Ok, sorry for the delay. Let's see if we can get this over the finish line. Here's where we're at right now:

[HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND #20275 – demoted, checking it off.
[$1000] Closed accounts aren't removed from workspace members list #20264 – not a blocker but should be fixed in 1.3.24-4. Now that that deploy completed successfully, let's please retest and close if not reproducible.
fix workspace avatar it not updated #19750 – needs retest on desktop
17027 - migrated CollapsibleSection to PressableWithFeedback #19753 – issue not a deploy blocker, checking it off.
Use Paid language in requests instead of settled and other manual requests polish #19817 - issue not a deploy blocker, checking it off.
Fix replay component position while editing message #19902 – issue not a deploy blocker, checking it off.
20019 - migrated TaskHeader to PressableWithFeedback #20068 – I was able to verify this one, checking it off.
Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112 – issue not a deploy blocker, checking it off.

Concise summary:

All that's left is these two PRs:

Feature Request: Assign task to yourself #19515 - all the associated issues were fixed by the revert, just re-checking those on desktop
~~fix workspace avatar it not updated #19750 – looks like this has been checked off so nothing more to do here~~

Noticed something weird with the timing dashboard, not a blocker but brought up here: https://expensify.slack.com/archives/C035J5C9FAP/p1686081343190679

#20305 was found while executing the retest of #19515. The issue is reproducible in production so not sure if it should be related to this PR.
We were also able to reproduce this one #20284 (comment) but it's getting fixed on a different PR

Aside from these 2 issues, the PR was a pass.

Navigation Menu

Repository navigation

Deploy Checklist: New Expensify 2023-06-05 #20195

6 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Deploy Checklist: New Expensify 2023-06-05 #20195

Description

Activity

isagoico commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

OSBotify commented on Jun 5, 2023

roryabraham commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

isagoico commented on Jun 6, 2023

6 remaining items

roryabraham commented on Jun 6, 2023

isagoico commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

francoisl commented on Jun 6, 2023

OSBotify commented on Jun 6, 2023

OSBotify commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

mvtglobally commented on Jun 6, 2023

mvtglobally commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

isagoico commented on Jun 6, 2023

roryabraham commented on Jun 6, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions