Repository navigation
Deploy Checklist: New Expensify 2023-06-21 #21172
Description
Release Version: 1.3.30-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Ask non-USD Workspaces to update currency before adding VBBA #19638
- 17046 — migrate PressableWithotFocus to GenericPressable #20202
- Swiping between attachments in preview mode fix. #20245
- 17031 - migrate ReportActionItemSingle to PressableWithoutFeedback #20343
- Refactor AttachmentModal to function component #20365
- Added shouldShowOfflineIndicator default props #20467
- Fix/19987: Prioritize using name of policy from policy #20498
- Fix 20200: Fails to Proceed with Similar Routing and Account Numbers Without Error Message #20560
- Fix lost hover effect on long press and click #20561
- fix: CodesPage buttons overlapping #20575
- [NoQA] [navigation-refactor] Refactor follow ups v1 #20593
- Refactor WorkspaceMembersPage to functional component #20687
- Fix empty assignee in TaskHeader and update permission to mark Task complete/incomplete/cancel in Task report #20689
- 20602 — migrate PinButton to PressableWithoutFeedback #20711
- 20603 — migrate ReportPreview to PressableWithoutFeedback #20712
- Fix Keyboard popping up when member selected in new group page or in workspace invite page #20731
- 19700: Arrow key shortcut stops working #20756
- 20604 — Migrate TaskPreview to PressableWithoutFeedback #20775
- Fix 20516 mWeb topbar color #20805
- fix: 20585 - Web - Split Bill - Money request confirmation list stays highlighted after press #20838
- remove wrong performance measurement in task assignee selector, share destination pages #20840
- Added 'Copied!' text to textChecked of buttons in 2FA #20889
- Hide ReportActionContextMenu when ReportActionItem is destroyed #20890
- 2FA Input field not focused on mobile #20891
- Fix for: No consistency in margin left for green tick besides amount #20895
- Revert "fix: add background to share code avatar" #20938
- Use parentReportID for report edits when modifying thread parent action #20945
- [CP Staging] Make sure that we first check the PersonalDetails we already have before creating fake optimistic personal details #20951
- fix copy button does not work on the first click #20957
- Fix ReportActionItemCreated update #20960
- Fix console error invalid prop in native #20968
- Feature: Improve TaskPreview UI #20997
- Fix: Error message "Can't remove admin" isn't shown when selecting workspace admins #21023
- fix avatar tooltip issues across the app #21026
- Fix Mentions crash #21030
- disable chat list user select on mobile web #21042
- Don't allow non-policy members to edit welcome message #21043
- pop the deleted workspace page from navigation #21045
- [Fix] New Room participants list is empty #21072
- Use new path for share url #21081
- Hide context menu if anonymous user clicks on it #21094
- Fix split bill display / selection with new users #21113
- fix: dont pop RHP when shortcuts modal is open #21114
- Fix: Search - Group chat displays blank in Search results #21148
- personalDetails.login can be missing for new accounts #21150
- Only consider personal details with logins set in
OptionsListUtils.getOptions#21159 - Use participant accountIDs in SplitBill details page #21161
- Allow DM'ing from profile even if you don't "know" the user #21231
- [No QA]Use
ubuntu-latest-xlandmacos-12-xllarge runners to speed up deploys #21232 - Account number fix #21252
- [No QA]Update
electron-builderto 24.5.0 to fix desktop builds #21256 - Fix duplicate chats being created #21265
Internal QA:
Deploy Blockers:
- [HOLD for payment 2023-06-29] Web - Group chat - "Invalid email" error message appears when creating a group DM with Concierge #21040
- [Awaiting payment] New Chat report is always created even after a chat report already exists #21184
- Full user details are not shown when clicking avatar in chat header #21199
- Request Money/Split Bill - Unexpected error shows up when create IOU #21208
- [HOLD for payment 2023-06-30] Bank-account - The emply account number have 'The routing number and account number cannot be the same' instead of 'Please enter a valid routing number' #21222
- [HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268
- Members - Pressing Enter for the first time mark user and moves to the next screen #21276
- [$1000] Workspace -User needs to tap ‘Back’ twice to return to previous screen from ‘Connect BA' offline #21277
- FAB - Missing conversations in recent list #21283
- Chat - Creating a new chat with the same email while offline creates duplicate chats #21303
- Old Dot Transition - Could not finish setting up Bank Account because of currency error #21309
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jun 21, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.30-0 🚀
luacmartins commentedon Jun 21, 2023
Checking off #21040 since it was solved in the latest deploy already
luacmartins commentedon Jun 21, 2023
Checking off #21208 since the blocker label was removed.
luacmartins commentedon Jun 21, 2023
Checking off #21029 since it was already QAed on staging - #21029 (comment)
OSBotify commentedon Jun 21, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.30-1🚀OSBotify commentedon Jun 21, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.30-1 has been deployed to staging 🎉
OSBotify commentedon Jun 21, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.30-2🚀luacmartins commentedon Jun 21, 2023
Checking off #21222. We merged and CPed a fix.
mvtglobally commentedon Jun 21, 2023
#20245 is failing #21210
#20560 is failing #21222
OSBotify commentedon Jun 21, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.30-2 has been deployed to staging 🎉
7 remaining items
luacmartins commentedon Jun 22, 2023
Checking off #21268 and #21277 since they are not actual blockers.
mvtglobally commentedon Jun 22, 2023
Regression is almost completed
PR #20245 is failing #21210 - Slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1687427798253009
PR #20467 validation in progress
PR #20560 is failing #21222 - Slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1687427892095629
PR #20687 validation in progress. & #21224 repro in prod
PR #20689 validation in progress. & #21280 repro in prod
PR #20889 validation in progress.
PR #20890 repro ki #17846. Checking off
PR #20895 validation in progress.
PR #20945 validation in progress.
PR #21043 validation in progress.
PR #21045 validation in progress.
PR #21094 validation in progress.
PR #21265 validation in progress.
mountiny commentedon Jun 22, 2023
Posted slack threads for the failing QAs https://expensify.slack.com/archives/C01GTK53T8Q/p1687427892095629
mvtglobally commentedon Jun 22, 2023
@luacmartins
Checking a few PRs plus
#20945 is blocked on all but Web. Web is Pass. Can we check it off?
Wrapping few last checks
mountiny commentedon Jun 22, 2023
Checking #20245 because the failing QA is not a blocker https://expensify.slack.com/archives/C01GTK53T8Q/p1687427798253009
mountiny commentedon Jun 22, 2023
@mvtglobally thanks, looks like web should be enough for that PR, I will check #20945 off
mvtglobally commentedon Jun 22, 2023
Down to last 3
PR #20560 is failing #21222 - Slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1687427892095629
PR #20689 has #21280 repro in prod. Checking off.
PR #21265 failing #21303
luacmartins commentedon Jun 22, 2023
Checking off #21283 since we demoted it from being a blocker - see https://expensify.slack.com/archives/C01GTK53T8Q/p1687390694872859
luacmartins commentedon Jun 22, 2023
Checking off #21309 since the fix is in Web-E
luacmartins commentedon Jun 22, 2023
@mvtglobally could you please post a summary of which PRs are pending/failed validation?
mvtglobally commentedon Jun 22, 2023
@luacmartins all done
Only unchecked this one
PR #20560 is failing #21222 - Slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1687427892095629
luacmartins commentedon Jun 22, 2023
Checked off #20560. I tested in staging and it's a pass.
luacmartins commentedon Jun 22, 2023
Checklist is clear. Kicking off the deploy.
luacmartins commentedon Jun 22, 2023