You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - Can send messages by clicking around the send button, outside the composer, and when the cursor is an arrow #23863
Go and click around the send button, ( and not the send button itself ), inside or outside the composer, when the cursor is still arrow
Expected Result:
Users shouldn’t be able to send messages when clicking around the send button (inside or outside the composer), and when the cursor is arrow.
He should be able to do that by clicking only on the button itself
Actual Result:
User can send messages by clicking around the send button ( inside or outside the composer ). and when the cursor is arrow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.47-3 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Can send messages by clicking around the send button, inside or outside the composer, and while the cursor is Arrow. While the user should be able to send messages by clicking the send button itself.
What is the root cause of that problem?
2 reasons cause that and they are related to the style of the Button Wrapper here
This button wrapper is square and it is the area that does sending actions by clicking on it, so it should be round to match the button itself and the right round side of the composer.
After making it around we now face another issue, it is the margin: 3 we added to the button
here https://github.com/Expensify/App/blob/main/src/styles/styles.js#L1669C1-L1677C7
which makes the button inside the wrapper (clickable area) by 3px of margin.
Those reasons lead to spaces (inside and outside the composer) where I can click to send messages, while they are not part of the button and the cursor is an arrow.
What changes do you think we should make in order to solve the problem?
To fix the first issue we should just make the wrapper round by adding this prop
Agree this might be a dupe of #23848@AndrewGable or @rushatgabhane can I get gut check on that? In which case we should close this one as the other issues was reported first
@adelekennedy I reported my issue on Slack first, while the other issue was reported here first. It's possible that they are two distinct issues. However, what matters most is that the problem was resolved, regardless of whether you addressed mine or the other one first. Thanks.
It looks like that other issue was reported later but made it into Slack earlier, I'll pay you the reporting bonus @Ahmed-Abdella in case we decide to close
Activity
melvin-bot commentedon Jul 29, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kbecciv commentedon Jul 29, 2023
Proposal by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690567101181809
or
to this
(https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose.js#L1235C1-L1250C1)
now the wrapper is round and matches the button (no clickable spaces around the corners)
by doing that we add the margin between the whole wrapper and the composer edges
NOTE:
Removing the
margin: 3property fromstyles.chatItemSubmitButtonaffect two other elements inside
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionItemMessageEdit.js
the cancel button here
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionItemMessageEdit.js#L279C21-L297C49
and the message edit button here
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionItemMessageEdit.js#L358C29-L372C53
so we should add this prop
to those components to keep everything consistent.
N/A
rushatgabhane commentedon Jul 29, 2023
not a bug imo. it's intended otherwise the pressable area would be too small
melvin-bot commentedon Jul 29, 2023
Current assignee @adelekennedy is eligible for the Bug assigner, not assigning anyone new.
melvin-bot commentedon Jul 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Ahmed-Abdella commentedon Jul 29, 2023
@rushatgabhane No it is not, as it is working just fine in production new dot
kbecciv commentedon Jul 29, 2023
@rushatgabhane It could be related to this KI #23848.
11 remaining items
Ahmed-Abdella commentedon Jul 31, 2023
Here are the screenshots that expalin my proposal above (it is all in the slack conversation)
adelekennedy commentedon Jul 31, 2023
Agree this might be a dupe of #23848 @AndrewGable or @rushatgabhane can I get gut check on that? In which case we should close this one as the other issues was reported first
Ahmed-Abdella commentedon Jul 31, 2023
@adelekennedy I reported my issue on Slack first, while the other issue was reported here first. It's possible that they are two distinct issues. However, what matters most is that the problem was resolved, regardless of whether you addressed mine or the other one first. Thanks.
adelekennedy commentedon Aug 2, 2023
It looks like that other issue was reported later but made it into Slack earlier, I'll pay you the reporting bonus @Ahmed-Abdella in case we decide to close
Ahmed-Abdella commentedon Aug 2, 2023
@adelekennedy Thanks, I appreciate your concern.
adelekennedy commentedon Aug 7, 2023
I'm making the call that this is a dupe - going to close this and pay you out @Ahmed-Abdella
adelekennedy commentedon Aug 7, 2023
@Ahmed-Abdella please apply here!
Ahmed-Abdella commentedon Aug 7, 2023
@adelekennedy Applied, Thanks
adelekennedy commentedon Aug 7, 2023
hired!
Ahmed-Abdella commentedon Aug 7, 2023
@adelekennedy I accepted the offer