Repository navigation
Deploy Checklist: New Expensify 2023-08-01 #24028
Description
Release Version: 1.3.49-0
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Setup App for TypeScript #20179
- fix: do not escape HTML special chars for an invite's welcomeNote #21912
- refactored BasePaymentsPage to function based component #22412
- Match Report Header and LHN Avatars #22467
- Update dynamically attachment modal #22543
- form: never have value prop for input as undefined #22589
- Reusable function instead of repetitive statements #22649
- Migrate BasePicker to function component #22788
- Use a single moderationDecision instead of the moderationDecisions array #22852
- Migrate FloatingMessageCounter to function component #22912
- Fix/19483 close anchor popup #23152
- [Step 1] Temporarily support both fundList and cardList ONYX keys #23242
- fix: 22058 delay in transitioning from hand cursor to now allowed sign #23336
- Remove unused Modal/index.js file #23462
- Fix console error when validating/unlinking secondary account #23469
- fix: header message for already invited member of workspace #23490
- [NoQA] Replace the moment library with date-fns: Add library, add tests #23520
- Hide All Muted Chats #23521
- Append current time to the downloaded file name #23531
- fix crash when trying to unlink secondary contact #23561
- remove first request #23562
- Migrate DragNDrop #23589
- fix: show main composer when there is no focused draft #23618
- Fix wrong last accessed report #23625
- Fix: hide draft icon when composer hides #23641
- Only render ReportActionItemReactions if there are reactions #23671
- Fix bankAccountID not being passed on manual BA connect #23677
- Remove blue border from Ondifo buttons on hover #23699
- Use stateNum to determine report state #23700
- Fix report total update #23701
- fix: Select and copy does not copy New Expensify link in link format #23704
- Fix workspace icon border radius is different than the overlay #23707
- Fixed offline Android overlapping icons #23710
- Fix "Deleted message" chat appears in chat list for pinned deleted threads #23715
- Fix/21929 - Hide context menu from LHN window resize #23728
- Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734
- [NoQA] Perf/onyx upgrade use cache directly #23749
- Feature : Improve display of error message on AvatarWithImagePicker #23754
- fix redundant api call on priority page #23772
- use getIconsForParticipants for icons in getAssignee in Task #23773
- Upload optimized lottie JSON files #23776
- Parent Message of thread chat on LHN doesn't updated when the parent message is updated #23777
- Fix: Wrong translation of
paidin LHN after deleting last message #23778 - Corrected regression from issue 21838 #23780
- Fix reaction appears for deleted message #23782
- [CP Staging] Open modal when signing out only when user is offline #23790
- Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815
- fixed navigateToAddPaypalRoute issue #23816
- Return null for native Drag and Drop consumers to prevent Drag UI on native #23829
- Fix FullPageNotFoundView in ReimbursementAccountPage #23843
- Fix empty workspace name in money requests confirmation page #23844
- fix: 23811 handle mentions renderer not receiving props #23845
- Refactor
EmojiPickerMenunative to functional component and usingscrollTomethod #23854 - fix: add no dropzone only if RHN is active #23856
- Migrated Switch to function component syntax #23857
- Migrate withDelayToggleButtonState.js to function component #23860
- Fix: Long emoji names are not being truncated and icons displayed at the start #23878
- migrated ScrollViewWithContext to a functional component #23879
- Prevent user from visiting archived room setting #23907
- [23304] Update tasks status color. #23912
- Update Onfido SDK to 13.1.0 #23915
- [CP Staging] Disallow deleting split actions #23916
- fix: disable confirm button if offline #23917
- gray out date for settled money requests in MoneyRequestView #23927
- Card rev shareExpensifyHelp page. #23975
- request money open workspace details when selected workspace clicked. #23980
- Onfido SDK: Remove the deprecated
uploadFallbackprop #23983 - [CP Staging] Remove reference to missing method #24010
- Revert "fix: show main composer when there is no focused draft" #24025
Deploy Blockers:
- [HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA #24005
- Bank account - Something went wrong error message when connecting to bank account #24063
- [HOLD for payment 2023-08-24] [$1000] Workspace - The border radius of the workspace icon and the overlay are not the same #24069
- Download - Appended time to downloaded file name is not following local time #24077
- [HOLD for payment 2023-08-10] Avatar style is broken in anonymous footer #24085
- [$1000] [HOLD for payment 2023-08-14] Dev: Offline Indicator duplicate #24092
- Dev: Mark as unread not working when request money for workspace #24112
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Aug 2, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.49-0 🚀
Beamanator commentedon Aug 2, 2023
Created new section
PRs from old checklists that shouldn't be here (https://github.com/Expensify/App/issues/23368):for PRs that were already tested on previous checklists & are now in production & I checked them off (as discussed internally here)puneetlath commentedon Aug 2, 2023
Checking off #24005. It was handled yesterday, we just never removed the label.
hayata-suenaga commentedon Aug 2, 2023
Checking off #24063 the fix pr has been cherry picked
Li357 commentedon Aug 2, 2023
Checking off #24077 because there is agreement this isn't really an issue.
mvtglobally commentedon Aug 3, 2023
#23531 is failing #24077
#23707 is failing #24069
Beamanator commentedon Aug 3, 2023
#24069 marked NAB, checking it off & associated PR, #23707
Beamanator commentedon Aug 3, 2023
Checking off #24092 b/c it was fixed by #24097
mvtglobally commentedon Aug 3, 2023
@Beamanator Regression is completed
Summary
#22467 is failing #24105
#22912 is failing with old KI ttps://github.com/Expensify/App/issues/12249. Ok to check off?
#23531 is failing #24077
#23707 is failing #24069
#23915 is failing #24063
#23983 blocked on web/mWeb,Desktop due to #24063 , ok to check off?
#23975 is PROD QA, ok to check off?
Beamanator commentedon Aug 3, 2023
Thanks @mvtglobally ! Just checking, it looks like there's 3 untested tests in testrail - https://expensify.testrail.io/index.php?/plans/view/16715
Beamanator commentedon Aug 3, 2023
Checking off #24112 since workspace chats are still in beta
mvtglobally commentedon Aug 3, 2023
@Beamanator We are done. These were duplicates. Updated
Beamanator commentedon Aug 3, 2023
#22912 can be checked off since it's only failing the super old bug: #12249
#24105 is supposedly reproducible in production, so we can check off #22467
#23531 can be checked off b/c #24077 was closed and marked not something we need to fix
#23707 can be marked off b/c #24069 was marked not a blocker
#23915 can be marked off b/c #24063 was fixed by #24036 & it was CP'd
@mvtglobally is it possible to get #23983 re-tested due to the fix that went in place yesterday ^?
@mvtglobally are help pages always prod QA? (for #23975)
Beamanator commentedon Aug 3, 2023
Help sites deploy immediately apparently, so checked #23975 and it looks good on the help site
mvtglobally commentedon Aug 3, 2023
@Beamanator
retesting #23983
and Yes, we usually check off Help pages
Beamanator commentedon Aug 3, 2023
Amazing, thank you 🙏
Beamanator commentedon Aug 3, 2023
@mvtglobally looks like the last deploy blocker fix is on staging now, so we're just waiting on the retest of #23983 ! 👍
Beamanator commentedon Aug 3, 2023
Checking off #24085 b/c fix is on staging & passing!
mvtglobally commentedon Aug 3, 2023
@Beamanator #23983
its pass on Web, Native apps.. validating mWeb and Desktop now
mvtglobally commentedon Aug 3, 2023
@Beamanator We are done, checked off
Beamanator commentedon Aug 3, 2023