You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Remove Safari workaround to fix attachment picker issue #24297
In #19011 we added in a workaround for Safari's specific behavior for pop-ups and actions, because they always have to be triggered by a user action. This works, but is probably not ideal. Let's figure out a way to improve it!
Okay, if all of our possibilities are really just replacing one workaround with another (which I understand), I think we might be okay to just close this issue, and not complete. What do you think?
Okay, if all of our possibilities are really just replacing one workaround with another (which I understand), I think we might be okay to just close this issue, and not complete. What do you think?
We will be replacing workarounds with some other workaround. So, I agree on closing the issue.
Activity
melvin-bot commentedon Aug 8, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 8, 2023
melvin-bot commentedon Aug 9, 2023
Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Aug 9, 2023
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)twisterdotcom commentedon Aug 9, 2023
Doesn't need designing.
22 remaining items
dangrous commentedon Aug 16, 2023
Okay, if all of our possibilities are really just replacing one workaround with another (which I understand), I think we might be okay to just close this issue, and not complete. What do you think?
alex2bc commentedon Aug 16, 2023
I'd say that with this PR, we can replace two workarounds, one of which causes the other, with a single, more appropriate one for this problem
sobitneupane commentedon Aug 18, 2023
We will be replacing workarounds with some other workaround. So, I agree on closing the issue.
twisterdotcom commentedon Aug 18, 2023
Apologies but I am finally going on Parental Leave. I am reassigning to another member of the team. But I also agree, we should close.
melvin-bot commentedon Aug 18, 2023
Triggered auto assignment to @JmillsExpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Aug 18, 2023
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)dangrous commentedon Aug 18, 2023
Thanks! closing makes sense.
jeet-dhandha commentedon Aug 22, 2023
I already tested this it works 👍 fine.