Skip to content

[$1000] Remove Safari workaround to fix attachment picker issue #24297

Closed

Description

@dangrous

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


In #19011 we added in a workaround for Safari's specific behavior for pop-ups and actions, because they always have to be triggered by a user action. This works, but is probably not ideal. Let's figure out a way to improve it!

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ce38317e6e2f0866
  • Upwork Job ID: 1689306743240826880
  • Last Price Increase: 2023-08-16

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 8, 2023
  2. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 8, 2023

    @melvin-bot
  4. added
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 9, 2023
  5. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

  6. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  7. twisterdotcom commented on Aug 9, 2023

    @twisterdotcom
    Contributor

    Doesn't need designing.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 9, 2023
  9. 22 remaining items

  10. dangrous commented on Aug 16, 2023

    @dangrous
    ContributorAuthor

    Okay, if all of our possibilities are really just replacing one workaround with another (which I understand), I think we might be okay to just close this issue, and not complete. What do you think?

  11. alex2bc commented on Aug 16, 2023

    @alex2bc
    Contributor

    I'd say that with this PR, we can replace two workarounds, one of which causes the other, with a single, more appropriate one for this problem

  12. sobitneupane commented on Aug 18, 2023

    @sobitneupane
    Contributor

    Okay, if all of our possibilities are really just replacing one workaround with another (which I understand), I think we might be okay to just close this issue, and not complete. What do you think?

    We will be replacing workarounds with some other workaround. So, I agree on closing the issue.

  13. twisterdotcom commented on Aug 18, 2023

    @twisterdotcom
    Contributor

    Apologies but I am finally going on Parental Leave. I am reassigning to another member of the team. But I also agree, we should close.

  14. added
    NewFeatureSomething to build that is a new item.
    and removed
    NewFeatureSomething to build that is a new item.
    on Aug 18, 2023
  15. melvin-bot commented on Aug 18, 2023

    @melvin-bot
  16. melvin-bot commented on Aug 18, 2023

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  17. dangrous commented on Aug 18, 2023

    @dangrous
    ContributorAuthor

    Thanks! closing makes sense.

  18. jeet-dhandha commented on Aug 22, 2023

    @jeet-dhandha
    Contributor

    Thanks for the update @jeet-dhandha.

    But probably, your solution will resurface #19310 issue. And also, it looks like a workaround.

    I already tested this it works 👍 fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions