You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages #25644
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Yes, the prod behavior is correct, the stg behavior definitely is not. Though, I'm trying to find which particular change introduced the issue as observed: #25625
changed the title [-]Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/-][+][HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/+]on Aug 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.shubham1206agra commentedon Aug 22, 2023
Hey
Can you confirm that current prod behaviour is correct?
robertjchen commentedon Aug 22, 2023
Yes, the
prodbehavior is correct, thestgbehavior definitely is not. Though, I'm trying to find which particular change introduced the issue as observed: #25625shubham1206agra commentedon Aug 22, 2023
Found it #24235
shubham1206agra commentedon Aug 22, 2023
See
BaseHTMLEngineProvider.jsrobertjchen commentedon Aug 22, 2023
@shubham1206agra Thanks! If you have a proposal for a fix, I can mark as
Externaland we can get it reviewed 👍shubham1206agra commentedon Aug 22, 2023
Wait
I will post it a little later (little busy rn)
robertjchen commentedon Aug 22, 2023
Actually, I just saw that they were considering reverting the PR that introduced this along with the other issues. #24235 (comment)
shubham1206agra commentedon Aug 22, 2023
Yes
But I think most of the bug stated there can be fixed easily
6 remaining items
shubham1206agra commentedon Aug 22, 2023
F
@Li357 Feel free to ask for help
melvin-bot commentedon Aug 22, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon Aug 23, 2023
No longer repro in staging, fixed
Internal reporter so closing
[-]Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/-][+][HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/+]melvin-bot commentedon Aug 28, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: