Skip to content

[HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages #25644

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open iOS App and login with any account
  2. Create new workspace or open existing WS
  3. Send some messages in #announce room
  4. Delete this workspace
  5. Open archived #announce chat

Expected Result:

The message that the 'WS chat is closed' is at the bottom of the screen. All previously sent messages are visible

Actual Result:

The message that the WS chat is closed is expanded to full screen even if there were messages in the chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6172890_T3606025-Closed-chat-message-full-screen.mp4

Bug6172890_T3606025-Closed-chat-message-production

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Hey
    Can you confirm that current prod behaviour is correct?

  4. robertjchen commented on Aug 22, 2023

    @robertjchen
    Contributor

    Yes, the prod behavior is correct, the stg behavior definitely is not. Though, I'm trying to find which particular change introduced the issue as observed: #25625

  5. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Found it #24235

  6. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    See BaseHTMLEngineProvider.js

  7. robertjchen commented on Aug 22, 2023

    @robertjchen
    Contributor

    @shubham1206agra Thanks! If you have a proposal for a fix, I can mark as External and we can get it reviewed 👍

  8. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Wait
    I will post it a little later (little busy rn)

  9. robertjchen commented on Aug 22, 2023

    @robertjchen
    Contributor

    Actually, I just saw that they were considering reverting the PR that introduced this along with the other issues. #24235 (comment)

  10. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    Yes
    But I think most of the bug stated there can be fixed easily

  11. 6 remaining items

  12. shubham1206agra commented on Aug 22, 2023

    @shubham1206agra
    Contributor

    F
    @Li357 Feel free to ask for help

  13. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. mountiny commented on Aug 23, 2023

    @mountiny
    Contributor

    No longer repro in staging, fixed

    IMG_9E55E02F6538-1

    Internal reporter so closing

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2023
  16. changed the title [-]Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/-] [+][HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages[/+] on Aug 28, 2023
  17. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions