Skip to content

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Description

@OSBotify

Release Version: 1.3.56-24
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. mountiny commented on Aug 21, 2023

    @mountiny
    Contributor

    #23626 this is from previous deploy

  2. OSBotify commented on Aug 21, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.56-0 🚀

  3. roryabraham commented on Aug 22, 2023

    @roryabraham
    Contributor

    Unlocking this because staging deploys are broken. We hopefully fixed them but need to trigger a full deploy from main. Slack context: https://expensify.slack.com/archives/C03V9A4TB/p1692661899493529

  4. roryabraham commented on Aug 22, 2023

    @roryabraham
    Contributor

    New staging deploy running here, re-locking this checklist.

  5. OSBotify commented on Aug 22, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.56-2 🚀

  6. deleted a comment from melvin-bot on Aug 22, 2023
  7. sakluger commented on Aug 22, 2023

    @sakluger
    Contributor

    @roryabraham I went through the list of blockers and categorized them by status to help you out a bit! 🆗 means that the deployblocker label was removed (I checked these off above). ✔️ means that the linked PR was merged (I'm not sure if it's okay to check these off above yet). 📋 means that there is a PR in review but not merged. ❗ means that the issue either has no PR yet or is unassigned.

    🆗 #25481 - Likely fixed, deploy blocker label removed
    ✔️ #25616 - PR merged
    🆗 #25626 - NAB
    🆗 #25637 - NAB (dupe of another issue)
    ✔️ #25640 - PR merged
    📋 #25644 - PR merged
    🆗 #25647 - NAB
    ✔️ #25648 - PR merged
    📋 #25649 - PR in review
    ✔️ #25650 - PR merged
    ❗ #25673 - No PR
    📋 #25674 - PR in review
    ❗#25676 - No PR
    #25678 - PR merged
    📋 #25679 - Draft PR
    🆗 #25680 - NAB
    🆗 #25683 - Closed
    ❗#25685 - No PR
    ❗#25686 - No PR
    ❗#25688 - No PR
    ❗#25690 - No PR, unable to repro in DEV
    🆗 #25692 - NAB
    ❗#25694 - No PR
    ❗#25696 - No PR
    ❗#25697 - No PR
    ❗#25698 - No PR
    ❗#25705 - No PR

  8. 34 remaining items

  9. marcaaron commented on Aug 23, 2023

    @marcaaron
    Contributor

    Demoting #25779. edge case issue imo and not a common flow people would typically be running into.

  10. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    #24577 is a QA fail but not a blocker. Left a comment requesting more details in the PR

  11. marcaaron commented on Aug 23, 2023

    @marcaaron
    Contributor

    We can check off #25768 after the CP from @dangrous. But we now have #25797 to look at 😄

  12. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    #25399 is a QA fail but not a deploy blocker, checking it off

  13. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    Checking off #25506 as a dupe of #24306

  14. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    As @marcaaron mentioned, #25789 caused another deploy blocker, but we're going to resolve it separately so I'm checking #25789 off

  15. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    Demoting #25787

  16. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    Demoting #25803 and checking it off

  17. roryabraham commented on Aug 23, 2023

    @roryabraham
    Contributor

    #25673 is not reproducible and ultimately a somewhat minor bug that doesn't affect usability. Demoting it and checking it off

  18. marcaaron commented on Aug 23, 2023

    @marcaaron
    Contributor

    Internal QA on #24637 ✅

  19. roryabraham commented on Aug 24, 2023

    @roryabraham
    Contributor

    #25797 is passing on staging now ✅ , checking it off along with #25799

  20. roryabraham commented on Aug 24, 2023

    @roryabraham
    Contributor

    #25688 is passing on staging now ✅, checking it off along with #25806

  21. roryabraham commented on Aug 24, 2023

    @roryabraham
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions