Repository navigation
Hide Overflow of Google Signin Button [DEPLOY BLOCKER] - #25789
Conversation
situchan
left a comment
There was a problem hiding this comment.
Code looks good. Testing shortly
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-08-23.at.1.03.35.PM.movMobile Web - ChromeScreen.Recording.2023-08-23.at.1.04.46.PM.movMobile Web - SafariScreen.Recording.2023-08-23.at.1.05.36.PM.movDesktopScreen.Recording.2023-08-23.at.1.08.02.PM.moviOSproblems with emulator but straightforward fix and working on original post Androidproblems with emulator but straightforward fix and working on original post |
Screenshots/VideosWebBefore fixScreen.Recording.2023-08-23.at.11.04.30.PM.movAfter fixScreen.Recording.2023-08-23.at.11.05.38.PM.moviOSScreen.Recording.2023-08-23.at.11.10.43.PM.movAndroidScreen.Recording.2023-08-23.at.11.14.18.PM.mov |
|
@srikarparsi I am adding iOS and android videos for you |
|
cool thank you! |
|
Awesome thanks! Merging |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Hide Overflow of Google Signin Button [DEPLOY BLOCKER] (cherry picked from commit f32b695)
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.56-21 🚀
|
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.56-21 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀
|
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.58-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀
|
Details
For testing you'll need to update this line to show the buttons on dev
This will stop the button from jumping on Safari. There is still a tiny bit of weirdness with the button, but it should not prevent deploying and we will make a following issue to fix that - it is barely noticeable on Mac Safari and not noticeable on other platforms.
Fixed Issues
$ #25768
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
This only affects the web view so only screenshotted those.
Web
safari.mp4
chrome.mp4
Mobile Web - Chrome
Android.Chrome.mp4
Mobile Web - Safari
iosSafari.mp4
Desktop
iOS
Android