Skip to content

Enable copy/pasting all content on web #260

Closed

Description

@quinthar

For some reason, any content that has basically any markdown transformation (formatting, link, etc) seems "invisible" to text selection. Consider this:

image

I just dragged my mouse from the middle of "repo" to the middle of "interesting", and see how it skipped over the two posts containing links? What's up with that? Let's make sure all our content is copy-pastable

Activity

  1. self-assigned this
    on Aug 20, 2020
  2. Julesssss commented on Aug 20, 2020

    @Julesssss
    Contributor

    Need to work out why user-select: none is being set.

  3. Julesssss commented on Aug 20, 2020

    @Julesssss
    Contributor

    On a related note, on mobile we are unable to copy any text.

  4. mallenexpensify commented on Aug 24, 2020

    @mallenexpensify
    Contributor

    @Julesssss will copy/paste for web also work on the desktop app? It's currently not possible to do so and I imagine we'll want it

  5. Julesssss commented on Aug 25, 2020

    @Julesssss
    Contributor

    @mallenexpensify I'll take a look at that too, agree that it should work on all platforms

  6. jboniface commented on Aug 28, 2020

    @jboniface
  7. mallenexpensify commented on Aug 28, 2020

    @mallenexpensify
    Contributor

    I think this should be high because it 'doesn't work', there's no way to copy the text and if you're wanting to quote something another person said, it's not possible and there's often no work around (meaning... if you see the message in Chat you won't get an email so you can't copy/paste from there)

  8. jboniface commented on Aug 28, 2020

    @jboniface

    That's fair honestly. Let's bump it up.

  9. cead22 commented on Sep 3, 2020

    @cead22
    Contributor

    This ruins the whole DM experience, and the work around for when there's bugs. I was going to copy something and paste on slack to work around a message not being visible on Tim's side, and couldn't. Labeling Critical

  10. tgolen commented on Sep 3, 2020

    @tgolen
    Contributor

    This looks like it only affects comments that have a URL in them. I can select text from all other comments.

  11. jboniface commented on Sep 3, 2020

    @jboniface

    It looks like it affects any comment with any kind of formatting in it (i just tried with a comment that has no link but bold text)

  12. jboniface commented on Sep 3, 2020

    @jboniface

    Actually, scratch that, it seems totally random to me lol

  13. mallenexpensify commented on Sep 3, 2020

    @mallenexpensify
    Contributor

    I haven't found any rhyme or reason to why some are and others aren't. I feel like it's frequently comments I've left that I can't copy but that could just be the comments I want to copy most.

  14. AndrewGable commented on Sep 3, 2020

    @AndrewGable
    Contributor

    It looks like <Text> has a selectable prop that should fix this

  15. Julesssss commented on Sep 4, 2020

    @Julesssss
    Contributor

    @AndrewGable components are already selectable and the issue requires us to make our text selectable.

    We're using react-native-render-html, which has a textSelectable prop, which seems to be the best solution.

  16. Julesssss commented on Sep 4, 2020

    @Julesssss
    Contributor

    Although, selectable could be a solution for mobile text selection 👍

  17. Julesssss commented on Sep 4, 2020

    @Julesssss
    Contributor

    HTML content is now selectable on all platforms. Regular text is also now selectable on mobile, with one exception: users are unable to select text from multiple lines -- looking into this a bit further before submitting for review.

    (PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ReviewingHas a PR in review

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions