Skip to content

Make all text selectable - #407

Merged
sketchydroide merged 3 commits into
masterfrom
jules-selectable-html-text
Sep 8, 2020
Merged

sketchydroide merged 3 commits into
masterfrom
jules-selectable-html-text

Conversation

@Julesssss

@Julesssss Julesssss commented Sep 4, 2020 •

Copy link
Copy Markdown
Contributor

Fixes: #260

  • Make HTML comments selectable on all platforms to allow copy/paste.
  • Make regular text comments selectable on mobile

@Julesssss Julesssss self-assigned this Sep 4, 2020
@Julesssss
Julesssss marked this pull request as ready for review September 4, 2020 16:31
@Julesssss
Julesssss requested a review from a team September 4, 2020 16:45
@botify
botify requested review from sketchydroide and removed request for a team September 4, 2020 16:45

@sketchydroide sketchydroide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Julesssss
Julesssss marked this pull request as draft September 7, 2020 10:58
@sketchydroide

Copy link
Copy Markdown
Contributor

Hey @Julesssss this still seem to be in draft, do you wan to make it ready for review?

@Julesssss

Copy link
Copy Markdown
Contributor Author

@sketchydroide need to make a final check, will give you a heads up once it's ready

@sketchydroide

Copy link
Copy Markdown
Contributor

Sorry mate, but can you add the [WIP] to the title, just makes it clear while looking at my K2

@Julesssss Julesssss changed the title Make HTML text selectable [WIP] Make HTML text selectable Sep 8, 2020
@Julesssss

Copy link
Copy Markdown
Contributor Author

Sure, done

@Julesssss
Julesssss marked this pull request as ready for review September 8, 2020 14:41
@Julesssss

Copy link
Copy Markdown
Contributor Author

Not making any further changes, feel free to merge @sketchydroide 👍

@Julesssss Julesssss changed the title [WIP] Make HTML text selectable Make HTML text selectable Sep 8, 2020
@Julesssss Julesssss changed the title Make HTML text selectable Make all text selectable Sep 8, 2020

@sketchydroide sketchydroide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@sketchydroide
sketchydroide merged commit ff11e49 into master Sep 8, 2020
@sketchydroide
sketchydroide deleted the jules-selectable-html-text branch September 8, 2020 15:21
@mallenexpensify

Copy link
Copy Markdown
Contributor

This appears to be fixed to me, I've tested a few times on Desktop today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable copy/pasting all content on web

3 participants