You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name #26275
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] FAB - Symbols are allowed in legal name[/-][+][HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name[/+]on Sep 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@parasharrajatdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Reporter: @daveSeife $50 (hired and paid via Upwork)
Contributor: @dukenv0307 $750 (hired and paid via Upwork)
Contributor+: @parasharrajat $750 (payable via Manual Request after BZ checklist is completed)
Above payments include efficiency bonus 🎉
@parasharrajat can you please finish the BZ checklist? Thanks!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Login with any account
Go to FAB > Save the world
Click on I Know a teacher
Enter the firstName input with a symbol character i.e. + and blur the input
Do the same with lastName input
Verify that the error Name can only include letters appears.
Activity
dukenv0307 commentedon Aug 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Symbols are allowed in legal name
What is the root cause of that problem?
We only show the error if the name is empty
App/src/pages/TeachersUnite/KnowATeacherPage.js
Lines 67 to 72 in 6e17b64
What changes do you think we should make in order to solve the problem?
We can re-use
ValidationUtils.isValidLegalNameto validate symbol characters and then set the error asName can only include lettersApp/src/pages/TeachersUnite/KnowATeacherPage.js
Lines 67 to 72 in 6e17b64
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Aug 30, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 30, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 30, 2023
Triggered auto assignment to @madmax330 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.madmax330 commentedon Aug 30, 2023
@marcochavezf assigning you since you see to be handling the teacher's thing.
41 remaining items
[-][$500] FAB - Symbols are allowed in legal name[/-][+][HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name[/+]melvin-bot commentedon Sep 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Sep 14, 2023
Summarizing payouts for this issue:
Reporter: @daveSeife $50 (hired and paid via Upwork)
Contributor: @dukenv0307 $750 (hired and paid via Upwork)
Contributor+: @parasharrajat $750 (payable via Manual Request after BZ checklist is completed)
Above payments include efficiency bonus 🎉
@parasharrajat can you please finish the BZ checklist? Thanks!
parasharrajat commentedon Sep 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
Name can only include lettersappears.Do you agree 👍 or 👎 ?
sakluger commentedon Sep 18, 2023
Looks good, thanks!
parasharrajat commentedon Nov 6, 2023
Payment requested as per #26275 (comment)
JmillsExpensify commentedon Nov 10, 2023
$750 payment approved for @parasharrajat based on summary above.