Skip to content

[HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name #26275

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on FAB
  2. Click Save the World > I Know a teacher
  3. Enter any symbol in the First and Last name field

Expected Result:

'Name can only include letters' Error is thrown

Actual Result:

No error is thrown. and allows to save

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.59-0

Reproducible in staging?: Y

Reproducible in production?: New feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (21)

image

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693365548751779

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01572957e06c2a6850
  • Upwork Job ID: 1697237710114856960
  • Last Price Increase: 2023-08-31
  • Automatic offers:
    • daveSeife | Reporter | 26432445
    • dukenv0307 | Contributor | 26432463

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 30, 2023
  2. dukenv0307 commented on Aug 30, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Symbols are allowed in legal name

    What is the root cause of that problem?

    We only show the error if the name is empty

    if (_.isEmpty(values.firstName)) {
    ErrorUtils.addErrorMessage(errors, 'firstName', translate('bankAccount.error.firstName'));
    }
    if (_.isEmpty(values.lastName)) {
    ErrorUtils.addErrorMessage(errors, 'lastName', translate('bankAccount.error.lastName'));
    }

    What changes do you think we should make in order to solve the problem?

    We can re-use ValidationUtils.isValidLegalName to validate symbol characters and then set the error as Name can only include letters

    if (!ValidationUtils.isValidLegalName(values.firstName)) {
        errors.legalFirstName = 'new translation'; // Invalid characters error
    } else if (_.isEmpty(values.firstName)) {
        errors.legalFirstName = 'common.error.fieldRequired';
    }
    
    if (!ValidationUtils.isValidLegalName(values.lastName)) {
        errors.legalLastName = 'new translation'; // Invalid characters error
    } else if (_.isEmpty(values.lastName)) {
        errors.legalLastName = 'common.error.fieldRequired';
    }
    

    if (_.isEmpty(values.firstName)) {
    ErrorUtils.addErrorMessage(errors, 'firstName', translate('bankAccount.error.firstName'));
    }
    if (_.isEmpty(values.lastName)) {
    ErrorUtils.addErrorMessage(errors, 'lastName', translate('bankAccount.error.lastName'));
    }

    What alternative solutions did you explore? (Optional)

  3. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. OSBotify commented on Aug 30, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. madmax330 commented on Aug 30, 2023

    @madmax330
    Contributor

    @marcochavezf assigning you since you see to be handling the teacher's thing.

  8. removed their assignment
    on Aug 30, 2023
  9. 41 remaining items

  10. changed the title [-][$500] FAB - Symbols are allowed in legal name[/-] [+][HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name[/+] on Sep 5, 2023
  11. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. sakluger commented on Sep 14, 2023

    @sakluger
    Contributor

    Summarizing payouts for this issue:

    Reporter: @daveSeife $50 (hired and paid via Upwork)
    Contributor: @dukenv0307 $750 (hired and paid via Upwork)
    Contributor+: @parasharrajat $750 (payable via Manual Request after BZ checklist is completed)

    Above payments include efficiency bonus 🎉

    @parasharrajat can you please finish the BZ checklist? Thanks!

  15. parasharrajat commented on Sep 15, 2023

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Login with any account
    2. Go to FAB > Save the world
    3. Click on I Know a teacher
    4. Enter the firstName input with a symbol character i.e. + and blur the input
    5. Do the same with lastName input
    6. Verify that the error Name can only include letters appears.

    Do you agree 👍 or 👎 ?

  16. sakluger commented on Sep 18, 2023

    @sakluger
    Contributor

    Looks good, thanks!

  17. parasharrajat commented on Nov 6, 2023

    @parasharrajat
    Member

    Payment requested as per #26275 (comment)

  18. JmillsExpensify commented on Nov 10, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @parasharrajat based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions