Repository navigation
[New Feature] - Teachers Unite sign-up flows - #23063
Conversation
…into teachersUniteFlow
…into teachersUniteFlow
…into teachersUniteFlow
…into teachersUniteFlow
|
hey @shawnborton Im adding scale animation on this new feature (PR) but will be needing the below things
https://user-images.githubusercontent.com/6829422/255213745-91490edc-07cc-42f5-b960-2a17a8e21348.svg
https://user-images.githubusercontent.com/6829422/255213729-effcc834-952f-4476-b187-15d31007ada5.svg |
|
Here is the email address svg: empty-state__emailaddress.svg.zip Will work on getting the animation over to you, too. |
|
alright, thnx will add both and also I do need that red color hex to be used here @shawnborton :) |
|
The color is |
|
Yes please. |
|
@dhairyasenjaliya suggested the changes |
|
Will add changes now |
|
Running checklist... |
|
@parasharrajat you might wanna use these values if you'd like to test on staging: As the new values haven't been deployed yet. |
|
@dhairyasenjaliya any update on the checklist please? |
|
yup performing soon will get it done |
youssef-lr
left a comment
There was a problem hiding this comment.
LGTM and tested well!
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.59-0 🚀
|
|
I got this deploy blocker which does not feel like a deploy blocker and the expected flow. I think the QA steps could be more specific and descriptive and that's why it made our QA team to get confused. @youssef-lr @dhairyasenjaliya Can someone confirm? |
|
@pecanoro not an bug it's expected user need to have non public domain to continue safe to close that issue |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
| (values) => { | ||
| const errors = {}; | ||
|
|
||
| if (_.isEmpty(values.firstName)) { |
There was a problem hiding this comment.
We should use proper isLegalName validation for this otherwise random values can be used. #26275
|
You forgot to properly link new contact page, which led to #31895. |


Details
New Feature
Fixed Issues
$ #22857
PROPOSAL: #22857 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Desktop.knowsTeacher.mov
Desktop.ImAteacher.mov
Mobile Web - Chrome
mWeb.ImATeacher.mov
mWeb.KnowATeacher.mov
Mobile Web - Safari
mWeb.ImATeacher.mov
mWeb.KnowATeacher.mov
Desktop
https://github.com/Expensify/App/assets/47522946/8ecf0f14-0f20-4331-9d3c-58c840126c58Desktop.ImAteacher.mov
iOS
https://github.com/Expensify/App/assets/47522946/a6150b4c-1b42-4500-b357-3ca49823eb5biOS.Im.teacher.mp4
Android
android.knowATeacher.mov
android.imTeacher.mov