Skip to content

Deploy Checklist: New Expensify 2023-08-31 #26359

Closed

Description

@OSBotify

Release Version: 1.3.60-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on Aug 31, 2023
  2. OSBotify commented on Aug 31, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.60-1 🚀

  3. roryabraham commented on Aug 31, 2023

    @roryabraham
    Contributor

    I see why this is happening. It's a race condition between:

    1. createNewStagingDeployCash
    2. deployStaging

    Both are triggered at the same time after updateStaging finishes. If deployStaging finishes (i.e: the tag for the new staging version is pushed to the remote) before the checklist is created, then it works. If not, then we get a huge checklist like this will all the PRs that were deployed in the previous version.

    Obviously not good, will need to fix this ASAP.

  4. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checking off #26413. Demoted to NAB since it happens in prod.

  5. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checking off #26421. Not one of our officially supported platforms. Demoted to NAB

  6. mvtglobally commented on Aug 31, 2023

    @mvtglobally

    @luacmartins Regression is completed

    #25971 is blocked on Native apps as we cant upload PDF. Ok to check off?
    #26022 is failing #26407
    Can we check this one off?

  7. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checking off #26407. Happens in prod.

  8. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checking off #26417 - we merged and CPed a fix.

  9. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checking off #26441. Demoted to NAB.

  10. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Checklist is clear. Just waiting for the final 2 CPs to finish and test them in staging and then we're good to go.

  11. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    Ok, CPs are done and they are a pass on staging. Shipping it.

  12. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions