Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.60-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Handle Plaid events like secure does #20747
- allow Request money 'Description' to accept multiline #21664
- [navigation-refactor] Style based approach for the three pane layout #22437
- 23298 - Desktop - Unable to move click>dragging the header in desktop app #24098
- fix: 23886 Composer out focus when the thread has many messages #24369
- Comment linking redirects #24411
- [NO QA] Improve app launcher icon padding #24440
- Rewrite CompanyStep.js to functional component #24616
- fix: show existing reports while loading #25159
- Fix some storybook errors #25520
- [23543] Multi words zones now work while searching for timezones. #25569
- fix - Translate IOU contents to the correct langauage #25629
- Fix: Big number pad button size is not justified on small screens #25656
- Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform #25721
- Simplify logic for getTransactionsWithReceipts #25731
- Added Condition to check drag & drop works only on scan page #25750
- Added Fill props to both component #25751
- fix: use correct title key for waypoint editor #25808
- fix: handle forward-delete properly in the amount text input #25815
- [No QA] [TS migration] Migrate textUnderline style to TypeScript #25821
- [No QA] [TS migration] Migrate 'editedLabelStyles' style to TypeScript #25919
- fix: change styles for the requestee #25952
- Create Insights Help page #25954
- DRY iou prop types and default props #25961
- Load generic receipt thumbnail for other file formats #25969
- Show max of three receipts in report preview #25971
- Show recent waypoints when selecting address for distance request #25974
- Add option to delete stop #25984
- feat: fix the janky request money tab swipe on web #26022
- Fix Back button is overlapping with notification bar on mobile devices #26035
- [TS migration] Migrate 'positioning.js' style to TypeScript #26056
- Remove MakeCancellablePromise.js #26095
- [No QA][TS migration] Migrate
CardUtils.jslib to TypeScript #26100 - [TS migration] Migrate 'getModalStyles' style to TypeScript #26105
- [No QA][TS migration] Migrate 'useNativeDriver' lib to TypeScript #26109
- [CP Staging] Modified buildTransactionThread function to accept requestReportID #26118
- Allow international address search #26122
- [No QA] fix: lint error for recent waypoints #26124
- fix: keep consistency with backend email validation #26145
- Fix sign in top content scroll conflict with the sign in page #26150
- remove extra padding for paypal button #26153
- [No QA] [TS migration] Migrate 'getPlaidOAuthReceivedRedirectURI' lib to TypeScript #26163
- [No QA] [TS migration] Migrate 'getClickedTargetLocation' lib to TypeScript #26168
- Don't show the Download App Banner until Past Sign in #26182
- Fix/25589: Return lastMessageText and lastMessageText when last message is an attachment #26194
- [No QA] [TS migration] Migrate 'ComponentUtils' lib to TypeScript #26199
- Revert "Fix different grayness levels on parent and child messages." #26211
- [CP stag] 26193-Attachment- Uploading PDF displays error #26218
- Fix null reports #26257
- fix crash when clicking UP key from keyboard after requesting money #26265
- fix crash when using the on-screen numpad caused by improperly set prop #26267
- [No QA] Make GitUtils.getPullRequestsMergedBetween return an array of nums intsead of strings #26297
- Disallow leaving policy expense chats #26298
- [No QA] Refactor create or update staging deploy to use async/await #26301
- [No QA] Include closed and demoted blockers in the checklist when updating #26332
- [CP Staging] fix: full screen abracadabra #26427
- Fix dismiss modal behavior for NotFound screen #26437
Internal QA:
- Implement report approvals #24639 - @youssef-lr
- [New Feature] - Teachers Unite sign-up flows #23063 - @youssef-lr
Deploy Blockers:
- [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-07] IOU - Can tap multi times on "Pay elsewhere" button when offline #26322
- Settings - Background has green tint when side menu is opened #26405
- [$1000] Request money - Tabs jump back and forth when swiping through tabs #26407
- [HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Chat - "Go back to Home page" unresponsive on invalid link page #26413
- [HOLD for payment 2023-09-08] [HOLD for payment 2023-09-07] [$500] Web - Sign in - "Abracadabra, you are signed in!" page is displayed in chat conversation #26417
- [HOLD for payment 2023-09-18] [HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position #26421
- Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money. #26441
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Aug 31, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.60-1 🚀
mvtglobally commentedon Aug 31, 2023
Checking off as deployed in previous builds
#20747
#21664
#24098
#24369
#24411
#24616
#25159
#25520
#25569
#25629
#25656
#25721
#25731
#25750
#25751
#25808
#25815
#25954
#25969
#25974
#25984
#26035
#26056
#26095
#26105
#26118
#26122
#26145
#26153
#26182
#26211
#26218
#26257
#26265
#26267
roryabraham commentedon Aug 31, 2023
I see why this is happening. It's a race condition between:
Both are triggered at the same time after updateStaging finishes. If
deployStagingfinishes (i.e: the tag for the new staging version is pushed to the remote) before the checklist is created, then it works. If not, then we get a huge checklist like this will all the PRs that were deployed in the previous version.Obviously not good, will need to fix this ASAP.
luacmartins commentedon Aug 31, 2023
Checking off #26413. Demoted to NAB since it happens in prod.
luacmartins commentedon Aug 31, 2023
Checking off #26421. Not one of our officially supported platforms. Demoted to NAB
mvtglobally commentedon Aug 31, 2023
@luacmartins Regression is completed
#25971 is blocked on Native apps as we cant upload PDF. Ok to check off?
#26022 is failing #26407
Can we check this one off?
luacmartins commentedon Aug 31, 2023
Checking off #26407. Happens in prod.
luacmartins commentedon Aug 31, 2023
Checking off #26417 - we merged and CPed a fix.
luacmartins commentedon Aug 31, 2023
Checking off #26441. Demoted to NAB.
luacmartins commentedon Aug 31, 2023
Checklist is clear. Just waiting for the final 2 CPs to finish and test them in staging and then we're good to go.
luacmartins commentedon Aug 31, 2023
Ok, CPs are done and they are a pass on staging. Shipping it.
luacmartins commentedon Aug 31, 2023