Repository navigation
[CP stag] 26193-Attachment- Uploading PDF displays error - #26218
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@pradeepmdk iOS video is missing. please test and upload all platform videos. |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemchrome.movMobile Web - Safarimsafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
|
Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit a156ccf)
|
🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.58-3 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀
|
|
🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
Details
Fixed Issues
$ #26193
PROPOSAL: #26193
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Untitled.mp4
Mobile Web - Chrome
WhatsApp.Video.2023-08-29.at.9.56.38.PM.mp4
Mobile Web - Safari
WhatsApp.Video.2023-08-29.at.9.54.03.PM.mp4
Desktop
Screen.Recording.2023-08-29.at.10.04.31.PM.mov
iOS
Screen.Recording.2023-08-29.at.10.13.36.PM.mov
Android
Screen.Recording.2023-08-29.at.7.05.45.PM.mov