Repository navigation
[No QA] [TS migration] Migrate textUnderline style to TypeScript - #25821
Conversation
|
@blazejkustra ready! |
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -0,0 +1,5 @@ | |||
| import {CSSProperties} from 'react'; | |||
|
|
|||
| type TextUnderlineStyles = Record<'textUnderlinePositionUnder' | 'textDecorationSkipInkNone', Partial<Pick<CSSProperties, 'textUnderlinePosition' | 'textDecorationSkipInk'>>>; | |||
There was a problem hiding this comment.
Not a blocker: if we want to be more accurate I would just use:
type TextUnderlineStyles = {
textUnderlinePosition: CSSProperties['textUnderlinePosition'];
textDecorationSkipInkNone: CSSProperties['textDecorationSkipInk'];
}There was a problem hiding this comment.
This snippet didn't work for me, but this one did:
type TextUnderlineStyles = {
textUnderlinePositionUnder: Pick<CSSProperties, 'textUnderlinePosition'>
textDecorationSkipInkNone: Pick<CSSProperties, 'textDecorationSkipInk'>
}Do you think we should change it?
|
Hi @JKobrynski do you think you could add the screenshots for mobile ios and mobile android whenever you get a chance? |
|
@srikarparsi done 😄 |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-chrome.movMobile Web - Safariios-safari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
|
LGTM! |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.60-1 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
Details
Fixed Issues
$ #24699
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android