You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both are triggered at the same time after updateStaging finishes. If deployStaging finishes (i.e: the tag for the new staging version is pushed to the remote) before the checklist is created, then it works. If not, then we get a huge checklist like this will all the PRs that were deployed in the previous version.
Solution
TBD – probably change the deploy system a bit such that staging deploys are triggered by the creation of a prerelease and production deploys by the creation of a "full" release.
That way we can push the tag as soon as it's created without triggering a deploy
Noting that the createNewDeployChecklist was moved to the platformDeploy.yml, which feels like the race condition is not happening anymore and the bug might be somewhere else.
When the updateStaging finished, it force pushes to staging branch and then the deploy.yml runs which pushes the tags and finally we trigger the platformDeploy.yml which would create the checklist but the correct tags should be available
Ok, it seems like there's some way the git history can change in production that's different from what we have represented in the CIGitLogicTest.sh, just judging by running this command on staging w/ full git history:
Neither is correct, because the only version-bump that we expect to be included between 1.3.76-6 and 1.3.77-0 is Update version to 1.3.77-0
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Nice, that worked as expected (well, maybe not the upwork bit, that's weird).
Anyways, for context I'm marking this as a deploy blocker not because we actually need to block deploy on it, but because I think we should merge #31458 before the next deploy, because it should fix this big checklist issue
Activity
roryabraham commentedon Sep 20, 2023
No update right now
roryabraham commentedon Sep 29, 2023
No update
mountiny commentedon Oct 3, 2023
Looking into this one now
Noting that the createNewDeployChecklist was moved to the platformDeploy.yml, which feels like the race condition is not happening anymore and the bug might be somewhere else.
When the
updateStagingfinished, it force pushes to staging branch and then the deploy.yml runs which pushes the tags and finally we trigger the platformDeploy.yml which would create the checklist but the correct tags should be availableLooking more into why this is failing
mountiny commentedon Oct 3, 2023
Created a PR which should hopefully help with this
roryabraham commentedon Oct 4, 2023
Ok, it seems like there's some way the git history can change in production that's different from what we have represented in the
CIGitLogicTest.sh, just judging by running this command on staging w/ full git history:Neither is correct, because the only version-bump that we expect to be included between
1.3.76-6and1.3.77-0isUpdate version to 1.3.77-020 remaining items
roryabraham commentedon Nov 18, 2023
This should be fixed by #31458. I hope so 😅
roryabraham commentedon Nov 18, 2023
That didn't work perfectly: https://github.com/Expensify/App/actions/runs/6910552568/job/18803863115. Going to retry
github-actions commentedon Nov 18, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 18, 2023
📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
roryabraham commentedon Nov 18, 2023
Nice, that worked as expected (well, maybe not the upwork bit, that's weird).
Anyways, for context I'm marking this as a deploy blocker not because we actually need to block deploy on it, but because I think we should merge #31458 before the next deploy, because it should fix this big checklist issue