You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2023-09-27] Android - Infinite loading after opening personal details page #27560
Can't open personal details page and infinite loading spinner
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.70-5 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Infinite loading when first open personal details page after updating personal details on another device
What is the root cause of that problem?
Clear repro step:
Login any account on device A
On device B, logout if already logged in
On device B, login same account as in device A
On device A, update any personal details. i.e. Date of birth
On device B, go to Settings > Profile > Personal details page
Let's find the root cause from above repro step.
On first login on B, private_personalDetails has no data in Onyx.
But after updating dob in A, B receives pusher event and Onyx data is updated to {dob: 'xxxx-xx-xx} PersonalDetailsInitialPage uses usePrivatePersonalDetails hook to get personal details data from api.
The issue is in that hook.
{dob: 'xxxx-xx-xx} meets Boolean(PersonalDetails.getPrivatePersonalDetails()) so early returned.
So even though local data is not complete (not yet fetched from api), api is never called, so isLoading key never exists which makes this condition always true:
What changes do you think we should make in order to solve the problem?
One api is called, isLoading value is added to private_personalDetails, so I think this key existence should be enough to check if personal details is fetched or not
Able to reproduce on Web as well via @mkhutornyi's repro steps. RCA is good and proposal looks good. Since this is a deploy blocker, unless we can raise a PR within the hour we might handle this internally.
@Ahmed-Abdella — can you link me your Upwork profile? I'm having trouble finding it and I want to make sure that I am sending the proposal to the correct individual. Thank you!
@mkhutornyi — same as above. I want to make sure I am sending the proposal to the correct individual as there are two "Mykhailo K." entries in Upwork.
Activity
melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 15, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @Li357 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mkhutornyi commentedon Sep 16, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Infinite loading when first open personal details page after updating personal details on another device
What is the root cause of that problem?
Clear repro step:
Let's find the root cause from above repro step.
On first login on B,
private_personalDetailshas no data in Onyx.But after updating dob in A, B receives pusher event and Onyx data is updated to
{dob: 'xxxx-xx-xx}PersonalDetailsInitialPageusesusePrivatePersonalDetailshook to get personal details data from api.The issue is in that hook.
App/src/hooks/usePrivatePersonalDetails.js
Lines 11 to 16 in 76c1559
{dob: 'xxxx-xx-xx}meetsBoolean(PersonalDetails.getPrivatePersonalDetails())so early returned.So even though local data is not complete (not yet fetched from api), api is never called, so
isLoadingkey never exists which makes this condition always true:App/src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js
Line 63 in 76c1559
What changes do you think we should make in order to solve the problem?
One api is called,
isLoadingvalue is added toprivate_personalDetails, so I think this key existence should be enough to check if personal details is fetched or notApp/src/hooks/usePrivatePersonalDetails.js
Line 12 in 76c1559
So update this condition to:
What alternative solutions did you explore? (Optional)
We may use another key instead of
isLoadingLi357 commentedon Sep 18, 2023
Able to reproduce on Web as well via @mkhutornyi's repro steps. RCA is good and proposal looks good. Since this is a deploy blocker, unless we can raise a PR within the hour we might handle this internally.
mkhutornyi commentedon Sep 18, 2023
@Li357 I can raise PR right now
42 remaining items
CortneyOfstad commentedon Oct 3, 2023
@Li357 bump on the above ^^^^
CortneyOfstad commentedon Oct 5, 2023
@Li357 bump again
Li357 commentedon Oct 6, 2023
Sorry about the delay! If I'm interpreting this SO right, that should be correct.
CortneyOfstad commentedon Oct 6, 2023
Thanks @Li357!
@Ahmed-Abdella — can you link me your Upwork profile? I'm having trouble finding it and I want to make sure that I am sending the proposal to the correct individual. Thank you!
@mkhutornyi — same as above. I want to make sure I am sending the proposal to the correct individual as there are two "Mykhailo K." entries in Upwork.
Thanks!
mkhutornyi commentedon Oct 6, 2023
@CortneyOfstad I am the one whom you just paid in #26243 🙂
Ahmed-Abdella commentedon Oct 6, 2023
@CortneyOfstad Sure, here it is https://www.upwork.com/freelancers/~014640fcd762b61d2f
CortneyOfstad commentedon Oct 6, 2023
For some reason that one had your hiring profile listed automatically, but not this one 🤔 So weird! Thanks @mkhutornyi and send over the proposal!
@Ahmed-Abdella Also sent over your proposal! Let me know when these are accepted and I'll get them paid ASAP 👍
Ahmed-Abdella commentedon Oct 6, 2023
@CortneyOfstad I accepted the offer, Thanks!
CortneyOfstad commentedon Oct 6, 2023
Both have been paid!
@Li357 and @mkhutornyi where are we at with the checklist above? Thanks!
mkhutornyi commentedon Oct 6, 2023
I can help filling checklist.
Regression Test Proposal
CortneyOfstad commentedon Oct 9, 2023
Regression Test GH created here — https://github.com/Expensify/Expensify/issues/324340
CortneyOfstad commentedon Oct 9, 2023
Thanks all! Closing!