You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Dev: Web - Click on back button close the RHP instead of opening Details page #27598
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.70.5 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Dev: Web - Click on back button close the RHP instead of opening Details page[/-][+][$500] Dev: Web - Click on back button close the RHP instead of opening Details page[/+]on Sep 16, 2023
Activity
[-]Dev: Web - Click on back button close the RHP instead of opening Details page[/-][+][$500] Dev: Web - Click on back button close the RHP instead of opening Details page[/+]melvin-bot commentedon Sep 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~013c7fb2a8b63fc0bf
melvin-bot commentedon Sep 16, 2023
Triggered auto assignment to @trjExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 16, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)hungvu193 commentedon Sep 17, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Click on back button close the RHP instead of opening Details page with the case we reload the PrivateNoteListPage.
What is the root cause of that problem?
We don't define a fallback route for it here:
App/src/pages/PrivateNotes/PrivateNotesListPage.js
Line 129 in c77814f
So when we reload the page, it will go back to the previous stack and it's RHN.
What changes do you think we should make in order to solve the problem?
We should define a fallback route for our
onBackButtonPressfuntion:We can also add the fallback route for other
onBackButtonPressof other PrivateNotesPages (details, edit...etc..)What alternative solutions did you explore? (Optional)
N/A
situchan commentedon Sep 17, 2023
Dupe of #22041
trjExpensify commentedon Sep 18, 2023
Yup, agree with that. Closing!