Skip to content

[HOLD for payment 2023-10-12] 🔴 Ensure system messages are added when distance requests are edited.  #27630

Closed

Description

@trjExpensify

Coming from here as a follow-up to editing distance requests @tgolen is working on.

We need to ensure that when the waypoints are edited, and the amount and distance field values are updated, we post the appropriate "change" system messages to log that action. Those being:

  1. modified amount = changed the amount to %newAmount% (previously %oldAmount%)
  • Example: changed the amount to $150 (previously $100)
  1. modified distance = changed the distance to %newDistance% (previously %oldDistance%)
  • Example: changed the distance to 125 miles @ £0.655 / mi (previously 120 miles @ £0.655 / mi)

CC: @JmillsExpensify @neil-marcellini

Activity

  1. melvin-bot commented on Sep 18, 2023

    @melvin-bot
  2. tgolen commented on Sep 18, 2023

    @tgolen
    Contributor

    I will start on this one. We only need to do this on the backend and we don't have to worry about doing this action optimistically on the front-end, which simplifies things. The reason we don't need to do it optimistically is because we have to use the MapBox API results in order to calculate the new route, which can only be done on the backend.

  3. changed the title [-]Ensure system messages are added when distance requests are edited. [/-] [+]🟡 Ensure system messages are added when distance requests are edited. [/+] on Sep 20, 2023
  4. self-assigned this
    on Sep 20, 2023
  5. 25 remaining items

  6. changed the title [-]🔴 Ensure system messages are added when distance requests are edited. [/-] [+][HOLD for payment 2023-10-12] 🔴 Ensure system messages are added when distance requests are edited. [/+] on Oct 5, 2023
  7. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  9. Gonals commented on Oct 16, 2023

    @Gonals
    Contributor

    not overdue

  10. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    @Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    @Gonals 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  12. Gonals commented on Oct 23, 2023

    @Gonals
    Contributor

    This should be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions