You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-12] 🔴 Ensure system messages are added when distance requests are edited. #27630
Coming from here as a follow-up to editing distance requests @tgolen is working on.
We need to ensure that when the waypoints are edited, and the amount and distance field values are updated, we post the appropriate "change" system messages to log that action. Those being:
modified amount = changed the amount to %newAmount% (previously %oldAmount%)
Example: changed the amount to $150 (previously $100)
modified distance = changed the distance to %newDistance% (previously %oldDistance%)
Example: changed the distance to 125 miles @ £0.655 / mi (previously 120 miles @ £0.655 / mi)
I will start on this one. We only need to do this on the backend and we don't have to worry about doing this action optimistically on the front-end, which simplifies things. The reason we don't need to do it optimistically is because we have to use the MapBox API results in order to calculate the new route, which can only be done on the backend.
changed the title [-]Ensure system messages are added when distance requests are edited. [/-][+]🟡 Ensure system messages are added when distance requests are edited. [/+]on Sep 20, 2023
changed the title [-]🔴 Ensure system messages are added when distance requests are edited. [/-][+][HOLD for payment 2023-10-12] 🔴 Ensure system messages are added when distance requests are edited. [/+]on Oct 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to @alexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.tgolen commentedon Sep 18, 2023
I will start on this one. We only need to do this on the backend and we don't have to worry about doing this action optimistically on the front-end, which simplifies things. The reason we don't need to do it optimistically is because we have to use the MapBox API results in order to calculate the new route, which can only be done on the backend.
[-]Ensure system messages are added when distance requests are edited. [/-][+]🟡 Ensure system messages are added when distance requests are edited. [/+]25 remaining items
[-]🔴 Ensure system messages are added when distance requests are edited. [/-][+][HOLD for payment 2023-10-12] 🔴 Ensure system messages are added when distance requests are edited. [/+]melvin-bot commentedon Oct 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Gonals commentedon Oct 16, 2023
not overdue
melvin-bot commentedon Oct 19, 2023
@Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 23, 2023
@Gonals 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Gonals commentedon Oct 23, 2023
This should be done