Repository navigation
Display correct message when editing distance requests - #27979
Conversation
|
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| }, | ||
| }); | ||
|
|
||
| // Step 4: Comput the IOU total and update the report preview message (and report header) so LHN amount owed is correct. |
| route: {}, | ||
| }; | ||
|
|
||
| // This component is responsible for grabbing the transactionID from the IOU key |
There was a problem hiding this comment.
Is it some magic I'm not familiar with? This component seems to do nothing beyond forwarding the route property
There was a problem hiding this comment.
Or was this comment copy-pasted?
|
Well, it's a big one. To be honest, I'm not completely sure I'm experienced enough to review the high-level decisions here. I left minor comments and can help with the testing. |
Ah! Don't worry too much about it. It looks big because it comes from #26141 's branch. Once that one merges, it will become simple :) |
|
@cubuspl42 Ready for review! Should be waaaay simpler now 😁 |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks great, assuming the C+ testing goes well! There's one JSDoc that needs to be updated.
| /** | ||
| * Get the proper message schema for modified expense message. | ||
| * | ||
| * @param {String} newValue | ||
| * @param {String} oldValue | ||
| * @param {String} valueName | ||
| * @param {Boolean} valueInQuotes | ||
| * @returns {String} | ||
| */ |
There was a problem hiding this comment.
Looks like this was pasted from above but you forgot to update it
I don't have access to the steps nor the screenshot... Maybe they can be copied here? |
Huh. Weird. Here are the test steps:
|
|
@Gonals I just don't have access to https://github.com/Expensify/Web-Expensify, but that's typical for C+ team, I think. The screenshot still doesn't work, but maybe I'll figure things out without it |
Ah, gotcha! Yeah, try creating it from newDot doing The message should say: |
|
@Gonals Would you please merge I'm having trouble going past pressing "+" (I always test with latest |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good and tests well on web at least. In the interest of urgency I'm going to ask for another C+ in Slack to complete the checklist.
Screen.Recording.2023-10-02.at.10.47.39.AM.mov
that is unrelated to this PR. it's a bug on |
Reviewer Checklist
Screenshots/Videos |
|
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
|
Can I have an Expensify employee provide a payment summary so that I can get @rushatgabhane paid? |
|
Payment summary: $500 to @rushatgabhane for the PR review. |
|
$500 payment approved for @rushatgabhane based on summary above. |






Details
Fixed Issues
$ #27630
PROPOSAL:
Tests
Distance.Offline tests
None
QA Steps
Distance.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android