You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Task - [Deleted task] is not grayed out in task report when the task is deleted offline #28190
Click three-dot menu > Cancel (you should see [Deleted Task])
Return to the 1:1 DM where the task is shared
Expected Result:
In Step 4, after deleting the task, [Deleted task] message is grayed out
Actual Result:
In Step 4, after deleting the task, [Deleted task] message is not grayed out in the task report, while [Deleted task] is grayed out in 1:1 DM in Step 5
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
I can reproduce this but I'm not actually sure if this is a bug or a feature request.
When you come back online, the [Deleted Task] is bold in both the chat and the Task Assignment. I don't know if this needs to be fixed now. What is expected when you're online? It should be bold right?
This is a polish job so something we should move forward with fixing.
Expensify Tasks Design doc (not available for everyone) says we follow offline first. So that would indicate that the [Deleted Message] needs to be greyed out not bold.
I'm not sure if this should be Internal or External so adding External.
One more thing, We want to grey out the first message of task report (It is a report action). IMO, It is more suitable if we use pending action of report action to grey out report action (this is way we use in other palces). we shouldn't use pending action of report to grey out the report action (don't use in other places).
@DylanDylann The task report is already greyed out in LHN for me on latest main.
Remember that the point of pendingAction isn't only to grey things out 😄 We could also technically just pass isDeletedParentAction as the pendingAction in OfflineWithFeedback, since we already set that optimistically here but I think we're just splitting hairs here as any method works, unless @francoisl has a strong opinion otherwise!
We want to grey out the first message of task report (It is a report action). IMO, It is more suitable if we use pending action of report action to grey out report action (this is way we use in other palces). we shouldn't use pending action of report to grey out the report action (don't use in other places).
Just a final note, some action to task report on offline will make the first message of task report is greyed out if we use pendingAction of report for it.
Looks like we just did some refactoring for tasks with #24601 / #27827 and I'm not sure this is still an issue... in particular, after canceling a task while offline, we now still display the regular task view, with the task name / checkbox, description and assignee - and no [Deleted task] message as reported above.
Screen.Recording.2023-10-03.at.9.06.04.PM.mov
Am I missing something, or is this no longer an issue?
Looks like we just did some refactoring for tasks with #24601 / #27827 and I'm not sure this is still an issue... in particular, after canceling a task while offline, we now still display the regular task view, with the task name / checkbox, description and assignee - and no [Deleted task] message as reported above.
Screen.Recording.2023-10-03.at.9.06.04.PM.mov
Am I missing something, or is this no longer an issue?
Hmm yeah, It seems we are no longer added [Deleted task] message. So this is not reproducible anymore.
I believe your "New UI task page" is from the video in the original post on an older version? Anyway, looks like this is no longer an issue, going to close.
Thanks for the proposals anyway everyone, and on to the next one 🚀
Activity
melvin-bot commentedon Sep 25, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon Sep 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - [Deleted task] is not grayed out in task report when the task is deleted offline
What is the root cause of that problem?
When user canceled a task, we only added the pendingAction for taskAction and the parentAction here:
App/src/libs/actions/Task.js
Lines 768 to 769 in e14e9ee
App/src/libs/actions/Task.js
Lines 807 to 810 in e14e9ee
Also we didn't wrap our canceled task view with OfflineWithFeedback, so we it won't grey out when task is deleted offline:
App/src/pages/home/report/ReportActionItem.js
Lines 522 to 534 in e14e9ee
What changes do you think we should make in order to solve the problem?
Add
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATEto ouroptimisticDatahereAlso clean up it here:
Finally wrap our canceled task view with OfflineWithFeedback.
What alternative solutions did you explore? (Optional)
N/A
DylanDylann commentedon Sep 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
[Deleted task] is not grey when cancelling task offline
What is the root cause of that problem?
App/src/pages/home/report/ReportActionItem.js
Lines 521 to 536 in b9a2f62
We don’t wrap [Deleted task] message by OfflineWithFeedback Component
What changes do you think we should make in order to solve the problem?
we should add OfflineWithFeedback Component as wrapper like this
DylanDylann commentedon Sep 26, 2023
My proposal post first in Slack
Christinadobrzyn commentedon Sep 26, 2023
I can reproduce this but I'm not actually sure if this is a bug or a feature request.
When you come back online, the [Deleted Task] is bold in both the chat and the Task Assignment. I don't know if this needs to be fixed now. What is expected when you're online? It should be bold right?
Christinadobrzyn commentedon Sep 26, 2023
Asking the team - https://expensify.slack.com/archives/C01SKUP7QR0/p1695748789919179
Christinadobrzyn commentedon Sep 26, 2023
Follow up from Slack chat: https://expensify.slack.com/archives/C01SKUP7QR0/p1695748789919179
This is a polish job so something we should move forward with fixing.
Expensify Tasks Design doc (not available for everyone) says we follow offline first. So that would indicate that the [Deleted Message] needs to be greyed out not bold.
I'm not sure if this should be Internal or External so adding External.
melvin-bot commentedon Sep 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0140a361ebd43cf297
melvin-bot commentedon Sep 26, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (
Internal)20 remaining items
jjcoffee commentedon Oct 3, 2023
@hungvu193 Do you want to weigh in on this?
hungvu193 commentedon Oct 3, 2023
I believe the task in LHN grey out is expected, because we're deleting the task not a specific action.
DylanDylann commentedon Oct 3, 2023
One more thing, We want to grey out the first message of task report (It is a report action). IMO, It is more suitable if we use pending action of report action to grey out report action (this is way we use in other palces). we shouldn't use pending action of report to grey out the report action (don't use in other places).
hungvu193 commentedon Oct 3, 2023
We still use the pendingAction of the report for action for few cases, for examples:
App/src/pages/home/report/ReportActionItemParentAction.js
Line 58 in 0aafbf5
In this case, I just want to update pendingAction on the actual task report.
jjcoffee commentedon Oct 3, 2023
@DylanDylann The task report is already greyed out in LHN for me on latest main.
Remember that the point of
pendingActionisn't only to grey things out 😄 We could also technically just passisDeletedParentActionas thependingActioninOfflineWithFeedback, since we already set that optimistically here but I think we're just splitting hairs here as any method works, unless @francoisl has a strong opinion otherwise!DylanDylann commentedon Oct 3, 2023
Just a final note, some action to task report on offline will make the first message of task report is greyed out if we use pendingAction of report for it.
melvin-bot commentedon Oct 3, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Christinadobrzyn commentedon Oct 3, 2023
hi @jjcoffee let me know if these proposals are looking good or if you'd like to see more!
francoisl commentedon Oct 4, 2023
Looks like we just did some refactoring for tasks with #24601 / #27827 and I'm not sure this is still an issue... in particular, after canceling a task while offline, we now still display the regular task view, with the task name / checkbox, description and assignee - and no
[Deleted task]message as reported above.Screen.Recording.2023-10-03.at.9.06.04.PM.mov
Am I missing something, or is this no longer an issue?
hungvu193 commentedon Oct 4, 2023
Hmm yeah, It seems we are no longer added [Deleted task] message. So this is not reproducible anymore.
jjcoffee commentedon Oct 4, 2023
Sorry I missed that! We're good to close this then @francoisl
Christinadobrzyn commentedon Oct 4, 2023
I'll ask QA to test just to make sure this is not happening anymore - https://expensify.slack.com/archives/C9YU7BX5M/p1696434612063849
kbecciv commentedon Oct 4, 2023
@Christinadobrzyn Issue is not reproduced on v1.3.77-5. We are seeing old UI task page instead of the new one. Is this expected?
20231005_001741.mp4
New UI task page

francoisl commentedon Oct 5, 2023
I believe your "New UI task page" is from the video in the original post on an older version? Anyway, looks like this is no longer an issue, going to close.
Thanks for the proposals anyway everyone, and on to the next one 🚀