Skip to content

[HOLD for payment 2023-11-27] [$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user #29112

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696789311359329

Action Performed:

  1. Create a public room AS user "A". Copy link to room.
  2. Log out of app and open the link.
  3. Click on Sign in Button on LHN.
  4. Open Search page using keyboard shortcut (CTRL+K).

Expected Result:

Search page should open with animation from right side same as Send Message page

Actual Result:

Search page not opening with animation from right side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
n/a
Android: mWeb Chrome
n/a
iOS: Native
n/a
iOS: mWeb Safari
n/a
MacOS: Chrome / Safari
Screen.Recording.2023-10-08.at.11.55.00.PM.mov
MacOS: Desktop
n/a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c3e6703d5cc7641
  • Upwork Job ID: 1711442560781221888
  • Last Price Increase: 2023-10-31
  • Automatic offers:
    • fedirjh | Reviewer | 27503376
    • b4s36t4 | Contributor | 27503379
    • ishpaul777 | Reporter | 27503380

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 9, 2023
  2. changed the title [-]Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-] [+][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+] on Oct 9, 2023
  3. melvin-bot commented on Oct 9, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 9, 2023
  5. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  6. changed the title [-][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-] [+][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+] on Oct 9, 2023
  7. shahzoab commented on Oct 9, 2023

    @shahzoab

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a modal is already opened before pressing the keyboard shortcut for the search modal, it does not appear with a transition.

    What is the root cause of that problem?

    The animation has been intentionally disabled due to an animation glitch while using keyboard shortcuts.

    <Stack.Screen
    name="Search"
    component={ModalStackNavigators.SearchModalStackNavigator}
    options={{
    // Disable animation for this screen because it causes an animation glitch when using shortcuts
    animationEnabled: false,
    }}
    />

    What changes do you think we should make in order to solve the problem?

    We can make animationEnabled true and then test if there's any glitch in the animation as mentioned in the code comment.

    <Stack.Screen
        name="Search"
        component={ModalStackNavigators.SearchModalStackNavigator}
        options={{
            animationEnabled: true,
        }}
    />
    

    What alternative solutions did you explore? (Optional)

    N/A

  8. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    📣 @shahzoab! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. shahzoab commented on Oct 9, 2023

    @shahzoab

    Contributor details
    Your Expensify account email: shahzoab@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0197e6d2b5bd5f4085

  10. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  11. b4s36t4 commented on Oct 9, 2023

    @b4s36t4
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user

    What is the root cause of that problem?

    We intentionally stopped animation for the Search Screens cause of few issues with the animation when tried accessing using shortcut while doing navigation refactoring.

    But at this point where we have a matured navigation & handling everything clearly we can enable the animation now.

    What changes do you think we should make in order to solve the problem?

    Remove options from the Screen component here

    <Stack.Screen
    name="Search"
    component={ModalStackNavigators.SearchModalStackNavigator}
    options={{
    // Disable animation for this screen because it causes an animation glitch when using shortcuts
    animationEnabled: false,
    }}
    />

    What alternative solutions did you explore? (Optional)

    We can leave this as it is done as intentional, although it happens with any RHP screens

  12. changed the title [-][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-] [+][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+] on Oct 10, 2023
  13. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Upwork job price has been updated to $250

  14. 51 remaining items

  15. changed the title [-][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-] [+][HOLD for payment 2023-11-27] [$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+] on Nov 20, 2023
  16. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger / @peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. peterdbarkerUK commented on Nov 29, 2023

    @peterdbarkerUK
    Contributor

    Payment Summary:

  20. fedirjh commented on Nov 29, 2023

    @fedirjh
    Contributor

    @peterdbarkerUK Thank you. Accepted


    BugZero Checklist:

  21. sakluger commented on Nov 30, 2023

    @sakluger
    Contributor

    All paid out, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions