You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-27] [$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user #29112
changed the title [-]Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]on Oct 9, 2023
changed the title [-][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]on Oct 9, 2023
📣 @shahzoab! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user
What is the root cause of that problem?
We intentionally stopped animation for the Search Screens cause of few issues with the animation when tried accessing using shortcut while doing navigation refactoring.
But at this point where we have a matured navigation & handling everything clearly we can enable the animation now.
What changes do you think we should make in order to solve the problem?
changed the title [-][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]on Oct 10, 2023
changed the title [-][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][HOLD for payment 2023-11-27] [$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]on Nov 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger / @peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]melvin-bot commentedon Oct 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019c3e6703d5cc7641
melvin-bot commentedon Oct 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)[-][$500] Dev: Desktop - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]shahzoab commentedon Oct 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a modal is already opened before pressing the keyboard shortcut for the search modal, it does not appear with a transition.
What is the root cause of that problem?
The animation has been intentionally disabled due to an animation glitch while using keyboard shortcuts.
App/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js
Lines 35 to 42 in 4a24fd6
What changes do you think we should make in order to solve the problem?
We can make animationEnabled true and then test if there's any glitch in the animation as mentioned in the code comment.
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Oct 9, 2023
📣 @shahzoab! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
shahzoab commentedon Oct 9, 2023
Contributor details
Your Expensify account email: shahzoab@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0197e6d2b5bd5f4085
melvin-bot commentedon Oct 9, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
b4s36t4 commentedon Oct 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user
What is the root cause of that problem?
We intentionally stopped animation for the Search Screens cause of few issues with the animation when tried accessing using shortcut while doing navigation refactoring.
But at this point where we have a matured navigation & handling everything clearly we can enable the animation now.
What changes do you think we should make in order to solve the problem?
Remove
optionsfrom theScreencomponent hereApp/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js
Lines 35 to 42 in 547e10d
What alternative solutions did you explore? (Optional)
We can leave this as it is done as intentional, although it happens with any RHP screens
[-][$500] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]melvin-bot commentedon Oct 10, 2023
Upwork job price has been updated to $250
51 remaining items
[-][$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/-][+][HOLD for payment 2023-11-27] [$250] Dev: Web - Search page is not opening with transition when navigating with keyboard shortcut while on sign in page as anonymous user[/+]melvin-bot commentedon Nov 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
peterdbarkerUK commentedon Nov 29, 2023
Payment Summary:
fedirjh commentedon Nov 29, 2023
@peterdbarkerUK Thank you. Accepted
BugZero Checklist:
sakluger commentedon Nov 30, 2023
All paid out, thanks!