Repository navigation
fix: remove options props - #30885
Merged
MonilBhavsar merged 1 commit intoNov 15, 2023
Merged
MonilBhavsar merged 1 commit into
MonilBhavsar merged 1 commit into
Conversation
1 of 6 tasks
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2023-11-07.at.12.50.58.mp4Android: mWeb ChromeCleanShot.2023-11-07.at.12.59.49.mp4iOS: NativeCleanShot.2023-11-07.at.12.09.47.mp4iOS: mWeb SafariCleanShot.2023-11-07.at.12.11.14.mp4MacOS: Chrome / SafariCleanShot.2023-11-07.at.11.57.23.mp4MacOS: DesktopCleanShot.2023-11-07.at.12.01.30.mp4 |
MonilBhavsar
reviewed
Nov 7, 2023
MonilBhavsar
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
@b4s36t4 could you please add screenshot for mWeb
Contributor
|
@b4s36t4 👋 |
Contributor
Author
|
Hey, @MonilBhavsar Sorry. I was out and I don't have laptop with me, I'll do that by evening. Sorry again for the delay. |
Contributor
|
No worries, thanks for the update |
Contributor
|
@b4s36t4 Friendly bump, can we move this forward ? |
Contributor
Author
|
@fedirjh @MonilBhavsar So sorry for the long delay. Attached the screenshot for Android Chrome. Please check. Let me know if there is anything required from my side. Thanks :) |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
37 tasks done
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Search navbar doesn't showup with animation as its disabled in options props. However, animation is now enabled at parent level so removing the options props.
Fixed Issues
$ #29112
PROPOSAL: #29112 (comment)
Tests
Steps:
Open any right side nav (settings for example)
Use keyboard shortcuts (CMD+K or CMD+SHIFT+K) to trigger search
Notice the animation while search sidebar is opening - it should animate instead of direct showup
Verify that no errors appear in the JS console
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-app.mp4
Android: mWeb Chrome
mwed.mp4
iOS: Native
ios-app.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4